loplugin:unusedmethods unused return value in slideshow

Change-Id: I1ed955a0e474a755949e80eef60c8cd19f43fd0e

8 files changed, 28 insertions, 88 deletions

diff --git a/slideshow/source/inc/animatedsprite.hxx b/slideshow/source/inc/animatedsprite.hxx
index c6c1e4b9af38..8e9520296c57 100644
--- a/slideshow/source/inc/animatedsprite.hxx
+++ b/slideshow/source/inc/animatedsprite.hxx
@@ -73,11 +73,8 @@ namespace slideshow
 
                 @param rSpriteSizePixel
                 The new size in pixel
-
-                @return true, if the resize was successful. If false
-                is returned, the sprite might be invalid.
              */
-            bool resize( const ::basegfx::B2DSize& rSpriteSizePixel );
+            void resize( const ::basegfx::B2DSize& rSpriteSizePixel );
 
             /** Set an offset for the content output in pixel
 
diff --git a/slideshow/source/inc/animationnode.hxx b/slideshow/source/inc/animationnode.hxx
index 8eabe47e98be..eb856cc5d613 100644
--- a/slideshow/source/inc/animationnode.hxx
+++ b/slideshow/source/inc/animationnode.hxx
@@ -86,12 +86,8 @@ public:
 
         This method starts the animation on this node, without
         begin timeout. The node will change its state to ACTIVE.
-
-        @return true, if start was successful. This method
-        might return false, if e.g. a restart is not permitted
-        on this node.
     */
-    virtual bool activate() = 0;
+    virtual void activate() = 0;
 
     /** Immediately stop this node
 
diff --git a/slideshow/source/inc/eventmultiplexer.hxx b/slideshow/source/inc/eventmultiplexer.hxx
index e808b6d1a39a..4ae4feaa54e7 100644
--- a/slideshow/source/inc/eventmultiplexer.hxx
+++ b/slideshow/source/inc/eventmultiplexer.hxx
@@ -445,14 +445,14 @@ public:
         displayed on. On every added view, the EventMultiplexer
         registers mouse and motion event listeners.
     */
-    bool notifyViewAdded( const UnoViewSharedPtr& rView );
+    void notifyViewAdded( const UnoViewSharedPtr& rView );
 
     /** View removed
 
         This method removes a view. Registered mouse and
         motion event listeners are revoked.
     */
-    bool notifyViewRemoved( const UnoViewSharedPtr& rView );
+    void notifyViewRemoved( const UnoViewSharedPtr& rView );
 
     /** View changed
 
@@ -472,7 +472,7 @@ public:
         @param xView
         View that has changed
     */
-    bool notifyViewChanged( const css::uno::Reference<css::presentation::XSlideShowView>& xView );
+    void notifyViewChanged( const css::uno::Reference<css::presentation::XSlideShowView>& xView );
 
     /** All Views changed
 
@@ -480,7 +480,7 @@ public:
         <em>every</em> known view has changed. View changes include
         size and transformation.
     */
-    bool notifyViewsChanged();
+    void notifyViewsChanged();
 
     /** View clobbered
 
@@ -490,28 +490,22 @@ public:
         @param xView
         View that has been clobbered
     */
-    bool notifyViewClobbered( const css::uno::Reference<css::presentation::XSlideShowView>& xView );
+    void notifyViewClobbered( const css::uno::Reference<css::presentation::XSlideShowView>& xView );
 
     /** New shape event listener added
 
         This method announces that the given listener was added for
         the specified shape.
-
-        @return true, if at least one handler successfully processed
-        the notification.
      */
-    bool notifyShapeListenerAdded( const css::uno::Reference<css::presentation::XShapeEventListener>& xListener,
+    void notifyShapeListenerAdded( const css::uno::Reference<css::presentation::XShapeEventListener>& xListener,
                                    const css::uno::Reference<css::drawing::XShape>&                   xShape );
 
     /** A shape event listener was removed
 
         This method announces that the given listener was removed for
         the specified shape.
-
-        @return true, if at least one handler successfully processed
-        the notification.
      */
-    bool notifyShapeListenerRemoved( const css::uno::Reference<css::presentation::XShapeEventListener>& xListener,
+    void notifyShapeListenerRemoved( const css::uno::Reference<css::presentation::XShapeEventListener>& xListener,
                                      const css::uno::Reference<css::drawing::XShape>&                   xShape );
 
     /** Notify a new user paint color
@@ -519,23 +513,15 @@ public:
         Sending this notification also implies that user paint is
         enabled. User paint denotes the feature to draw colored lines
         on top of the slide content.
-
-        @return true, if this event was processed by
-        anybody. If false is returned, no handler processed
-        this event (and probably, nothing will happen at all)
     */
-    bool notifyUserPaintColor( RGBColor const& rUserColor );
+    void notifyUserPaintColor( RGBColor const& rUserColor );
 
     /** Notify a new user paint width
 
          Sending this notification also implies that user paint is
          enabled. .
-
-         @return true, if this event was processed by
-         anybody. If false is returned, no handler processed
-         this event (and probably, nothing will happen at all)
-         */
-    bool notifyUserPaintStrokeWidth( double rUserStrokeWidth );
+    */
+    void notifyUserPaintStrokeWidth( double rUserStrokeWidth );
 
 
     /** Notify a new user paint erase all ink mode
@@ -543,26 +529,18 @@ public:
      Sending this notification also implies that user paint is
      enabled. User paint denotes the feature to draw colored lines
      on top of the slide content.
-
-     @return true, if this event was processed by
-     anybody. If false is returned, no handler processed
-     this event (and probably, nothing will happen at all)
      */
-    bool notifyEraseAllInk( bool const& rEraseAllInk );
-    bool notifySwitchPenMode();
-    bool notifySwitchEraserMode();
-    bool notifyEraseInkWidth( sal_Int32 rEraseInkSize );
+    void notifyEraseAllInk( bool const& rEraseAllInk );
+    void notifySwitchPenMode();
+    void notifySwitchEraserMode();
+    void notifyEraseInkWidth( sal_Int32 rEraseInkSize );
 
     /** Notify that user paint is disabled
 
         User paint denotes the feature to draw colored lines on top of
         the slide content.
-
-        @return true, if this event was processed by
-        anybody. If false is returned, no handler processed
-        this event (and probably, nothing will happen at all)
     */
-    bool notifyUserPaintDisabled();
+    void notifyUserPaintDisabled();
 
     /** Notify that the user requested the next effect.
 
@@ -580,12 +558,8 @@ public:
         This method is to be used from the Presentation object
         to signal that a new slide is starting now. This will
         invoke all registered slide start handlers.
-
-        @return true, if this event was processed by
-        anybody. If false is returned, no handler processed
-        this event (and probably, nothing will happen at all)
     */
-    bool notifySlideStartEvent();
+    void notifySlideStartEvent();
 
     /** Notify that a slide has ended
 
@@ -662,12 +636,8 @@ public:
         to signal that a slide is entering (bPauseShow=true)
         or exiting (bPauseShow=false) pause mode. This will
         invoke all registered slide end handlers.
-
-        @return true, if this event was processed by
-        anybody. If false is returned, no handler processed
-        this event (and probably, nothing will happen at all)
     */
-    bool notifyPauseMode( bool bPauseShow );
+    void notifyPauseMode( bool bPauseShow );
 
     /** Notify that all audio has to be stopped.
 
@@ -682,12 +652,8 @@ public:
     bool notifyCommandStopAudio( const boost::shared_ptr<AnimationNode>& rNode );
 
     /** Notifies that a hyperlink has been clicked.
-
-        @return true, if this event was processed by
-        anybody. If false is returned, no handler processed
-        this event (and probably, nothing will happen at all)
     */
-    bool notifyHyperlinkClicked( OUString const& hyperLink );
+    void notifyHyperlinkClicked( OUString const& hyperLink );
 
 private:
     std::unique_ptr<EventMultiplexerImpl> mpImpl;
diff --git a/slideshow/source/inc/listenercontainer.hxx b/slideshow/source/inc/listenercontainer.hxx
index db9f2aec3c45..4416c6aafdbf 100644
--- a/slideshow/source/inc/listenercontainer.hxx
+++ b/slideshow/source/inc/listenercontainer.hxx
@@ -252,25 +252,20 @@ public:
 
         @param rListener
         Listener to add
-
-        @return false, if the listener is already added, true
-        otherwise
      */
-    bool add( listener_type const& rListener )
+    void add( listener_type const& rListener )
     {
         Guard aGuard(*this);
 
         // ensure uniqueness
         if( isAdded(rListener) )
-            return false; // already added
+            return; // already added
 
         maListeners.push_back( rListener );
 
         ListenerOperations<ListenerT>::pruneListeners(
             maListeners,
             MaxDeceasedListenerUllage);
-
-        return true;
     }
 
     /** Add new listener into sorted container
diff --git a/slideshow/source/inc/shape.hxx b/slideshow/source/inc/shape.hxx
index a0ed0d38d7ac..7bcb7147a72a 100644
--- a/slideshow/source/inc/shape.hxx
+++ b/slideshow/source/inc/shape.hxx
@@ -99,7 +99,7 @@ namespace slideshow
                 This method will be faster than repeated
                 removeViewLayer() calls.
              */
-            virtual bool clearAllViewLayers() = 0;
+            virtual void clearAllViewLayers() = 0;
 
             // render methods
 
@@ -246,10 +246,6 @@ namespace slideshow
                     return compare(rLHS.get(),rRHS.get());
                 }
 
-                bool operator()(const Shape* pLHS, const Shape* pRHS) const
-                {
-                    return compare(pLHS, pRHS);
-                }
             };
         };
 
diff --git a/slideshow/source/inc/shapesubset.hxx b/slideshow/source/inc/shapesubset.hxx
index e32fb0c23193..6405da78ab1d 100644
--- a/slideshow/source/inc/shapesubset.hxx
+++ b/slideshow/source/inc/shapesubset.hxx
@@ -104,10 +104,8 @@ namespace slideshow
                 successful completion of this method, the original
                 shape will cease to show the subset range, and
                 getSubsetShape() will return a valid shape.
-
-                @return true, if subsetting was successfully enabled.
              */
-            bool            enableSubsetShape();
+            void            enableSubsetShape();
 
             /** Disable the subset shape.
 
diff --git a/slideshow/source/inc/slide.hxx b/slideshow/source/inc/slide.hxx
index 8c3b40f9d4a9..264b2a235bd5 100644
--- a/slideshow/source/inc/slide.hxx
+++ b/slideshow/source/inc/slide.hxx
@@ -67,7 +67,7 @@ namespace slideshow
                 prefetch() is not called explicitly, the named
                 methods will call it implicitly.
              */
-            virtual bool prefetch() = 0;
+            virtual void prefetch() = 0;
 
             /** Shows the slide on all registered views
 
@@ -80,7 +80,7 @@ namespace slideshow
                 transition). When false, Slide renders initial content of
                 slide.
              */
-            virtual bool show( bool bSlideBackgoundPainted ) = 0;
+            virtual void show( bool bSlideBackgoundPainted ) = 0;
 
             /** Force-ends the slide
 
diff --git a/slideshow/source/inc/subsettableshapemanager.hxx b/slideshow/source/inc/subsettableshapemanager.hxx
index 42f58bb5a9c1..54cc34db4200 100644
--- a/slideshow/source/inc/subsettableshapemanager.hxx
+++ b/slideshow/source/inc/subsettableshapemanager.hxx
@@ -95,20 +95,12 @@ namespace slideshow
             virtual void removeIntrinsicAnimationHandler( const IntrinsicAnimationEventHandlerSharedPtr& rHandler ) = 0;
 
             /** Notify that shape-intrinsic animations are now enabled.
-
-                @return true, if this event was processed by
-                anybody. If false is returned, no handler processed
-                this event (and probably, nothing will happen at all)
             */
-            virtual bool notifyIntrinsicAnimationsEnabled() = 0;
+            virtual void notifyIntrinsicAnimationsEnabled() = 0;
 
             /** Notify that shape-intrinsic animations are now disabled.
-
-                @return true, if this event was processed by
-                anybody. If false is returned, no handler processed
-                this event (and probably, nothing will happen at all)
             */
-            virtual bool notifyIntrinsicAnimationsDisabled() = 0;
+            virtual void notifyIntrinsicAnimationsDisabled() = 0;
         };
 
         typedef ::boost::shared_ptr< SubsettableShapeManager > SubsettableShapeManagerSharedPtr;