summaryrefslogtreecommitdiff
path: root/sfx2
diff options
context:
space:
mode:
authorTor Lillqvist <tml@collabora.com>2016-11-02 10:55:45 +0200
committerTor Lillqvist <tml@collabora.com>2016-11-02 10:56:42 +0200
commit8e904d334cbf3c10202d486e0b6e2e58edec3f9c (patch)
tree8dc9ed2d0c1120aa1f9a8e5c422a18a0df2d22b7 /sfx2
parent8251b57dec1adb7f6bb76493ae446dea77651544 (diff)
Add a comment wondering about "ODF Version", further explanations welcome
Change-Id: Idc660ba71ccff02c97a018838974430c0206ace6
Diffstat (limited to 'sfx2')
-rw-r--r--sfx2/source/doc/objserv.cxx8
1 files changed, 8 insertions, 0 deletions
diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index 9e1d8ef978af..5a77b77e228c 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -1387,6 +1387,14 @@ void SfxObjectShell::ImplSign( bool bScriptingContent )
bool bHasSign = ( pImpl->nScriptingSignatureState != SignatureState::NOSIGNATURES || pImpl->nDocumentSignatureState != SignatureState::NOSIGNATURES );
// the target ODF version on saving
+
+ // Please fix this comment if you can: Note that the talk about "ODF version" around here is a
+ // bit silly, as there should be nothing ODF-specific in this code, right? What we mean, I
+ // think, is "ODF version iff it is ODF that is the format the document is being stored as", and
+ // otherwise the "ODF version" is ignored. Not sure why such format-specific things needs to be
+ // handled here. Digital signatures then complicate matters further, as it's only ODF 1.2 and
+ // OOXML that have digital signatures.
+
SvtSaveOptions aSaveOpt;
SvtSaveOptions::ODFDefaultVersion nVersion = aSaveOpt.GetODFDefaultVersion();