loplugin:passstuffbyref in sfx2

Change-Id: I8c9d6e972f74ee04c8befda3b4cabb6e9b6b2054

17 files changed, 24 insertions, 24 deletions

diff --git a/sfx2/inc/sorgitm.hxx b/sfx2/inc/sorgitm.hxx
index 69c833ea9ab6..45b5d795803f 100644
--- a/sfx2/inc/sorgitm.hxx
+++ b/sfx2/inc/sorgitm.hxx
@@ -38,7 +38,7 @@ public:
     virtual bool          operator==( const SfxPoolItem& ) const override;
     virtual bool          QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool          PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
-    OUString              getLanguage() const { return aLanguage; };
+    const OUString&       getLanguage() const { return aLanguage; };
 };
 
 #endif
diff --git a/sfx2/source/appl/childwin.cxx b/sfx2/source/appl/childwin.cxx
index c3e8218b65ac..d0c48f5393ff 100644
--- a/sfx2/source/appl/childwin.cxx
+++ b/sfx2/source/appl/childwin.cxx
@@ -688,7 +688,7 @@ bool SfxChildWindow::QueryClose()
     return bAllow;
 }
 
-css::uno::Reference< css::frame::XFrame >  SfxChildWindow::GetFrame()
+const css::uno::Reference< css::frame::XFrame >&  SfxChildWindow::GetFrame()
 {
     return pImp->xFrame;
 }
diff --git a/sfx2/source/appl/helpinterceptor.hxx b/sfx2/source/appl/helpinterceptor.hxx
index 8356c309c1c2..66a38edbeb70 100644
--- a/sfx2/source/appl/helpinterceptor.hxx
+++ b/sfx2/source/appl/helpinterceptor.hxx
@@ -74,7 +74,7 @@ public:
     virtual ~HelpInterceptor_Impl();
 
     void                    setInterception( const css::uno::Reference< css::frame::XFrame >& xFrame );
-    OUString                GetCurrentURL() const { return m_aCurrentURL; }
+    const OUString&         GetCurrentURL() const { return m_aCurrentURL; }
 
 
     const css::uno::Any&     GetViewData()const {return m_aViewData;}
@@ -129,7 +129,7 @@ public:
                                 throw( css::uno::RuntimeException, std::exception ) override;
 
     void                    SetChangeHdl( const Link<HelpListener_Impl&,void>& rLink ) { aChangeLink = rLink; }
-    OUString                GetFactory() const { return aFactory; }
+    const OUString&         GetFactory() const { return aFactory; }
 };
 // HelpStatusListener_Impl -----------------------------------------------------
 
diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index 93140f57686e..d340a8417e82 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -151,7 +151,7 @@ public:
 
     void                SetDoubleClickHdl( const Link<ComboBox&,void>& rLink );
     void                SetFactory( const OUString& rFactory );
-    inline OUString     GetFactory() const { return sFactory; }
+    const OUString&     GetFactory() const { return sFactory; }
     OUString            GetSelectEntry() const;
     inline void         SetFocusOnBox() { m_pIndexCB->GrabFocus(); }
     inline bool         HasFocusOnEdit() const { return m_pIndexCB->HasChildPathFocus(); }
@@ -470,7 +470,7 @@ public:
     virtual void            GetFocus() override;
     virtual void            DataChanged( const DataChangedEvent& rDCEvt ) override;
 
-    inline css::uno::Reference < css::frame::XFrame2 >
+    const css::uno::Reference < css::frame::XFrame2 >&
                             getFrame() const { return xFrame; }
 
     inline void             SetSelectHdl( const Link<ToolBox *, void>& rLink ) { aToolBox->SetSelectHdl( rLink ); }
@@ -478,7 +478,7 @@ public:
     void                    SelectSearchText( const OUString& rSearchText, bool _bIsFullWordSearch );
     void                    SetPageStyleHeaderOff() const;
     inline ToolBox&         GetToolBox() { return *aToolBox.get(); }
-     void                   CloseFrame();
+    void                    CloseFrame();
     void                    DoSearch();
 };
 
diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx
index 1833992a5545..ccf5c2f81048 100644
--- a/sfx2/source/control/bindings.cxx
+++ b/sfx2/source/control/bindings.cxx
@@ -2085,7 +2085,7 @@ bool SfxBindings::ExecuteCommand_Impl( const OUString& rCommand )
     return false;
 }
 
-css::uno::Reference< css::frame::XDispatchRecorder > SfxBindings::GetRecorder() const
+const css::uno::Reference< css::frame::XDispatchRecorder >& SfxBindings::GetRecorder() const
 {
     return pImp->xRecorder;
 }
diff --git a/sfx2/source/dialog/dockwin.cxx b/sfx2/source/dialog/dockwin.cxx
index caf0c64b0203..a53ff86e36c2 100644
--- a/sfx2/source/dialog/dockwin.cxx
+++ b/sfx2/source/dialog/dockwin.cxx
@@ -1724,7 +1724,7 @@ void SfxDockingWindow::SetMinOutputSizePixel( const Size& rSize )
 }
 
 /** Set the minimum size which is returned.*/
-Size SfxDockingWindow::GetMinOutputSizePixel() const
+const Size& SfxDockingWindow::GetMinOutputSizePixel() const
 {
     return pImp->aMinSize;
 }
diff --git a/sfx2/source/dialog/filedlghelper.cxx b/sfx2/source/dialog/filedlghelper.cxx
index 9882d0618b50..dd45218bcc46 100644
--- a/sfx2/source/dialog/filedlghelper.cxx
+++ b/sfx2/source/dialog/filedlghelper.cxx
@@ -2537,7 +2537,7 @@ void FileDialogHelper::SetCurrentFilter( const OUString& rFilter )
     mpImp->setFilter( sFilter );
 }
 
-uno::Reference < XFilePicker2 > FileDialogHelper::GetFilePicker() const
+const uno::Reference < XFilePicker2 >& FileDialogHelper::GetFilePicker() const
 {
     return mpImp->mxFileDlg;
 }
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 9bc9d6f6e630..edbdcac3078d 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -542,8 +542,8 @@ public:
     void Put(StyleTree_Impl* pIns, sal_uIntPtr lPos=ULONG_MAX);
     size_t Count();
 
-    OUString getName() { return aName; }
-    OUString getParent() { return aParent; }
+    const OUString& getName() { return aName; }
+    const OUString& getParent() { return aParent; }
     StyleTree_Impl *operator[](size_t idx) const { return pChildren[idx]; }
 };
 
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index c9ecec7634fa..4362ddb64c53 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -2677,7 +2677,7 @@ void SfxMedium::SetFilter( const std::shared_ptr<const SfxFilter>& pFilter )
     pImp->m_pFilter = pFilter;
 }
 
-std::shared_ptr<const SfxFilter> SfxMedium::GetFilter() const
+const std::shared_ptr<const SfxFilter>& SfxMedium::GetFilter() const
 {
     return pImp->m_pFilter;
 }
diff --git a/sfx2/source/doc/doctempl.cxx b/sfx2/source/doc/doctempl.cxx
index 557278cd9029..07a852a298ba 100644
--- a/sfx2/source/doc/doctempl.cxx
+++ b/sfx2/source/doc/doctempl.cxx
@@ -231,9 +231,9 @@ public:
 
     bool            GetTitleFromURL( const OUString& rURL, OUString& aTitle );
     bool            InsertRegion( RegionData_Impl *pData, size_t nPos = size_t(-1) );
-    OUString            GetRootURL() const { return maRootURL; }
+    const OUString& GetRootURL() const { return maRootURL; }
 
-    uno::Reference< XDocumentTemplates >     getDocTemplates() { return mxTemplates; }
+    const uno::Reference< XDocumentTemplates >& getDocTemplates() { return mxTemplates; }
 };
 
 
diff --git a/sfx2/source/doc/doctemplates.cxx b/sfx2/source/doc/doctemplates.cxx
index 175354c12fd6..14b427b8e4d6 100644
--- a/sfx2/source/doc/doctemplates.cxx
+++ b/sfx2/source/doc/doctemplates.cxx
@@ -277,10 +277,10 @@ public:
                                 ~SfxDocTplService_Impl();
 
     bool                        init() { if ( !mbIsInitialized ) init_Impl(); return mbIsInitialized; }
-    Content                     getContent() const { return maRootContent; }
+    const Content&              getContent() const { return maRootContent; }
 
     void                        setLocale( const lang::Locale & rLocale );
-    lang::Locale                      getLocale();
+    lang::Locale                getLocale();
 
     bool                        storeTemplate( const OUString& rGroupName,
                                                const OUString& rTemplateName,
diff --git a/sfx2/source/doc/objcont.cxx b/sfx2/source/doc/objcont.cxx
index e6c0ee950a28..87769d5e551e 100644
--- a/sfx2/source/doc/objcont.cxx
+++ b/sfx2/source/doc/objcont.cxx
@@ -622,7 +622,7 @@ bool SfxObjectShell::SetModifyPasswordHash( sal_uInt32 nHash )
     return false;
 }
 
-uno::Sequence< beans::PropertyValue > SfxObjectShell::GetModifyPasswordInfo() const
+const uno::Sequence< beans::PropertyValue >& SfxObjectShell::GetModifyPasswordInfo() const
 {
     return pImp->m_aModifyPasswordInfo;
 }
diff --git a/sfx2/source/inc/statcach.hxx b/sfx2/source/inc/statcach.hxx
index 51d9e2a48408..c34c0890f5be 100644
--- a/sfx2/source/inc/statcach.hxx
+++ b/sfx2/source/inc/statcach.hxx
@@ -105,7 +105,7 @@ public:
                             { DBG_ASSERT( !pInternalController, "Only one internal controller allowed!" ); pInternalController = pCtrl; }
     void                    ReleaseInternalController() { pInternalController = nullptr; }
     SfxControllerItem*      GetInternalController() const { return pInternalController; }
-    css::uno::Reference < css::frame::XDispatch >
+    const css::uno::Reference < css::frame::XDispatch >&
                             GetInternalDispatch() const
                             { return xMyDispatch; }
     void                    SetInternalDispatch( const css::uno::Reference < css::frame::XDispatch >& rDisp )
diff --git a/sfx2/source/inc/workwin.hxx b/sfx2/source/inc/workwin.hxx
index e4fa1d660c4d..dcc0fd3dd51a 100644
--- a/sfx2/source/inc/workwin.hxx
+++ b/sfx2/source/inc/workwin.hxx
@@ -304,7 +304,7 @@ public:
     bool                    IsVisible_Impl( sal_uInt16 nMode ) const;
     bool                    IsFloating( sal_uInt16 nId );
     void                    SetActiveChild_Impl( vcl::Window *pChild );
-    VclPtr<vcl::Window>     GetActiveChild_Impl() const { return pActiveChild; }
+    const VclPtr<vcl::Window>& GetActiveChild_Impl() const { return pActiveChild; }
 
     // Methods for StatusBar
     void                    ResetStatusBar_Impl();
diff --git a/sfx2/source/view/frame.cxx b/sfx2/source/view/frame.cxx
index 013bd14583cc..6850a4ef0afd 100644
--- a/sfx2/source/view/frame.cxx
+++ b/sfx2/source/view/frame.cxx
@@ -702,7 +702,7 @@ css::uno::Reference< css::frame::XController > SfxFrame::GetController() const
         return css::uno::Reference< css::frame::XController > ();
 }
 
-css::uno::Reference< css::frame::XFrame >  SfxFrame::GetFrameInterface() const
+const css::uno::Reference< css::frame::XFrame >&  SfxFrame::GetFrameInterface() const
 {
     return pImp->xFrame;
 }
diff --git a/sfx2/source/view/ipclient.cxx b/sfx2/source/view/ipclient.cxx
index cd3f783fc9dd..a586a26f3187 100644
--- a/sfx2/source/view/ipclient.cxx
+++ b/sfx2/source/view/ipclient.cxx
@@ -666,7 +666,7 @@ sal_Int64 SfxInPlaceClient::GetObjectMiscStatus() const
 }
 
 
-uno::Reference < embed::XEmbeddedObject > SfxInPlaceClient::GetObject() const
+const uno::Reference < embed::XEmbeddedObject >& SfxInPlaceClient::GetObject() const
 {
     return m_pImp->m_xObject;
 }
@@ -738,7 +738,7 @@ bool SfxInPlaceClient::SetObjArea( const Rectangle& rArea )
 }
 
 
-Rectangle SfxInPlaceClient::GetObjArea() const
+const Rectangle& SfxInPlaceClient::GetObjArea() const
 {
     return m_pImp->m_aObjArea;
 }
diff --git a/sfx2/source/view/viewprn.cxx b/sfx2/source/view/viewprn.cxx
index 448c043c0796..12018db5cb5c 100644
--- a/sfx2/source/view/viewprn.cxx
+++ b/sfx2/source/view/viewprn.cxx
@@ -622,7 +622,7 @@ void SfxViewShell::ExecPrint( const uno::Sequence < beans::PropertyValue >& rPro
     Printer::PrintJob( GetPrinterController(), aJobSetup );
 }
 
-std::shared_ptr< vcl::PrinterController > SfxViewShell::GetPrinterController() const
+const std::shared_ptr< vcl::PrinterController >& SfxViewShell::GetPrinterController() const
 {
     return pImp->m_xPrinterController;
 }