summaryrefslogtreecommitdiff
path: root/sfx2/source/dialog
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2015-08-07 08:14:34 +0200
committerNoel Grandin <noel@peralex.com>2015-08-07 08:14:34 +0200
commit46791546a8aaef40eafc08e6e71b4b0785324564 (patch)
tree149c1b3d002404366ed7a410af8e82f4b51778c3 /sfx2/source/dialog
parent6343754e310a589cb49e2a1da0cd68472571179d (diff)
cppcheck:noExplicitConstructor
Change-Id: I940714e303b905b756ba077eeda6c41746bd421f
Diffstat (limited to 'sfx2/source/dialog')
-rw-r--r--sfx2/source/dialog/filtergrouping.cxx8
-rw-r--r--sfx2/source/dialog/filtergrouping.hxx20
-rw-r--r--sfx2/source/dialog/infobar.cxx2
-rw-r--r--sfx2/source/dialog/splitwin.cxx2
-rw-r--r--sfx2/source/dialog/tabdlg.cxx2
-rw-r--r--sfx2/source/dialog/taskpane.cxx4
-rw-r--r--sfx2/source/dialog/versdlg.cxx4
7 files changed, 20 insertions, 22 deletions
diff --git a/sfx2/source/dialog/filtergrouping.cxx b/sfx2/source/dialog/filtergrouping.cxx
index 236f971c5f69..b0cd3c170467 100644
--- a/sfx2/source/dialog/filtergrouping.cxx
+++ b/sfx2/source/dialog/filtergrouping.cxx
@@ -413,7 +413,7 @@ namespace sfx2
{
OUString& _rToBeExtended;
- CheckAppendSingleWildcard( OUString& _rBase ) : _rToBeExtended( _rBase ) { }
+ explicit CheckAppendSingleWildcard( OUString& _rBase ) : _rToBeExtended( _rBase ) { }
void operator() ( const OUString& _rWC )
{
@@ -452,7 +452,7 @@ namespace sfx2
::std::vector< OUString > aWildCards;
public:
- AppendWildcardToDescriptor( const OUString& _rWildCard );
+ explicit AppendWildcardToDescriptor( const OUString& _rWildCard );
// operate on a single class entry
void operator() ( const FilterGroupEntryReferrer::value_type& _rClassReference )
@@ -533,7 +533,7 @@ namespace sfx2
struct FindGroupEntry : public ::std::unary_function< MapGroupEntry2GroupEntry::value_type, sal_Bool >
{
FilterGroupEntryReferrer::mapped_type aLookingFor;
- FindGroupEntry( FilterGroupEntryReferrer::mapped_type _rLookingFor ) : aLookingFor( _rLookingFor ) { }
+ explicit FindGroupEntry( FilterGroupEntryReferrer::mapped_type _rLookingFor ) : aLookingFor( _rLookingFor ) { }
bool operator() ( const MapGroupEntry2GroupEntry::value_type& _rMapEntry )
{
@@ -556,7 +556,7 @@ namespace sfx2
struct CopyNonEmptyFilter : public ::std::unary_function< FilterDescriptor, void >
{
FilterGroup& rTarget;
- CopyNonEmptyFilter( FilterGroup& _rTarget ) :rTarget( _rTarget ) { }
+ explicit CopyNonEmptyFilter( FilterGroup& _rTarget ) :rTarget( _rTarget ) { }
void operator() ( const FilterDescriptor& _rFilter )
{
diff --git a/sfx2/source/dialog/filtergrouping.hxx b/sfx2/source/dialog/filtergrouping.hxx
index 12aab3ac37fb..ea5317302374 100644
--- a/sfx2/source/dialog/filtergrouping.hxx
+++ b/sfx2/source/dialog/filtergrouping.hxx
@@ -31,19 +31,17 @@ namespace sfx2
class TSortedFilterList
{
- private:
+ private:
+ ::std::vector< OUString > m_lFilters;
+ sal_Int32 m_nIterator;
- ::std::vector< OUString > m_lFilters;
- sal_Int32 m_nIterator;
+ public:
+ explicit TSortedFilterList(const ::com::sun::star::uno::Reference< ::com::sun::star::container::XEnumeration >& xFilterList);
+ const SfxFilter* First();
+ const SfxFilter* Next();
- public:
-
- TSortedFilterList(const ::com::sun::star::uno::Reference< ::com::sun::star::container::XEnumeration >& xFilterList);
- const SfxFilter* First();
- const SfxFilter* Next();
-
- private:
- const SfxFilter* impl_getFilter(sal_Int32 nIndex);
+ private:
+ const SfxFilter* impl_getFilter(sal_Int32 nIndex);
};
diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx
index e6b63c83cd33..f65946b58d67 100644
--- a/sfx2/source/dialog/infobar.cxx
+++ b/sfx2/source/dialog/infobar.cxx
@@ -55,7 +55,7 @@ void lclDetermineLightDarkColor(BColor& rLightColor, BColor& rDarkColor)
class SfxCloseButton : public PushButton
{
public:
- SfxCloseButton(vcl::Window* pParent) : PushButton(pParent, 0)
+ explicit SfxCloseButton(vcl::Window* pParent) : PushButton(pParent, 0)
{}
virtual ~SfxCloseButton() {}
diff --git a/sfx2/source/dialog/splitwin.cxx b/sfx2/source/dialog/splitwin.cxx
index 3b2ea7890b0b..69ac91b41892 100644
--- a/sfx2/source/dialog/splitwin.cxx
+++ b/sfx2/source/dialog/splitwin.cxx
@@ -97,7 +97,7 @@ friend class SfxSplitWindow;
sal_uInt16 nState;
public:
- SfxEmptySplitWin_Impl( SfxSplitWindow *pParent )
+ explicit SfxEmptySplitWin_Impl( SfxSplitWindow *pParent )
: SplitWindow( pParent->GetParent(), WinBits( WB_BORDER | WB_3DLOOK ) )
, pOwner( pParent )
, bFadeIn( false )
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 3cf586996528..9435f9a0085d 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -117,7 +117,7 @@ struct TabDlg_Impl
bHideResetBtn : 1;
SfxTabDlgData_Impl aData;
- TabDlg_Impl( sal_uInt8 nCnt ) :
+ explicit TabDlg_Impl( sal_uInt8 nCnt ) :
bModified ( false ),
bModal ( true ),
diff --git a/sfx2/source/dialog/taskpane.cxx b/sfx2/source/dialog/taskpane.cxx
index e8a17b9cae59..cc9d5cbe00d1 100644
--- a/sfx2/source/dialog/taskpane.cxx
+++ b/sfx2/source/dialog/taskpane.cxx
@@ -283,7 +283,7 @@ namespace sfx2
{
}
- CustomPanelUIElement( const Reference< XUIElement >& i_rUIElement )
+ explicit CustomPanelUIElement( const Reference< XUIElement >& i_rUIElement )
:m_xUIElement( i_rUIElement )
,m_xToolPanel( i_rUIElement->getRealInterface(), UNO_QUERY_THROW )
,m_xPanelWindow( m_xToolPanel->getWindow(), UNO_SET_THROW )
@@ -807,7 +807,7 @@ namespace sfx2
::svt::PToolPanel pPanel;
bool bHidden;
- PanelDescriptor( const ::svt::PToolPanel& i_rPanel )
+ explicit PanelDescriptor( const ::svt::PToolPanel& i_rPanel )
:pPanel( i_rPanel )
,bHidden( false )
{
diff --git a/sfx2/source/dialog/versdlg.cxx b/sfx2/source/dialog/versdlg.cxx
index d04ab9546777..3de3cfdfa232 100644
--- a/sfx2/source/dialog/versdlg.cxx
+++ b/sfx2/source/dialog/versdlg.cxx
@@ -69,8 +69,8 @@ class SfxVersionTableDtor: private boost::noncopyable
private:
std::vector< SfxVersionInfo* > aTableList;
public:
- SfxVersionTableDtor( const uno::Sequence < util::RevisionTag >& rInfo );
- SfxVersionTableDtor( const uno::Sequence < document::CmisVersion > & rInfo );
+ explicit SfxVersionTableDtor( const uno::Sequence < util::RevisionTag >& rInfo );
+ explicit SfxVersionTableDtor( const uno::Sequence < document::CmisVersion > & rInfo );
~SfxVersionTableDtor()
{ DelDtor(); }