Fix StringAdd::isCompileTimeConstant

...to find StringLiteral on the RHS of +=.  Which revealed that the
VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that

  s += side_effect();
  s += "literal";
  s += side_effect();

only gets combined to

  s += side_effect() + "literal";
  s += side_effect();

and not all the way to

  s += side_effect() + "literal" + side_effect();

Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4
Reviewed-on: https://gerrit.libreoffice.org/81804
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 1 insertions, 2 deletions

diff --git a/sdext/source/minimizer/optimizerdialog.cxx b/sdext/source/minimizer/optimizerdialog.cxx
index 503199400ec2..faf95ef021b8 100644
--- a/sdext/source/minimizer/optimizerdialog.cxx
+++ b/sdext/source/minimizer/optimizerdialog.cxx
@@ -526,8 +526,7 @@ void ActionListener::actionPerformed( const ActionEvent& rEvent )
 
                 if (!aName.isEmpty())
                 {
-                    aName += " ";
-                    aName += mrOptimizerDialog.getString(STR_FILENAME_SUFFIX);
+                    aName += " " + mrOptimizerDialog.getString(STR_FILENAME_SUFFIX);
                     aFileOpenDialog.setDefaultName(aName);
                 }