diff options
| author | Noel Grandin <noel@peralex.com> | 2021-04-30 13:00:35 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-04-30 16:03:35 +0200 |
| commit | 857caa5fc69b92e781457a1b67a89aa051c2d70f (patch) | |
| tree | 7437d7f6345f9dea81f4203517549c48fa971eae /sd | |
| parent | b9097800f4f997de2325bc9e588e6caea7a563c7 (diff) | |
tdf#79049 speed up OOXML workbook load
we spend a lot of time in ScAttrArray::GetLastVisibleAttr
which appears to be very expensive for this worksheet.
This is re-computed every time we enter SfxBaseModel::getArgs
Reduce the recomputation by introducing a new method which
only retrieves specific SfxBaseModel arguments.
This takes the load time from 5m9 to 1m9 for me.
Change-Id: I605fae0faa94760c7d6993877c9559ea5dc813cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114905
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/qa/unit/misc-tests.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sd/qa/unit/misc-tests.cxx b/sd/qa/unit/misc-tests.cxx index 6329ca3a602c..1ba7d21a2d18 100644 --- a/sd/qa/unit/misc-tests.cxx +++ b/sd/qa/unit/misc-tests.cxx @@ -157,7 +157,7 @@ sd::DrawDocShellRef SdMiscTest::Load(const OUString& rURL, sal_Int32 nFormat) sd::DrawDocShellRef xDocSh = loadURL(rURL, nFormat); CPPUNIT_ASSERT_MESSAGE("Failed to load file.", xDocSh.is()); - uno::Reference< frame::XModel2 > xModel2(xDocSh->GetModel(), uno::UNO_QUERY); + uno::Reference< frame::XModel2 > xModel2 = xDocSh->GetModel(); CPPUNIT_ASSERT(xModel2.is()); uno::Reference< frame::XController2 > xController = xModel2->createDefaultViewController(xTargetFrame); |