summaryrefslogtreecommitdiff
path: root/sd
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2020-08-06 18:50:08 +0300
committerXisco Fauli <xiscofauli@libreoffice.org>2020-08-10 11:28:13 +0200
commit82ab191a074141aafa7567fc3c3cad9bc7ea0b24 (patch)
treeb4bf8db95cfb8fbd35346663ede48d12237d93f7 /sd
parent6f1cbda681545fa3667b107830ebea804b08c98c (diff)
tdf#135470: Fix checks
The check should prevent error in case when the variable has wrong type. IsObject returns false e.g. for arrays, which are valid iterables. So proper check is using GetFullType, which will give SbxOBJECT for any variable for which GetObject does not set error. "Next" should also generate an error for uninitialized loops. Regression after 5760c94b8847164f9a7a181f031c7c86643944af Change-Id: Ib58e1cc76ef63aa1ff8a86c9d5dc956e4780fb49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100258 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit e67ffd5a62c8c27697da594a0fea2362317f221f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100225 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'sd')
0 files changed, 0 insertions, 0 deletions