diff options
| author | Xisco Fauli <xiscofauli@libreoffice.org> | 2021-01-29 12:42:09 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2021-01-30 20:17:01 +0100 |
| commit | d71f7138d664b62604a4e4e7fc6e1b1073df1899 (patch) | |
| tree | 1dfb2cd35a603959876215bcacb1783813c59634 /sd | |
| parent | 58ba5ebb0bb96bb9ff1482c76d9875ed8138161c (diff) | |
tdf#139996: do not crash if no slide is selected
when no slide is selected, SyncPageSelectionToDocument(xSelection).first
returns SAL_MAX_UINT16, which is greater than 0
Change-Id: I20225dc3c89a34358949f991d1548e11803c3131
Change-Id: I787d46ff97a6a1401c5bc4ffc136aefc4bbeea29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110142
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx index 028d8f2a4266..2cfbddcaa998 100644 --- a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx +++ b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx @@ -763,6 +763,11 @@ void SlideSorterViewShell::ExecMovePageUp (SfxRequest& /*rReq*/) // SdDrawDocument MovePages is based on SdPage IsSelected, so // transfer the SlideSorter selection to SdPages sal_uInt16 firstSelectedPageNo = SyncPageSelectionToDocument(xSelection).first; + + // In case no slide is selected + if (firstSelectedPageNo == SAL_MAX_UINT16) + return; + // Now compute human page number from internal page number firstSelectedPageNo = (firstSelectedPageNo - 1) / 2; |