diff options
| author | Justin Luth <justin.luth@collabora.com> | 2018-06-02 14:57:47 +0300 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2018-06-27 06:42:41 +0200 |
| commit | 9e5a9f8f25f7e836da5f540709643e46c8f95641 (patch) | |
| tree | ddbd9034120239bf83b269c29b3eeb6a0b955de9 /sd | |
| parent | 7cf1553c630037ce0fb765f0ec3d4253b77d7934 (diff) | |
tdf#104199 sd: nofill borders shouldn't be visible.
regression from export bugfix tdf#90190.
rLineProperties.maLineFill was set, but that value was
never used, leaving aBorderLine with the default value.
Setting borderline to COL_AUTO lets it merge in with background
colors while still taking up the space defined by the border width.
The existing unit test says "it is likely you will break
this if fixing background issues, so feel free to adjust the
test values." Indeed, this patch removes an unwanted black border,
so utilizing that test as a proof.
Change-Id: I0725a3d5874a509a4464c586d60c77cde2b49fcb
Reviewed-on: https://gerrit.libreoffice.org/55205
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
(cherry picked from commit 76505bbd862b17b9b02a2d6e68bac308890dec70)
Reviewed-on: https://gerrit.libreoffice.org/55777
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 552b3fa548e19436af24f4b413e34b2f15100718)
Reviewed-on: https://gerrit.libreoffice.org/55883
(cherry picked from commit 05021abd97316fe3d188cd9f15c44db2170927d7)
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/qa/unit/import-tests.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx index 95fb428cfd1b..d8e2245a02b5 100644 --- a/sd/qa/unit/import-tests.cxx +++ b/sd/qa/unit/import-tests.cxx @@ -900,7 +900,7 @@ void SdImportTest::testBnc480256() xCell.set(xTable->getCellByPosition(1, 0), uno::UNO_QUERY_THROW); xCell->getPropertyValue("BottomBorder") >>= aBorderLine; - CPPUNIT_ASSERT_EQUAL(util::Color(0), aBorderLine.Color); + CPPUNIT_ASSERT_EQUAL(util::Color(COL_AUTO), aBorderLine.Color); xDocShRef->DoClose(); } |