summaryrefslogtreecommitdiff
path: root/sd
diff options
context:
space:
mode:
authorLuboš Luňák <l.lunak@collabora.com>2021-07-22 22:07:42 +0200
committerLuboš Luňák <l.lunak@collabora.com>2021-09-08 10:33:56 +0200
commitc7451989984cc96e8d195dbe026d803bc462c1f5 (patch)
tree5ef905bd0e3f719aa2f123269a065e385ccdae84 /sd
parent092c5f5ae9e8e1975ab1595f782fe10a2739a4d7 (diff)
avoid painting to windows in LOK mode
There are no actual toplevel windows in that case, and tiled rendering is used to paint whenever any painting is needed. The painting is already made useless by using (1,1)-sized Cairo surfaces for windows (SvpSalFrame::SetPosSize() calling SvpSalFrame::GetSurfaceFrameSize()), this should avoid it altogether. It is possible this commit causes regressions if some code relies on Paint() getting called at specific times (such as 2f961c7a811bdff66 doing relayout there, causing geometry changes), but those should be fixed. Change-Id: Ie4be16301fdddb7c1b0350e6458178efca88aa4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119270 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'sd')
-rw-r--r--sd/qa/unit/tiledrendering/LOKitSearchTest.cxx4
1 files changed, 2 insertions, 2 deletions
diff --git a/sd/qa/unit/tiledrendering/LOKitSearchTest.cxx b/sd/qa/unit/tiledrendering/LOKitSearchTest.cxx
index beba53b67078..4bb6ca2d9a5f 100644
--- a/sd/qa/unit/tiledrendering/LOKitSearchTest.cxx
+++ b/sd/qa/unit/tiledrendering/LOKitSearchTest.cxx
@@ -244,8 +244,8 @@ void LOKitSearchTest::testSearchAllSelections()
lcl_search("third", /*bFindAll=*/true);
// Make sure this is found on the 3rd slide.
CPPUNIT_ASSERT_EQUAL(static_cast<sal_Int32>(2), mpCallbackRecorder->m_nPart);
-
- CPPUNIT_ASSERT_EQUAL(static_cast<std::size_t>(1), mpCallbackRecorder->m_aSelection.size());
+ // This was 1: only the first match was highlighted.
+ CPPUNIT_ASSERT_EQUAL(static_cast<std::size_t>(2), mpCallbackRecorder->m_aSelection.size());
}
void LOKitSearchTest::testSearchAllNotifications()