summaryrefslogtreecommitdiff
path: root/sd/source
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2014-05-13 12:26:42 +0200
committerStephan Bergmann <sbergman@redhat.com>2014-05-13 12:26:42 +0200
commit229e85acd222a4ae9647c7a970269c87cb875b40 (patch)
treedf95339e3072a8a54b322655bab1619f1d436560 /sd/source
parentd0787149cf25377bad97ab503f81a5c0793bbad7 (diff)
elated fdo#60338: #error on umask(3) calls in currently unused code
(as dnssd_clientstub.c is only used on Windows), should we ever want to use it. Change-Id: I5d9082ae69c505e4d60bbe8e60fdeaaf963a4614
Diffstat (limited to 'sd/source')
-rw-r--r--sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c b/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c
index 1c4e08463900..0aa0717720fd 100644
--- a/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c
+++ b/sd/source/ui/remotecontrol/mDNSResponder/dnssd_clientstub.c
@@ -621,6 +621,7 @@ static DNSServiceErrorType deliver_request(ipc_msg_hdr *hdr, DNSServiceOp *sdr)
caddr.sun_len = sizeof(struct sockaddr_un);
#endif
strcpy(caddr.sun_path, data);
+#error "the below umask(3) calls are bad in a MT program (cf. fdo#60338):"
mask = umask(0);
bindresult = bind(listenfd, (struct sockaddr *)&caddr, sizeof(caddr));
umask(mask);