double-checked locking is not thread-safe in Java

found by PMD

Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1

1 files changed, 3 insertions, 7 deletions

diff --git a/scripting/java/org/openoffice/idesupport/zip/ParcelZipper.java b/scripting/java/org/openoffice/idesupport/zip/ParcelZipper.java
index 45cdb185f313..e1e12fa56d83 100644
--- a/scripting/java/org/openoffice/idesupport/zip/ParcelZipper.java
+++ b/scripting/java/org/openoffice/idesupport/zip/ParcelZipper.java
@@ -39,13 +39,9 @@ public class ParcelZipper
     private ParcelZipper() {
     }
 
-    public static ParcelZipper getParcelZipper() {
-        if (zipper == null) {
-            synchronized(ParcelZipper.class) {
-                if (zipper == null)
-                    zipper = new ParcelZipper();
-            }
-        }
+    public static synchronized ParcelZipper getParcelZipper() {
+        if (zipper == null)
+            zipper = new ParcelZipper();
         return zipper;
     }