diff options
| author | Hossein <hossein@libreoffice.org> | 2021-11-11 00:00:38 +0100 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-11-14 08:14:15 +0100 |
| commit | 35c85effecb5a615a361c1b7d92d08447bc83423 (patch) | |
| tree | 360d042d2499acdc2e2b7fb3017f3d2db0829b92 /scaddins | |
| parent | 4d4278b1403d38b34ff80ca2a92164f40abd9c36 (diff) | |
Use M_PI instead of defined value; use rad2deg()
* Replace defined values of PI with M_PI defined in <cmath>
* Use M_PI_2 instead of PI / 2.0
* Instances could be found with:
git grep 3.14 *.cxx *.hxx|grep define
* One instance is ignored:
sc/source/core/opencl/opinlinefun_statistical.cxx
* Replace *(180 / PI) with basegfx::rad2deg()
* Replace 2*PI/360 with basegfx::deg2rad()
* Use atan2 instead of atan where it was more appropriate
+ atan2() handles all 4 quadrants
+ Extra conditions for different quadrants are removed
Change-Id: I083ee2e1427cd36ba0b8c38e4fe5f782d6486075
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124229
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'scaddins')
| -rw-r--r-- | scaddins/source/analysis/analysis.cxx | 2 | ||||
| -rw-r--r-- | scaddins/source/analysis/analysishelper.hxx | 6 |
2 files changed, 2 insertions, 6 deletions
diff --git a/scaddins/source/analysis/analysis.cxx b/scaddins/source/analysis/analysis.cxx index dca1c370d994..9ad63bc15efa 100644 --- a/scaddins/source/analysis/analysis.cxx +++ b/scaddins/source/analysis/analysis.cxx @@ -561,7 +561,7 @@ double SAL_CALL AnalysisAddIn::getMround( double fNum, double fMult ) double SAL_CALL AnalysisAddIn::getSqrtpi( double fNum ) { - double fRet = sqrt( fNum * PI ); + double fRet = sqrt( fNum * M_PI ); RETURN_FINITE( fRet ); } diff --git a/scaddins/source/analysis/analysishelper.hxx b/scaddins/source/analysis/analysishelper.hxx index 7e0610493929..093d939301eb 100644 --- a/scaddins/source/analysis/analysishelper.hxx +++ b/scaddins/source/analysis/analysishelper.hxx @@ -22,7 +22,7 @@ #include <com/sun/star/uno/Reference.hxx> #include <unotools/resmgr.hxx> -#include <math.h> +#include <cmath> #include <memory> #include <vector> @@ -35,10 +35,6 @@ namespace sca::analysis { class ScaAnyConverter; - -#define PI 3.1415926535897932 - - inline bool IsLeapYear( sal_uInt16 nYear ); #ifdef DISABLE_DYNLOADING |