diff options
| author | Eike Rathke <erack@redhat.com> | 2019-01-07 18:37:56 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2019-01-17 10:23:49 +0100 |
| commit | cb40558531c35b89510f0276bc78d9db4a76a9f3 (patch) | |
| tree | 3790a4b4ae452a4f5beb069ee75c6eb55635304e /sc | |
| parent | 33cbf95d65c876838507a7084ef0f65e00f93928 (diff) | |
Resolves: tdf#122301 FREQUENCY() ReferenceOrForceArray, ForceArrayReturn
This is a combination of 2 commits.
Resolves: tdf#122301 ReferenceOrForceArray for FREQUENCY() parameters
It's yet unclear whether
ECMA-376-1:2016 OOXML 18.17.7.127 FREQUENCY
"A call to FREQUENCY shall be an array formula."
indicates that the entire formula expression should be in array
mode as well, see
https://bugs.documentfoundation.org/show_bug.cgi?id=122301#c8
If so, that will need a follow-up change.
Reviewed-on: https://gerrit.libreoffice.org/65940
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
(cherry picked from commit a6572f5f014ed159e340ed31b6e5a08527c09088)
Related: tdf#122301 FREQUENCY() with ForceArrayReturn on caller
FREQUENCY() forces its direct caller into array mode, but only for
the immediate subexpression and not for further operators of the
same parameter.
This weird Excel behaviour is stated in
ECMA-376-1:2016 OOXML 18.17.7.127 FREQUENCY
"A call to FREQUENCY shall be an array formula."
somewhat unclear what it actually applies to, but it turned out
that "a call" is indeed *only* THE direct call, see
https://bugs.documentfoundation.org/show_bug.cgi?id=122301#c19
Reviewed-on: https://gerrit.libreoffice.org/66407
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
(cherry picked from commit d0ded163d8e93dc5b10d7a7c9bdab1d0a6a50bac)
145d8fe26d75d5af25b987e190bf35f2d2c03ec6
Change-Id: Ic302d25631fb870b46989b922c95912ab5d123df
Reviewed-on: https://gerrit.libreoffice.org/66487
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/core/tool/parclass.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/source/core/tool/parclass.cxx b/sc/source/core/tool/parclass.cxx index 46179fe552f8..ce6c9094cc71 100644 --- a/sc/source/core/tool/parclass.cxx +++ b/sc/source/core/tool/parclass.cxx @@ -146,7 +146,7 @@ const ScParameterClassification::RawData ScParameterClassification::pRawData[] = { ocForecast_ETS_STA, {{ ForceArray, ForceArray, ForceArray, Value, Value, Value }, 0, Value }}, { ocForecast_ETS_STM, {{ ForceArray, ForceArray, ForceArray, Value, Value, Value }, 0, Value }}, { ocFormula, {{ Reference }, 0, Value }}, - { ocFrequency, {{ Reference, Reference }, 0, Value }}, + { ocFrequency, {{ ReferenceOrForceArray, ReferenceOrForceArray }, 0, ForceArrayReturn }}, { ocGCD, {{ Reference }, 1, Value }}, { ocGeoMean, {{ Reference }, 1, Value }}, { ocGreater, {{ Array, Array }, 0, Value }}, |