diff options
| author | Eike Rathke <erack@redhat.com> | 2019-02-06 14:53:26 +0100 |
|---|---|---|
| committer | Kohei Yoshida <libreoffice@kohei.us> | 2019-02-09 01:10:10 +0100 |
| commit | 650f3ee43c22a00c15799d31995b22fc8e0742c9 (patch) | |
| tree | db4615189ebb3a9426fb6c1f76584f1aa65ee7e2 /sc | |
| parent | 106e7acab6e31e1e0cee40716335f2b758d6186b (diff) | |
Resolves: tdf#121002 UpdateRefOnNonCopy::mbUpdated=true if references change
... somewhere in a previous shared formula group, so for the new groups
after split the column is added to sc::RefUpdateContext::maRegroupCols
in ScColumn::UpdateReference() to setup new listeners later, and true
returned there, which also results in ScTable::SetStreamValid(false) at
the end, which in this constellation wasn't the case.
It may have been a reason that some documents have individual
unrecalculated results stored (i.e. values moved within ranges that a
shared formula group pointed to) that can be corrected by recalculating
after load.
Said to be a regression from
commit 2f6a06856ad8df0c11a112d1e457b408e9a7af1d
CommitDate: Fri Jun 5 16:22:38 2015 +0200
tdf#90694 reset group area listeners when splitting group
but that only uncovered this misbehaviour.
Change-Id: I6b04b71898c3f1774452dd19790c208f3167d8eb
Reviewed-on: https://gerrit.libreoffice.org/67461
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
(cherry picked from commit cdfa8b27f28328612b6734533981c1b363ced0a0)
Reviewed-on: https://gerrit.libreoffice.org/67465
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/core/data/column.cxx | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index bfd11e038bf0..a7119c52dc64 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -2262,6 +2262,8 @@ class UpdateRefOnNonCopy p->SetDirty(); } + mbUpdated = true; + // Move from clipboard is Cut&Paste, then do not copy the original // positions' formula cells to the Undo document. if (!mbClipboardSource || !bCellMoved) |