diff options
| author | Dennis Francis <dennis.francis@collabora.com> | 2019-04-04 14:07:11 +0530 |
|---|---|---|
| committer | Dennis Francis <dennis.francis@collabora.com> | 2019-04-06 16:05:30 +0200 |
| commit | 559dadd0d6eaa61dab7e0bc2a510b87b7109be22 (patch) | |
| tree | 5ca85a5ee3327170acdfe714dc5a4e3a0f88da3b /sc | |
| parent | e59e4c41e0fd9beaa03a60def58feefdef1e0bb6 (diff) | |
tdf#124326 : ScUndoDragDrop : don't do update references...
on undo, as all affected formula-cells are preserved in original
form in the undo document. This is ensured by the drag-drop
move-block code (ScDocFunc::MoveBlock) which in-turn calls
ScDocument::UpdateReference, which records all original
formula-cells to the undo-document.
Anyway the sc::RefMovedHint object created in ScUndoDragDrop::Undo
is wrong, as it operates on original data-range(aCxt.maRange = aSrcRange)
which is interpreted as "old data-range" in the context of undo-move
operation.
Change-Id: Ic48cc3fa51fdb17e9338f65ac95b8e8d30c2c92c
Reviewed-on: https://gerrit.libreoffice.org/70315
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 9079da7f62febaf4cef0b77320c31b4e8bb6b5a5)
Reviewed-on: https://gerrit.libreoffice.org/70327
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/ui/undo/undoblk.cxx | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx index 71e29b1ee357..6e0f254d34bb 100644 --- a/sc/source/ui/undo/undoblk.cxx +++ b/sc/source/ui/undo/undoblk.cxx @@ -1355,10 +1355,6 @@ void ScUndoDragDrop::Undo() pName->UpdateReference(aCxt, nTab); } - // Notify all listeners of the destination range, and have them update their references. - sc::RefMovedHint aHint(aDestRange, ScAddress(nColDelta, nRowDelta, nTabDelta), aCxt); - rDoc.BroadcastRefMoved(aHint); - ScValidationDataList* pValidList = rDoc.GetValidationList(); if (pValidList) { |