diff options
| author | Kohei Yoshida <kohei.yoshida@gmail.com> | 2013-01-11 12:51:13 -0500 |
|---|---|---|
| committer | Markus Mohrhard <markus.mohrhard@googlemail.com> | 2013-01-13 07:19:47 +0000 |
| commit | 6da661ab5e705973f4d10d6b4755875f6da3b3f5 (patch) | |
| tree | 61ee00381db801921fb1fb832c29f42307b896a1 /sc | |
| parent | b0e35a54631d0e514860ae53cd7b408bb3d2e144 (diff) | |
Let's not return here to prevent memory leak.
There are several heap objects that are deleted at the end of the
method. Returning prematurely would leak those objects.
Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593
Reviewed-on: https://gerrit.libreoffice.org/1653
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/ui/docshell/dbdocfun.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx index 3b1db2f05e7a..9f4d58d30f6a 100644 --- a/sc/source/ui/docshell/dbdocfun.cxx +++ b/sc/source/ui/docshell/dbdocfun.cxx @@ -1319,8 +1319,7 @@ bool ScDBDocFunc::DataPilotUpdate( ScDPObject* pOldObj, const ScDPObject* pNewOb if ( pDestObj ) { pDestObj->ReloadGroupTableData(); - if (!pDestObj->SyncAllDimensionMembers()) - return false; + pDestObj->SyncAllDimensionMembers(); pDestObj->InvalidateData(); // before getting the new output area // make sure the table has a name (not set by dialog) |