Revert "loplugin:constfields in sc"

This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675.

Now that we know that making fields has negative side effects
like disabling assignment operator generation.

Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 8 insertions, 8 deletions

diff --git a/sc/source/ui/dataprovider/htmldataprovider.cxx b/sc/source/ui/dataprovider/htmldataprovider.cxx
index 39a30c8754b9..fbd1daaa3271 100644
--- a/sc/source/ui/dataprovider/htmldataprovider.cxx
+++ b/sc/source/ui/dataprovider/htmldataprovider.cxx
@@ -26,10 +26,10 @@ namespace sc {
 class HTMLFetchThread : public salhelper::Thread
 {
     ScDocument& mrDocument;
-    OUString const maURL;
-    OUString const maID;
+    OUString maURL;
+    OUString maID;
     const std::vector<std::shared_ptr<sc::DataTransformation>> maDataTransformations;
-    std::function<void()> const maImportFinishedHdl;
+    std::function<void()> maImportFinishedHdl;
 
     void handleTable(xmlNodePtr pTable);
     void handleRow(xmlNodePtr pRow, SCROW nRow);
diff --git a/sc/source/ui/dataprovider/htmldataprovider.hxx b/sc/source/ui/dataprovider/htmldataprovider.hxx
index b3ac0c488c4e..6a74eb3d9801 100644
--- a/sc/source/ui/dataprovider/htmldataprovider.hxx
+++ b/sc/source/ui/dataprovider/htmldataprovider.hxx
@@ -20,7 +20,7 @@ class HTMLDataProvider : public DataProvider
 {
 private:
 
-    ScDocument* const mpDocument;
+    ScDocument* mpDocument;
     rtl::Reference<HTMLFetchThread> mxHTMLFetchThread;
 
     ScDocumentUniquePtr mpDoc;
diff --git a/sc/source/ui/dataprovider/xmldataprovider.cxx b/sc/source/ui/dataprovider/xmldataprovider.cxx
index da0f9bd28535..d540f81c5dc9 100644
--- a/sc/source/ui/dataprovider/xmldataprovider.cxx
+++ b/sc/source/ui/dataprovider/xmldataprovider.cxx
@@ -24,12 +24,12 @@ namespace sc
 class XMLFetchThread : public salhelper::Thread
 {
     ScDocument& mrDocument;
-    OUString const maURL;
-    OUString const maID;
+    OUString maURL;
+    OUString maID;
     ScOrcusImportXMLParam maParam;
     std::unique_ptr<ScOrcusXMLContext> mpXMLContext;
     const std::vector<std::shared_ptr<sc::DataTransformation>> maDataTransformations;
-    std::function<void()> const maImportFinishedHdl;
+    std::function<void()> maImportFinishedHdl;
 
 public:
     XMLFetchThread(ScDocument& rDoc, const OUString&, const ScOrcusImportXMLParam& rParam,
diff --git a/sc/source/ui/dataprovider/xmldataprovider.hxx b/sc/source/ui/dataprovider/xmldataprovider.hxx
index 87b30a1ecea9..46bf69571494 100644
--- a/sc/source/ui/dataprovider/xmldataprovider.hxx
+++ b/sc/source/ui/dataprovider/xmldataprovider.hxx
@@ -19,7 +19,7 @@ class XMLFetchThread;
 class XMLDataProvider : public DataProvider
 {
 private:
-    ScDocument* const mpDocument;
+    ScDocument* mpDocument;
     rtl::Reference<XMLFetchThread> mxXMLFetchThread;
     ScDocumentUniquePtr mpDoc;