Optimize ScColumn::MixData() to remove several bottlenecks.

The use case that would previously make Calc freeze.

1) type in "test" in A1.
2) Select A1:A2 and Ctrl-C to copy to the clipboard.
3) select the whole column B.
4) paste special, select "Add" operation and click OK to paste.

With this change, the above scenario no longer freezes Calc.

Change-Id: I98b1f1e6c25b853aa884e7598c04b1457fab4636

1 files changed, 1 insertions, 8 deletions

diff --git a/sc/source/core/data/documentimport.cxx b/sc/source/core/data/documentimport.cxx
index ced09363ccc4..ec5b1c498d24 100644
--- a/sc/source/core/data/documentimport.cxx
+++ b/sc/source/core/data/documentimport.cxx
@@ -118,14 +118,7 @@ void ScDocumentImport::finalize()
         for (; pCol != pColEnd; ++pCol)
         {
             ScColumn& rCol = *pCol;
-            if (rCol.maItems.empty())
-                // Column has no cells. Skip it.
-                continue;
-
-            sc::CellTextAttrStoreType::iterator itCTAPos = rCol.maCellTextAttrs.begin();
-            std::vector<ColEntry>::iterator itCell = rCol.maItems.begin(), itCellEnd = rCol.maItems.end();
-            for (; itCell != itCellEnd; ++itCell)
-                itCTAPos = rCol.maCellTextAttrs.set<sc::CellTextAttr>(itCTAPos, itCell->nRow, sc::CellTextAttr());
+            rCol.ResetCellTextAttrs();
         }
     }
 }