diff options
| author | Noel Grandin <noel@peralex.com> | 2014-05-14 09:58:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2014-05-14 08:10:22 +0000 |
| commit | 248145f99e95cc30bb6231a8e5ea4e294f147040 (patch) | |
| tree | c3b5c1e226cc631cde530f2cfb7df2d46f00b8c9 /sax | |
| parent | 671eb12dee290607ed66f3b325f28e7bd4695cba (diff) | |
Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'sax')
| -rw-r--r-- | sax/source/tools/fastserializer.cxx | 2 | ||||
| -rw-r--r-- | sax/source/tools/fastserializer.hxx | 4 | ||||
| -rw-r--r-- | sax/source/tools/fshelper.cxx | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/sax/source/tools/fastserializer.cxx b/sax/source/tools/fastserializer.cxx index 4005a252b49f..1eea16e99bf7 100644 --- a/sax/source/tools/fastserializer.cxx +++ b/sax/source/tools/fastserializer.cxx @@ -272,7 +272,7 @@ namespace sax_fastparser { } } - void FastSaxSerializer::mark( Int32Sequence aOrder ) + void FastSaxSerializer::mark( const Int32Sequence& aOrder ) { if ( aOrder.hasElements() ) { diff --git a/sax/source/tools/fastserializer.hxx b/sax/source/tools/fastserializer.hxx index 89e9da8895db..4544fc3515e3 100644 --- a/sax/source/tools/fastserializer.hxx +++ b/sax/source/tools/fastserializer.hxx @@ -128,7 +128,7 @@ public: mergeTopMarks( true ), mergeTopMarks(), /r, /p and you are done. */ - void mark( Int32Sequence aOrder = Int32Sequence() ); + void mark( const Int32Sequence& aOrder = Int32Sequence() ); /** Merge 2 topmost marks. @@ -183,7 +183,7 @@ private: Int32Sequence maOrder; public: - ForSort( Int32Sequence aOrder ) : + ForSort( const Int32Sequence& aOrder ) : ForMerge(), maData(), mnCurrentElement( 0 ), diff --git a/sax/source/tools/fshelper.cxx b/sax/source/tools/fshelper.cxx index 45f8d23c9543..c19bd4b8c359 100644 --- a/sax/source/tools/fshelper.cxx +++ b/sax/source/tools/fshelper.cxx @@ -151,7 +151,7 @@ FastSerializerHelper* FastSerializerHelper::writeId(sal_Int32 tokenId) return mpSerializer->getOutputStream(); } -void FastSerializerHelper::mark( Sequence< sal_Int32 > aOrder ) +void FastSerializerHelper::mark( const Sequence< sal_Int32 >& aOrder ) { mpSerializer->mark( aOrder ); } |