diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-08-09 11:38:47 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2022-08-09 16:49:54 +0200 |
| commit | 2d074a0b98c9150d2f15056ea86dcc9305f43ab3 (patch) | |
| tree | 709a998942f54ad3e0fa14c181ea859604fc5644 /sal | |
| parent | a22746eb8e2e64ce31f304b601c4ea0ecf95da1a (diff) | |
crashreporting: frequent crash seen in PackedFile::flush
at:
if (osl::File::E_None == osl::FileBase::createTempFile(nullptr, &aHandle, &aTempURL))
{
....
if (osl_File_E_None == osl_writeFile(aHandle, ...
createTempFile is returning osl::File::E_None but presumably we are
missing setting a possible error state here
https: //crashreport.libreoffice.org/stats/crash_details/ea4b4050-dd0f-42b1-b30f-b67612806371
Change-Id: Ib2d0c3c91e40fe985571e79822b91f2faf401471
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138013
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
Diffstat (limited to 'sal')
| -rw-r--r-- | sal/osl/w32/tempfile.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sal/osl/w32/tempfile.cxx b/sal/osl/w32/tempfile.cxx index a4c272e57768..5d5d758ce244 100644 --- a/sal/osl/w32/tempfile.cxx +++ b/sal/osl/w32/tempfile.cxx @@ -192,7 +192,7 @@ oslFileError SAL_CALL osl_createTempFile( if (tmp_name) { - osl_createTempFile_impl_( + osl_error = osl_createTempFile_impl_( base_directory, tmp_name, b_delete_on_close, |