diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2022-05-30 09:33:49 +0200 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2022-06-01 12:30:35 +0200 |
| commit | da0506bc1f14438952e17b78b23813dab0a7901d (patch) | |
| tree | c32eca12e3842fbb89f8e8748a5e731529c8a2de /sal | |
| parent | f012cecd786c03e1210d4d9ba3aab9f1f8decc7b (diff) | |
Avoid uninitialized temp_file_handle
...in case osl_create_temp_file_impl_ doesn't assign to it, for whatever
osl_error reason, which then apparently leads to
<https://crashreport.libreoffice.org/stats/crash_details/e47a9fbb-a6f1-4020-ade8-ab51549b727a>
SIGSEGV at (relative to libreoffice-7-1)
> 0 libuno_sal.so.3 osl_closeFile sal/osl/unx/file.cxx:1154
> 1 libuno_sal.so.3 osl_createTempFile sal/osl/unx/tempfile.cxx:330
> 2 libmergedlo.so PackedFile::flush include/osl/file.hxx:310
> 3 libmergedlo.so comphelper::BackupFileHelper::tryPush_file comphelper/source/misc/backupfilehelper.cxx:2090
[...]
Change-Id: I2e81bbeab7daaaa3c19de4accce8a76ad24faa47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135111
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit bbcf26337cd2933205248909c55d5c1d161e9b9b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135067
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'sal')
| -rw-r--r-- | sal/osl/unx/tempfile.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sal/osl/unx/tempfile.cxx b/sal/osl/unx/tempfile.cxx index 00ae0664b2c0..4a0e7aa0762f 100644 --- a/sal/osl/unx/tempfile.cxx +++ b/sal/osl/unx/tempfile.cxx @@ -278,7 +278,7 @@ oslFileError SAL_CALL osl_createTempFile( rtl_uString** ppustrTempFileURL) { rtl_uString* base_directory = nullptr; - oslFileHandle temp_file_handle; + oslFileHandle temp_file_handle = nullptr; bool b_delete_on_close; oslFileError osl_error; |