summaryrefslogtreecommitdiff
path: root/sal
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2016-09-15 12:43:01 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2016-09-15 13:02:24 +0200
commit27be81819064cb96d98c881f45d6e3fbdf7a33d0 (patch)
treef182a2979a2c0df28f21c1fa0634d56bc772500f /sal
parentf7ae11ce60c0d1d63e09041e621f9e95bb952847 (diff)
loplugin:singlevalfields in l10ntools..sax
and ignore URE headers in the plugin Change-Id: I939df744c1173cf0f67d515f6c3fb4ac4cb25588
Diffstat (limited to 'sal')
-rw-r--r--sal/qa/OStringBuffer/rtl_OStringBuffer.cxx8
-rw-r--r--sal/qa/osl/process/osl_process.cxx5
-rw-r--r--sal/qa/rtl/alloc/rtl_alloc.cxx6
3 files changed, 6 insertions, 13 deletions
diff --git a/sal/qa/OStringBuffer/rtl_OStringBuffer.cxx b/sal/qa/OStringBuffer/rtl_OStringBuffer.cxx
index 9715b290fc6f..117973258070 100644
--- a/sal/qa/OStringBuffer/rtl_OStringBuffer.cxx
+++ b/sal/qa/OStringBuffer/rtl_OStringBuffer.cxx
@@ -8214,7 +8214,7 @@ namespace rtl_OStringBuffer
class append_006_Int32_WrongRadix : public CppUnit::TestFixture
{
OString* arrOUS[5];
- sal_Int32 intVal;
+ static const sal_Int32 intVal = 11;
public:
void setUp() override
@@ -8224,8 +8224,6 @@ namespace rtl_OStringBuffer
arrOUS[2] = new OString( kTestStr25 );
arrOUS[3] = new OString( "" );
arrOUS[4] = new OString( kTestStr28 );
- intVal = 11;
-
}
void tearDown() override
@@ -13966,7 +13964,7 @@ namespace rtl_OStringBuffer
class append_007_Int64_WrongRadix : public CppUnit::TestFixture
{
OString* arrOUS[5];
- sal_Int64 intVal;
+ static const sal_Int64 intVal = 11;
public:
void setUp() override
@@ -13976,8 +13974,6 @@ namespace rtl_OStringBuffer
arrOUS[2] = new OString( kTestStr25 );
arrOUS[3] = new OString( "" );
arrOUS[4] = new OString( kTestStr28 );
- intVal = 11;
-
}
void tearDown() override
diff --git a/sal/qa/osl/process/osl_process.cxx b/sal/qa/osl/process/osl_process.cxx
index 41280a6e7582..2320fd6197f2 100644
--- a/sal/qa/osl/process/osl_process.cxx
+++ b/sal/qa/osl/process/osl_process.cxx
@@ -184,7 +184,7 @@ class Test_osl_executeProcess : public CppUnit::TestFixture
OUString temp_file_url_;
OUString temp_file_path_;
rtl_uString* parameters_[2];
- int parameters_count_;
+ static const int parameters_count_ = 2;
OUString suCWD;
OUString suExecutableFileURL;
@@ -192,8 +192,7 @@ public:
// ctor
Test_osl_executeProcess() :
- env_param_(OUString("-env")),
- parameters_count_(2)
+ env_param_(OUString("-env"))
{
parameters_[0] = env_param_.pData;
suCWD = getExecutablePath();
diff --git a/sal/qa/rtl/alloc/rtl_alloc.cxx b/sal/qa/rtl/alloc/rtl_alloc.cxx
index f567aa32ed4d..ed0a9def1dbe 100644
--- a/sal/qa/rtl/alloc/rtl_alloc.cxx
+++ b/sal/qa/rtl/alloc/rtl_alloc.cxx
@@ -48,12 +48,11 @@ class Memory : public CppUnit::TestFixture
{
// for normal alloc functions
char *m_pMemory;
- sal_uInt32 m_nSizeOfMemory;
+ static const sal_uInt32 m_nSizeOfMemory = 1024;
public:
Memory()
: m_pMemory(nullptr)
- , m_nSizeOfMemory(1024)
{
}
@@ -96,12 +95,11 @@ class TestZeroMemory : public CppUnit::TestFixture
{
// for zero functions
char *m_pZeroMemory;
- sal_uInt32 m_nSizeOfZeroMemory;
+ static const sal_uInt32 m_nSizeOfZeroMemory = 50 * 1024 * 1024;
public:
TestZeroMemory()
: m_pZeroMemory(nullptr)
- , m_nSizeOfZeroMemory( 50 * 1024 * 1024 )
{
}