diff options
| author | Tor Lillqvist <tml@collabora.com> | 2014-12-12 17:57:19 +0200 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2015-03-05 15:14:00 +0100 |
| commit | e9d9d2a517865454ee4c1e92df016bc100416415 (patch) | |
| tree | ceb6b76333835c418f2d03702e9a02302d265e84 /ridljar | |
| parent | 69bc259abe1c9c8576179c7d764c03b5fbf239f2 (diff) | |
Tentative fix for fdo#83937
One clear bug in the code, in my opinion, was that
PDFSigningPKCS7PasswordCallback() returned its argument as such. However, a
PK11PasswordFunc should return "a pointer to the password. This memory must
have been allocated with PR_Malloc or PL_strdup", says
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/SSL_functions/pkfnc.html
.
I could not test this fix fully before my hardware token decided to block
itself, thanks to too many wrong PIN attempts. Possibly it would work to even
just pass NULL for the password callback function and its argument to
NSS_CMSEncoder_Start(). After all, at least with the hardware token and
associated software that I tested with, the software itself pops up a dialog
asking for the PIN (password).
(cherry picked from commit cbf0c9f8332be9abfed6016f9708e3260331eb2d)
Conflicts:
vcl/source/gdi/pdfwriter_impl.cxx
Change-Id: I85a8b2833cfdd1a1d7b7779016fefb71dd53ab80
Diffstat (limited to 'ridljar')
0 files changed, 0 insertions, 0 deletions