Improved loplugin:stringconstant (now that GCC 7 supports it): reportdesign

Change-Id: I18c97a976c7d8d17ffba22185fb47010b628eef0
Reviewed-on: https://gerrit.libreoffice.org/76657
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

23 files changed, 39 insertions, 39 deletions

diff --git a/reportdesign/source/core/api/FixedLine.cxx b/reportdesign/source/core/api/FixedLine.cxx
index 2d80b075a1df..69703fb5fa49 100644
--- a/reportdesign/source/core/api/FixedLine.cxx
+++ b/reportdesign/source/core/api/FixedLine.cxx
@@ -204,7 +204,7 @@ void SAL_CALL OFixedLine::dispose()
 
 OUString OFixedLine::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OFixedLine");
+    return "com.sun.star.comp.report.OFixedLine";
 }
 
 
@@ -521,7 +521,7 @@ OUString SAL_CALL OFixedLine::getShapeType(  )
     ::osl::MutexGuard aGuard(m_aMutex);
     if ( m_aProps.aComponent.m_xShape.is() )
         return m_aProps.aComponent.m_xShape->getShapeType();
-    return OUString("com.sun.star.drawing.ControlShape");
+    return "com.sun.star.drawing.ControlShape";
 }
 
 OUString SAL_CALL OFixedLine::getHyperLinkURL()
diff --git a/reportdesign/source/core/api/FixedText.cxx b/reportdesign/source/core/api/FixedText.cxx
index 5a63491dce69..8a9edda56c89 100644
--- a/reportdesign/source/core/api/FixedText.cxx
+++ b/reportdesign/source/core/api/FixedText.cxx
@@ -93,7 +93,7 @@ void SAL_CALL OFixedText::dispose()
 
 OUString OFixedText::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OFixedText");
+    return "com.sun.star.comp.report.OFixedText";
 }
 
 
@@ -316,7 +316,7 @@ OUString SAL_CALL OFixedText::getShapeType(  )
     ::osl::MutexGuard aGuard(m_aMutex);
     if ( m_aProps.aComponent.m_xShape.is() )
         return m_aProps.aComponent.m_xShape->getShapeType();
-    return OUString("com.sun.star.drawing.ControlShape");
+    return "com.sun.star.drawing.ControlShape";
 }
 
 
diff --git a/reportdesign/source/core/api/FormatCondition.cxx b/reportdesign/source/core/api/FormatCondition.cxx
index 6a484663116d..eb36f66de549 100644
--- a/reportdesign/source/core/api/FormatCondition.cxx
+++ b/reportdesign/source/core/api/FormatCondition.cxx
@@ -58,7 +58,7 @@ void SAL_CALL OFormatCondition::dispose()
 
 OUString OFormatCondition::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OFormatCondition");
+    return "com.sun.star.comp.report.OFormatCondition";
 }
 
 
diff --git a/reportdesign/source/core/api/FormattedField.cxx b/reportdesign/source/core/api/FormattedField.cxx
index 2727c9ed0022..c6ea55d5360a 100644
--- a/reportdesign/source/core/api/FormattedField.cxx
+++ b/reportdesign/source/core/api/FormattedField.cxx
@@ -101,7 +101,7 @@ void SAL_CALL OFormattedField::dispose()
 
 OUString OFormattedField::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OFormattedField");
+    return "com.sun.star.comp.report.OFormattedField";
 }
 
 
@@ -357,7 +357,7 @@ OUString SAL_CALL OFormattedField::getShapeType(  )
     ::osl::MutexGuard aGuard(m_aMutex);
     if ( m_aProps.aComponent.m_xShape.is() )
         return m_aProps.aComponent.m_xShape->getShapeType();
-    return OUString("com.sun.star.drawing.ControlShape");
+    return "com.sun.star.drawing.ControlShape";
 }
 
 
diff --git a/reportdesign/source/core/api/Function.cxx b/reportdesign/source/core/api/Function.cxx
index 3111327aac89..182590865ef7 100644
--- a/reportdesign/source/core/api/Function.cxx
+++ b/reportdesign/source/core/api/Function.cxx
@@ -57,7 +57,7 @@ void SAL_CALL OFunction::dispose()
 
 OUString OFunction::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OFunction");
+    return "com.sun.star.comp.report.OFunction";
 }
 
 
diff --git a/reportdesign/source/core/api/Group.cxx b/reportdesign/source/core/api/Group.cxx
index c68054557312..2f13e170914c 100644
--- a/reportdesign/source/core/api/Group.cxx
+++ b/reportdesign/source/core/api/Group.cxx
@@ -59,7 +59,7 @@ IMPLEMENT_FORWARD_XINTERFACE2(OGroup,GroupBase,GroupPropertySet)
 
 OUString SAL_CALL OGroup::getImplementationName(  )
 {
-    return OUString("com.sun.star.comp.report.Group");
+    return "com.sun.star.comp.report.Group";
 }
 
 uno::Sequence< OUString> OGroup::getSupportedServiceNames_Static()
diff --git a/reportdesign/source/core/api/ImageControl.cxx b/reportdesign/source/core/api/ImageControl.cxx
index 247d1042824f..f0d682bf3a86 100644
--- a/reportdesign/source/core/api/ImageControl.cxx
+++ b/reportdesign/source/core/api/ImageControl.cxx
@@ -166,7 +166,7 @@ void SAL_CALL OImageControl::dispose()
 
 OUString OImageControl::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OImageControl");
+    return "com.sun.star.comp.report.OImageControl";
 }
 
 
@@ -452,7 +452,7 @@ OUString SAL_CALL OImageControl::getShapeType(  )
     ::osl::MutexGuard aGuard(m_aMutex);
     if ( m_aProps.aComponent.m_xShape.is() )
         return m_aProps.aComponent.m_xShape->getShapeType();
-    return OUString("com.sun.star.drawing.ControlShape");
+    return "com.sun.star.drawing.ControlShape";
 }
 
 ::sal_Int16 SAL_CALL OImageControl::getScaleMode()
diff --git a/reportdesign/source/core/api/ReportDefinition.cxx b/reportdesign/source/core/api/ReportDefinition.cxx
index f4994d40397d..dcb0fb6eb1d4 100644
--- a/reportdesign/source/core/api/ReportDefinition.cxx
+++ b/reportdesign/source/core/api/ReportDefinition.cxx
@@ -681,7 +681,7 @@ void SAL_CALL OReportDefinition::disposing()
 
 OUString OReportDefinition::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OReportDefinition");
+    return "com.sun.star.comp.report.OReportDefinition";
 }
 
 OUString SAL_CALL OReportDefinition::getImplementationName(  )
@@ -2219,7 +2219,7 @@ OUString SAL_CALL OReportDefinition::getShapeType(  )
     ::connectivity::checkDisposed(ReportDefinitionBase::rBHelper.bDisposed);
     if ( m_aProps->m_xShape.is() )
         return m_aProps->m_xShape->getShapeType();
-    return OUString("com.sun.star.drawing.OLE2Shape");
+    return "com.sun.star.drawing.OLE2Shape";
 }
 
 typedef ::cppu::WeakImplHelper< container::XNameContainer,
diff --git a/reportdesign/source/core/api/ReportEngineJFree.cxx b/reportdesign/source/core/api/ReportEngineJFree.cxx
index 294572903558..f1a61fa8418d 100644
--- a/reportdesign/source/core/api/ReportEngineJFree.cxx
+++ b/reportdesign/source/core/api/ReportEngineJFree.cxx
@@ -83,7 +83,7 @@ void SAL_CALL OReportEngineJFree::dispose()
 
 OUString OReportEngineJFree::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OReportEngineJFree");
+    return "com.sun.star.comp.report.OReportEngineJFree";
 }
 
 
diff --git a/reportdesign/source/core/api/Section.cxx b/reportdesign/source/core/api/Section.cxx
index b030ae5508e7..1ad60a62e38e 100644
--- a/reportdesign/source/core/api/Section.cxx
+++ b/reportdesign/source/core/api/Section.cxx
@@ -169,7 +169,7 @@ void SAL_CALL OSection::disposing()
 
 OUString SAL_CALL OSection::getImplementationName(  )
 {
-    return OUString("com.sun.star.comp.report.Section");
+    return "com.sun.star.comp.report.Section";
 }
 
 uno::Sequence< OUString> OSection::getSupportedServiceNames_Static()
diff --git a/reportdesign/source/core/api/Shape.cxx b/reportdesign/source/core/api/Shape.cxx
index 99f9d21ab1de..f718394957e2 100644
--- a/reportdesign/source/core/api/Shape.cxx
+++ b/reportdesign/source/core/api/Shape.cxx
@@ -121,7 +121,7 @@ uno::Reference< uno::XInterface > OShape::create(uno::Reference< uno::XComponent
 
 OUString OShape::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.Shape");
+    return "com.sun.star.comp.report.Shape";
 }
 
 
@@ -421,7 +421,7 @@ OUString SAL_CALL OShape::getShapeType(  )
     ::osl::MutexGuard aGuard(m_aMutex);
     if ( m_aProps.aComponent.m_xShape.is() )
         return m_aProps.aComponent.m_xShape->getShapeType();
-    return OUString("com.sun.star.drawing.CustomShape");
+    return "com.sun.star.drawing.CustomShape";
 }
 
 ::sal_Int32 SAL_CALL OShape::getZOrder()
diff --git a/reportdesign/source/filter/xml/dbloader2.cxx b/reportdesign/source/filter/xml/dbloader2.cxx
index 001052e362dc..80414044f41d 100644
--- a/reportdesign/source/filter/xml/dbloader2.cxx
+++ b/reportdesign/source/filter/xml/dbloader2.cxx
@@ -55,7 +55,7 @@ OUString SAL_CALL ORptTypeDetection::detect( Sequence< css::beans::PropertyValue
     {
         INetURLObject aURL(sTemp);
         if ( aURL.GetFileExtension().equalsIgnoreAsciiCase("orp") )
-            return OUString("StarBaseReport");
+            return "StarBaseReport";
         else
         {
             try
@@ -66,7 +66,7 @@ OUString SAL_CALL ORptTypeDetection::detect( Sequence< css::beans::PropertyValue
                     OUString sMediaType;
                     xProp->getPropertyValue("MediaType") >>= sMediaType;
                     if ( sMediaType == MIMETYPE_OASIS_OPENDOCUMENT_REPORT_ASCII )
-                        return OUString("StarBaseReport");
+                        return "StarBaseReport";
                     ::comphelper::disposeComponent(xProp);
                 }
             }
diff --git a/reportdesign/source/filter/xml/dbloader2.hxx b/reportdesign/source/filter/xml/dbloader2.hxx
index e7cb2dc63f9c..08703a776845 100644
--- a/reportdesign/source/filter/xml/dbloader2.hxx
+++ b/reportdesign/source/filter/xml/dbloader2.hxx
@@ -69,7 +69,7 @@ public:
     /// @throws css::uno::RuntimeException
     static OUString getImplementationName_Static()
     {
-        return OUString("com.sun.star.comp.report.ORptTypeDetection");
+        return "com.sun.star.comp.report.ORptTypeDetection";
     }
     /// @throws css::uno::RuntimeException
     static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
diff --git a/reportdesign/source/filter/xml/xmlExport.cxx b/reportdesign/source/filter/xml/xmlExport.cxx
index 2139827e4d13..1a1416994f05 100644
--- a/reportdesign/source/filter/xml/xmlExport.cxx
+++ b/reportdesign/source/filter/xml/xmlExport.cxx
@@ -77,7 +77,7 @@ namespace rptxml
 
     OUString ORptExportHelper::getImplementationName_Static(  )
     {
-        return OUString("com.sun.star.comp.report.XMLSettingsExporter");
+        return "com.sun.star.comp.report.XMLSettingsExporter";
     }
 
     Sequence< OUString > ORptExportHelper::getSupportedServiceNames_Static(  )
@@ -93,7 +93,7 @@ namespace rptxml
 
     OUString ORptContentExportHelper::getImplementationName_Static(  )
     {
-        return OUString("com.sun.star.comp.report.XMLContentExporter");
+        return "com.sun.star.comp.report.XMLContentExporter";
     }
 
     Sequence< OUString > ORptContentExportHelper::getSupportedServiceNames_Static(  )
@@ -111,7 +111,7 @@ namespace rptxml
 
     OUString ORptStylesExportHelper::getImplementationName_Static(  )
     {
-        return OUString("com.sun.star.comp.report.XMLStylesExporter");
+        return "com.sun.star.comp.report.XMLStylesExporter";
     }
 
     Sequence< OUString > ORptStylesExportHelper::getSupportedServiceNames_Static(  )
@@ -128,7 +128,7 @@ namespace rptxml
 
     OUString ORptMetaExportHelper::getImplementationName_Static(  )
     {
-        return OUString("com.sun.star.comp.report.XMLMetaExporter");
+        return "com.sun.star.comp.report.XMLMetaExporter";
     }
 
     Sequence< OUString > ORptMetaExportHelper::getSupportedServiceNames_Static(  )
@@ -145,7 +145,7 @@ namespace rptxml
 
     OUString ODBFullExportHelper::getImplementationName_Static(  )
     {
-        return OUString("com.sun.star.comp.report.XMLFullExporter");
+        return "com.sun.star.comp.report.XMLFullExporter";
     }
 
     Sequence< OUString > ODBFullExportHelper::getSupportedServiceNames_Static(  )
@@ -307,7 +307,7 @@ Reference< XInterface > ORptExport::create(Reference< XComponentContext > const
 
 OUString ORptExport::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.ExportFilter");
+    return "com.sun.star.comp.report.ExportFilter";
 }
 
 
diff --git a/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx b/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
index b2c4ace59a14..00cb0508e706 100644
--- a/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
+++ b/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
@@ -109,7 +109,7 @@ uno::Sequence< OUString > SAL_CALL ExportDocumentHandler::getSupportedServiceNam
 
 OUString ExportDocumentHandler::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.ExportDocumentHandler");
+    return "com.sun.star.comp.report.ExportDocumentHandler";
 }
 
 
diff --git a/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx b/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
index f023f288ca2a..43a68a40e482 100644
--- a/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
+++ b/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
@@ -84,7 +84,7 @@ uno::Sequence< OUString > SAL_CALL ImportDocumentHandler::getSupportedServiceNam
 
 OUString ImportDocumentHandler::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.ImportDocumentHandler");
+    return "com.sun.star.comp.report.ImportDocumentHandler";
 }
 
 uno::Sequence< OUString > ImportDocumentHandler::getSupportedServiceNames_static(  )
diff --git a/reportdesign/source/filter/xml/xmlfilter.cxx b/reportdesign/source/filter/xml/xmlfilter.cxx
index 0f5f539d0da5..c7cc090755f2 100644
--- a/reportdesign/source/filter/xml/xmlfilter.cxx
+++ b/reportdesign/source/filter/xml/xmlfilter.cxx
@@ -268,7 +268,7 @@ uno::Reference< uno::XInterface > ORptImportHelper::create(uno::Reference< uno::
 
 OUString ORptImportHelper::getImplementationName_Static(  )
 {
-    return OUString(SERVICE_SETTINGSIMPORTER);
+    return SERVICE_SETTINGSIMPORTER;
 }
 
 Sequence< OUString > ORptImportHelper::getSupportedServiceNames_Static(  )
@@ -285,7 +285,7 @@ Reference< XInterface > ORptContentImportHelper::create(const Reference< XCompon
 
 OUString ORptContentImportHelper::getImplementationName_Static(  )
 {
-    return OUString(SERVICE_CONTENTIMPORTER);
+    return SERVICE_CONTENTIMPORTER;
 }
 
 Sequence< OUString > ORptContentImportHelper::getSupportedServiceNames_Static(  )
@@ -304,7 +304,7 @@ Reference< XInterface > ORptStylesImportHelper::create(Reference< XComponentCont
 
 OUString ORptStylesImportHelper::getImplementationName_Static(  )
 {
-    return OUString(SERVICE_STYLESIMPORTER);
+    return SERVICE_STYLESIMPORTER;
 }
 
 Sequence< OUString > ORptStylesImportHelper::getSupportedServiceNames_Static(  )
@@ -322,7 +322,7 @@ Reference< XInterface > ORptMetaImportHelper::create(Reference< XComponentContex
 
 OUString ORptMetaImportHelper::getImplementationName_Static(  )
 {
-    return OUString(SERVICE_METAIMPORTER);
+    return SERVICE_METAIMPORTER;
 }
 
 Sequence< OUString > ORptMetaImportHelper::getSupportedServiceNames_Static(  )
@@ -364,7 +364,7 @@ uno::Reference< XInterface > ORptFilter::create(uno::Reference< XComponentContex
 
 OUString ORptFilter::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.OReportFilter");
+    return "com.sun.star.comp.report.OReportFilter";
 }
 
 uno::Sequence< OUString > ORptFilter::getSupportedServiceNames_Static(  )
diff --git a/reportdesign/source/ui/inspection/DataProviderHandler.cxx b/reportdesign/source/ui/inspection/DataProviderHandler.cxx
index f78f7a08a335..6688bce10052 100644
--- a/reportdesign/source/ui/inspection/DataProviderHandler.cxx
+++ b/reportdesign/source/ui/inspection/DataProviderHandler.cxx
@@ -89,7 +89,7 @@ uno::Sequence< OUString > SAL_CALL DataProviderHandler::getSupportedServiceNames
 
 OUString DataProviderHandler::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.DataProviderHandler");
+    return "com.sun.star.comp.report.DataProviderHandler";
 }
 
 uno::Sequence< OUString > DataProviderHandler::getSupportedServiceNames_static(  )
diff --git a/reportdesign/source/ui/inspection/DefaultInspection.cxx b/reportdesign/source/ui/inspection/DefaultInspection.cxx
index 2067652f413a..986bf85df88c 100644
--- a/reportdesign/source/ui/inspection/DefaultInspection.cxx
+++ b/reportdesign/source/ui/inspection/DefaultInspection.cxx
@@ -77,7 +77,7 @@ namespace rptui
 
     OUString DefaultComponentInspectorModel::getImplementationName_Static(  )
     {
-        return OUString("com.sun.star.comp.report.DefaultComponentInspectorModel");
+        return "com.sun.star.comp.report.DefaultComponentInspectorModel";
     }
 
     Sequence< OUString > DefaultComponentInspectorModel::getSupportedServiceNames_static(  )
diff --git a/reportdesign/source/ui/inspection/GeometryHandler.cxx b/reportdesign/source/ui/inspection/GeometryHandler.cxx
index 6dc21255c9ef..f6135f5307f2 100644
--- a/reportdesign/source/ui/inspection/GeometryHandler.cxx
+++ b/reportdesign/source/ui/inspection/GeometryHandler.cxx
@@ -255,7 +255,7 @@ uno::Sequence< OUString > SAL_CALL GeometryHandler::getSupportedServiceNames(  )
 
 OUString GeometryHandler::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.GeometryHandler");
+    return "com.sun.star.comp.report.GeometryHandler";
 }
 
 uno::Sequence< OUString > GeometryHandler::getSupportedServiceNames_static(  )
diff --git a/reportdesign/source/ui/inspection/ReportComponentHandler.cxx b/reportdesign/source/ui/inspection/ReportComponentHandler.cxx
index 65bfc1bd0af7..9ebc6f01b789 100644
--- a/reportdesign/source/ui/inspection/ReportComponentHandler.cxx
+++ b/reportdesign/source/ui/inspection/ReportComponentHandler.cxx
@@ -66,7 +66,7 @@ uno::Sequence< OUString > SAL_CALL ReportComponentHandler::getSupportedServiceNa
 
 OUString ReportComponentHandler::getImplementationName_Static(  )
 {
-    return OUString("com.sun.star.comp.report.ReportComponentHandler");
+    return "com.sun.star.comp.report.ReportComponentHandler";
 }
 
 uno::Sequence< OUString > ReportComponentHandler::getSupportedServiceNames_static(  )
diff --git a/reportdesign/source/ui/misc/statusbarcontroller.cxx b/reportdesign/source/ui/misc/statusbarcontroller.cxx
index 7be11dc6be27..ca66d2062715 100644
--- a/reportdesign/source/ui/misc/statusbarcontroller.cxx
+++ b/reportdesign/source/ui/misc/statusbarcontroller.cxx
@@ -49,7 +49,7 @@ OUString SAL_CALL OStatusbarController::getImplementationName()
 
 OUString OStatusbarController::getImplementationName_Static()
 {
-    return OUString("com.sun.star.report.comp.StatusbarController");
+    return "com.sun.star.report.comp.StatusbarController";
 }
 
 Sequence< OUString> OStatusbarController::getSupportedServiceNames_Static()
diff --git a/reportdesign/source/ui/report/ReportController.cxx b/reportdesign/source/ui/report/ReportController.cxx
index 6023758ded55..fd0a6b4ca88e 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -255,7 +255,7 @@ OUString SAL_CALL OReportController::getImplementationName()
 
 OUString OReportController::getImplementationName_Static()
 {
-    return OUString("com.sun.star.report.comp.ReportDesign");
+    return "com.sun.star.report.comp.ReportDesign";
 }
 
 Sequence< OUString> OReportController::getSupportedServiceNames_Static()