diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-12 12:08:00 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2016-04-14 11:37:19 +0000 |
commit | 62633dfe026bc3badf7066e5fb454036bae9cfdc (patch) | |
tree | b1a30ddd709ba80b8629d916d54c03d733651d12 /reportdesign | |
parent | aa458c31a5dfa2be8b6bd8f1b4e402ce8c27edde (diff) |
clang-tidy performance-unnecessary-value-param in various
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'reportdesign')
-rw-r--r-- | reportdesign/source/filter/xml/xmlfilter.cxx | 2 | ||||
-rw-r--r-- | reportdesign/source/ui/inc/ReportController.hxx | 6 | ||||
-rw-r--r-- | reportdesign/source/ui/report/ReportController.cxx | 6 | ||||
-rw-r--r-- | reportdesign/source/ui/report/dlgedfunc.cxx | 2 |
4 files changed, 8 insertions, 8 deletions
diff --git a/reportdesign/source/filter/xml/xmlfilter.cxx b/reportdesign/source/filter/xml/xmlfilter.cxx index 57a2c22ec7ae..4ab047c39304 100644 --- a/reportdesign/source/filter/xml/xmlfilter.cxx +++ b/reportdesign/source/filter/xml/xmlfilter.cxx @@ -193,7 +193,7 @@ sal_Int32 ReadThroughComponent( /// read a component (storage version) sal_Int32 ReadThroughComponent( - uno::Reference< embed::XStorage > xStorage, + const uno::Reference< embed::XStorage >& xStorage, const uno::Reference<XComponent>& xModelComponent, const sal_Char* pStreamName, const sal_Char* pCompatibilityStreamName, diff --git a/reportdesign/source/ui/inc/ReportController.hxx b/reportdesign/source/ui/inc/ReportController.hxx index 3342b75cab07..fc8dcd9c7fb6 100644 --- a/reportdesign/source/ui/inc/ReportController.hxx +++ b/reportdesign/source/ui/inc/ReportController.hxx @@ -215,11 +215,11 @@ namespace rptui @param _nUndoStrId the string id of the string which is shown in undo menu @param _nShrinkId ID of what you would like to shrink. */ - static void shrinkSectionBottom(css::uno::Reference< css::report::XSection > _xSection); - static void shrinkSectionTop(css::uno::Reference< css::report::XSection > _xSection); + static void shrinkSectionBottom(const css::uno::Reference< css::report::XSection >& _xSection); + static void shrinkSectionTop(const css::uno::Reference< css::report::XSection >& _xSection); public: - void shrinkSection(sal_uInt16 _nUndoStrId, css::uno::Reference< css::report::XSection > _xSection, sal_Int32 _nShrinkId); + void shrinkSection(sal_uInt16 _nUndoStrId, const css::uno::Reference< css::report::XSection >& _xSection, sal_Int32 _nShrinkId); /** opens the file open dialog to allow the user to select a image which will be * bound to a newly created image button. diff --git a/reportdesign/source/ui/report/ReportController.cxx b/reportdesign/source/ui/report/ReportController.cxx index ad510d4d9bbe..4093850d4e5f 100644 --- a/reportdesign/source/ui/report/ReportController.cxx +++ b/reportdesign/source/ui/report/ReportController.cxx @@ -2625,7 +2625,7 @@ void OReportController::alignControlsWithUndo(sal_uInt16 _nUndoStrId,sal_Int32 _ InvalidateFeature( SID_UNDO ); } -void OReportController::shrinkSectionBottom(uno::Reference<report::XSection> _xSection) +void OReportController::shrinkSectionBottom(const uno::Reference<report::XSection>& _xSection) { const sal_Int32 nElements = _xSection->getCount(); if (nElements == 0) @@ -2656,7 +2656,7 @@ void OReportController::shrinkSectionBottom(uno::Reference<report::XSection> _xS _xSection->setHeight(nMaxPositionY); } -void OReportController::shrinkSectionTop(uno::Reference<report::XSection> _xSection) +void OReportController::shrinkSectionTop(const uno::Reference<report::XSection>& _xSection) { const sal_Int32 nElements = _xSection->getCount(); if (nElements == 0) @@ -2693,7 +2693,7 @@ void OReportController::shrinkSectionTop(uno::Reference<report::XSection> _xSect _xSection->setHeight(nNewSectionHeight); } -void OReportController::shrinkSection(sal_uInt16 _nUndoStrId, uno::Reference<report::XSection> _xSection, sal_Int32 _nSid) +void OReportController::shrinkSection(sal_uInt16 _nUndoStrId, const uno::Reference<report::XSection>& _xSection, sal_Int32 _nSid) { if ( _xSection.is() ) { diff --git a/reportdesign/source/ui/report/dlgedfunc.cxx b/reportdesign/source/ui/report/dlgedfunc.cxx index a8f7cede94d1..b38ac8f70357 100644 --- a/reportdesign/source/ui/report/dlgedfunc.cxx +++ b/reportdesign/source/ui/report/dlgedfunc.cxx @@ -131,7 +131,7 @@ void DlgEdFunc::setOverlappedControlColor(sal_Int32 _nColor) m_nOverlappedControlColor = _nColor; } -sal_Int32 lcl_setColorOfObject(uno::Reference< uno::XInterface > _xObj, long _nColorTRGB) +sal_Int32 lcl_setColorOfObject(const uno::Reference< uno::XInterface >& _xObj, long _nColorTRGB) { sal_Int32 nBackColor = 0; try |