diff options
| author | Noel Grandin <noel@peralex.com> | 2014-10-27 14:02:38 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-10-29 09:36:17 +0200 |
| commit | bacee60a5920585feeff58840357aa7ac33e50a7 (patch) | |
| tree | 75da30b17723f95d35e47e4794dd6c3537833fc1 /reportdesign | |
| parent | 7344923ffdf751646396b38af6a23be93b53a06a (diff) | |
ref-counting vcl::Window subclasses
Points of discussion
--------------------
(*) where in the Window destructor should dispose() be called?
It's a seriously large method.
(*) we're going to need similar typedefs and declarations for every
single sub-class of vcl::Window, I assume that I will need to create a
macro to make it less verbose.
TODO
----
Update clang plugin to verify that:
(a) dispose() methods always call their superclass dispose()
(b) dispose() methods don't forget to clear any references owned
by that class.
Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
Diffstat (limited to 'reportdesign')
| -rw-r--r-- | reportdesign/source/ui/dlg/GroupsSorting.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/reportdesign/source/ui/dlg/GroupsSorting.cxx b/reportdesign/source/ui/dlg/GroupsSorting.cxx index 121a944a982a..aa8692522c76 100644 --- a/reportdesign/source/ui/dlg/GroupsSorting.cxx +++ b/reportdesign/source/ui/dlg/GroupsSorting.cxx @@ -182,7 +182,7 @@ OFieldExpressionControl::OFieldExpressionControl(OGroupsSortingDialog* _pParentD OFieldExpressionControl::~OFieldExpressionControl() { - acquire(); + WeakImplHelper1::acquire(); uno::Reference< report::XGroups > xGroups = m_pParent->getGroups(); xGroups->removeContainerListener(this); |