improve loplugin:unusedfields

noticed something that wasn't being picked up, wrote some tests,
and found an unhandled case in Plugin::getParentFunctionDecl

Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 1 insertions, 4 deletions

diff --git a/reportdesign/source/filter/xml/xmlfilter.hxx b/reportdesign/source/filter/xml/xmlfilter.hxx
index 447c41a737e6..25202e2fd6c9 100644
--- a/reportdesign/source/filter/xml/xmlfilter.hxx
+++ b/reportdesign/source/filter/xml/xmlfilter.hxx
@@ -67,7 +67,6 @@ private:
 
     TGroupFunctionMap                               m_aFunctions;
 
-    mutable ::std::unique_ptr<SvXMLTokenMap>        m_pDocContentElemTokenMap;
     mutable ::std::unique_ptr<SvXMLTokenMap>        m_pReportElemTokenMap;
     mutable ::std::unique_ptr<SvXMLTokenMap>        m_pCellElemTokenMap;
 
diff --git a/reportdesign/source/ui/dlg/Navigator.cxx b/reportdesign/source/ui/dlg/Navigator.cxx
index c6ddd96b399f..8b68f9adf6e4 100644
--- a/reportdesign/source/ui/dlg/Navigator.cxx
+++ b/reportdesign/source/ui/dlg/Navigator.cxx
@@ -798,13 +798,11 @@ public:
     ONavigatorImpl& operator=(const ONavigatorImpl&) = delete;
 
     uno::Reference< report::XReportDefinition>  m_xReport;
-    ::rptui::OReportController&                 m_rController;
     std::unique_ptr<NavigatorTree>              m_xNavigatorTree;
 };
 
 ONavigatorImpl::ONavigatorImpl(OReportController& rController, weld::Builder& rBuilder)
     : m_xReport(rController.getReportDefinition())
-    , m_rController(rController)
     , m_xNavigatorTree(std::make_unique<NavigatorTree>(rBuilder.weld_tree_view("treeview"), rController))
 {
     reportdesign::OReportVisitor aVisitor(m_xNavigatorTree.get());
@@ -812,7 +810,7 @@ ONavigatorImpl::ONavigatorImpl(OReportController& rController, weld::Builder& rB
     std::unique_ptr<weld::TreeIter> xScratch = m_xNavigatorTree->make_iterator();
     if (m_xNavigatorTree->find(m_xReport, *xScratch))
         m_xNavigatorTree->expand_row(*xScratch);
-    lang::EventObject aEvent(m_rController);
+    lang::EventObject aEvent(rController);
     m_xNavigatorTree->_selectionChanged(aEvent);
 }