diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 07:54:15 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 10:29:38 +0200 |
| commit | edc85fb55f8adc30a1416c6c854c89097060fb21 (patch) | |
| tree | daf9701247beee33cdb6af9d0486d1ba9a0932f7 /reportdesign/source/core/sdr | |
| parent | 86cce1343ca5ed85eece1c9d065f9f861d57f9d9 (diff) | |
clang-tidy performance-unnecessary-copy-init in idl..reportdesign
Change-Id: I4b2eda375bbfe1ba35a45168515d885935adcb76
Reviewed-on: https://gerrit.libreoffice.org/62217
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'reportdesign/source/core/sdr')
| -rw-r--r-- | reportdesign/source/core/sdr/ReportDrawPage.cxx | 2 | ||||
| -rw-r--r-- | reportdesign/source/core/sdr/RptObject.cxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/reportdesign/source/core/sdr/ReportDrawPage.cxx b/reportdesign/source/core/sdr/ReportDrawPage.cxx index 87984ce3b445..15910df12a12 100644 --- a/reportdesign/source/core/sdr/ReportDrawPage.cxx +++ b/reportdesign/source/core/sdr/ReportDrawPage.cxx @@ -75,7 +75,7 @@ uno::Reference< drawing::XShape > OReportDrawPage::CreateShape( SdrObject *pObj if ( xFactory.is() ) { bool bChangeOrientation = false; - OUString sServiceName = pBaseObj->getServiceName(); + const OUString& sServiceName = pBaseObj->getServiceName(); OSL_ENSURE(!sServiceName.isEmpty(),"No Service Name given!"); if (dynamic_cast< const OUnoObject* >(pObj) != nullptr) diff --git a/reportdesign/source/core/sdr/RptObject.cxx b/reportdesign/source/core/sdr/RptObject.cxx index ea94d02740b5..eb0f45742e77 100644 --- a/reportdesign/source/core/sdr/RptObject.cxx +++ b/reportdesign/source/core/sdr/RptObject.cxx @@ -404,7 +404,7 @@ void OObjectBase::SetPropsFromRect(const tools::Rectangle& _rRect) OReportPage* pPage = dynamic_cast<OReportPage*>(GetImplPage()); if ( pPage && !_rRect.IsEmpty() ) { - uno::Reference<report::XSection> xSection = pPage->getSection(); + const uno::Reference<report::XSection>& xSection = pPage->getSection(); assert(_rRect.getHeight() >= 0); const sal_uInt32 newHeight( ::std::max(0l, _rRect.getHeight()+_rRect.Top()) ); if ( xSection.is() && ( newHeight > xSection->getHeight() ) ) |