diff options
author | Noel Grandin <noel@peralex.com> | 2014-11-03 14:03:54 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2014-11-05 08:44:19 +0200 |
commit | 705c48d32eec0aa5180e60ca157daca4b154e4a3 (patch) | |
tree | 97f43496f4b429a2b8d03b1e71cb2a1c33142a15 /reportdesign/source/core/misc/reportformula.cxx | |
parent | b7d8a58ff2698ffc6e22943f64aa97c5ea253bd9 (diff) |
fdo#38835 strip out OUString globals
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
Diffstat (limited to 'reportdesign/source/core/misc/reportformula.cxx')
-rw-r--r-- | reportdesign/source/core/misc/reportformula.cxx | 31 |
1 files changed, 9 insertions, 22 deletions
diff --git a/reportdesign/source/core/misc/reportformula.cxx b/reportdesign/source/core/misc/reportformula.cxx index 0b53d279f1a1..77d24b853751 100644 --- a/reportdesign/source/core/misc/reportformula.cxx +++ b/reportdesign/source/core/misc/reportformula.cxx @@ -31,22 +31,8 @@ namespace rptui namespace { - const OUString& lcl_getExpressionPrefix( sal_Int32* _pTakeLengthOrNull = NULL ) - { - static OUString s_sPrefix( "rpt:" ); - if ( _pTakeLengthOrNull ) - *_pTakeLengthOrNull = s_sPrefix.getLength(); - return s_sPrefix; - } - - - const OUString& lcl_getFieldPrefix( sal_Int32* _pTakeLengthOrNull = NULL ) - { - static OUString s_sPrefix( "field:" ); - if ( _pTakeLengthOrNull ) - *_pTakeLengthOrNull = s_sPrefix.getLength(); - return s_sPrefix; - } + static const char sExpressionPrefix[] = "rpt:"; + static const char sFieldPrefix[] = "field:"; } @@ -67,17 +53,17 @@ namespace rptui { case Expression: { - if ( _rFieldOrExpression.startsWith( lcl_getExpressionPrefix() ) ) + if ( _rFieldOrExpression.startsWith( sExpressionPrefix ) ) m_sCompleteFormula = _rFieldOrExpression; else - m_sCompleteFormula = lcl_getExpressionPrefix() + _rFieldOrExpression; + m_sCompleteFormula = sExpressionPrefix + _rFieldOrExpression; } break; case Field: { OUStringBuffer aBuffer; - aBuffer.append( lcl_getFieldPrefix() ); + aBuffer.append( sFieldPrefix ); aBuffer.appendAscii( "[" ); aBuffer.append( _rFieldOrExpression ); aBuffer.appendAscii( "]" ); @@ -100,18 +86,19 @@ namespace rptui { m_sCompleteFormula = _rFormula; - sal_Int32 nPrefixLen( -1 ); // is it an ordinary expression? - if ( m_sCompleteFormula.startsWith( lcl_getExpressionPrefix( &nPrefixLen ) ) ) + if ( m_sCompleteFormula.startsWith( sExpressionPrefix ) ) { + sal_Int32 nPrefixLen = strlen(sExpressionPrefix); m_eType = Expression; m_sUndecoratedContent = m_sCompleteFormula.copy( nPrefixLen ); return; } /// does it refer to a field? - if ( m_sCompleteFormula.startsWith( lcl_getFieldPrefix( &nPrefixLen ) ) ) + if ( m_sCompleteFormula.startsWith( sFieldPrefix ) ) { + sal_Int32 nPrefixLen = strlen(sFieldPrefix); if ( ( m_sCompleteFormula.getLength() >= nPrefixLen + 2 ) && ( m_sCompleteFormula[ nPrefixLen ] == '[' ) && ( m_sCompleteFormula[ m_sCompleteFormula.getLength() - 1 ] == ']' ) |