diff options
| author | Lionel Elie Mamane <lionel@mamane.lu> | 2013-02-19 11:38:16 +0100 |
|---|---|---|
| committer | Lionel Elie Mamane <lionel@mamane.lu> | 2013-02-19 12:35:02 +0100 |
| commit | 532421d208f21531d55554a356dd51105ba718bf (patch) | |
| tree | 5a49f44ab94fb2efed4cd97350a23f81721b4688 /reportbuilder/java/com/sun/star/report/pentaho/model | |
| parent | 818b84eb1573b55961cba56baca857806c0e8c8b (diff) | |
fdo#52948 fix print-repeated-values=no with formatted values
Factorise the "should this element be printed" decision into an
utility function, which is used by
1) AbstractReportElementLayoutController
(in charge of non-formatted values: string, image, OLE object, ...)
which already obeyed PrintRepeatedValues.
2) TableCellLayoutController
(in charge of formatted values: dates, numbers, ...)
which blissfully ignored PrintRepeatedValues,
but obeyed the display condition.
Rename the inconsistently named
PrintWhenGroupChange
PrintWhenGroupChanges
print-only-when-group-change
print-when-group-change
to
PrintWhenGroupChange / print-when-group-change
Change the meaning of "PrintWhenGroupChange" to "override
PrintRepeatedValues in first occurrence in group". Since this feature
never worked under the old semantics, no loss of feature. Since we
change the XML attribute name, no ascending compatibility problem: it
will be reset to its default value.
Pursuant to the new meaning of PrintWhenGroupChange, change its
default to *true*, which is the sane default.
Change-Id: Idbe8e90565a354f70db222d047b3d51eeddbbb9f
Diffstat (limited to 'reportbuilder/java/com/sun/star/report/pentaho/model')
| -rw-r--r-- | reportbuilder/java/com/sun/star/report/pentaho/model/ReportElement.java | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/reportbuilder/java/com/sun/star/report/pentaho/model/ReportElement.java b/reportbuilder/java/com/sun/star/report/pentaho/model/ReportElement.java index 74e48229bd84..37e11ffc0637 100644 --- a/reportbuilder/java/com/sun/star/report/pentaho/model/ReportElement.java +++ b/reportbuilder/java/com/sun/star/report/pentaho/model/ReportElement.java @@ -49,15 +49,15 @@ public abstract class ReportElement extends Element * @return true, if the element should only be printed in the first row of the * current group, false otherwise. */ - public boolean isPrintWhenGroupChanges() + public boolean isPrintWhenGroupChange() { - return OfficeToken.TRUE.equals(getAttribute(OfficeNamespaces.OOREPORT_NS, "print-when-group-changes")); + return OfficeToken.TRUE.equals(getAttribute(OfficeNamespaces.OOREPORT_NS, "print-when-group-change")); } - public void setPrintWhenGroupChanges(final boolean printWhenGroupChanges) + public void setPrintWhenGroupChange(final boolean printWhenGroupChange) { - setAttribute(OfficeNamespaces.OOREPORT_NS, "print-when-group-changes", - String.valueOf(printWhenGroupChanges)); + setAttribute(OfficeNamespaces.OOREPORT_NS, "print-when-group-change", + String.valueOf(printWhenGroupChange)); } /** |