diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-07 15:47:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-08 08:45:41 +0200 |
| commit | 7764ae70b04058a64a3999529e98d1115ba59d1c (patch) | |
| tree | 23a78251b97610b7a948ef776dfbcbc48aefbd8d /registry | |
| parent | 37d5bf82eae7e6d611879d1132b1f6fdafdeb9ed (diff) | |
clang bugprone-unused-return-value
most of these changes just make the change of ownership when using
std::unique_ptr clearer, but there is one definite leak fix in
PlainTextFilterDetect::detect
Change-Id: I8282a68007222a4fee84004f394bde0cca8569e9
Reviewed-on: https://gerrit.libreoffice.org/60159
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'registry')
| -rw-r--r-- | registry/source/regimpl.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx index a7647b9d512f..ac065a3e65a3 100644 --- a/registry/source/regimpl.cxx +++ b/registry/source/regimpl.cxx @@ -700,8 +700,7 @@ RegError ORegistry::openKey(RegKeyHandle hKey, const OUString& keyName, } std::unique_ptr< ORegKey > p(new ORegKey(path, this)); - i = m_openKeyTable.insert(std::make_pair(path, p.get())).first; - p.release(); + i = m_openKeyTable.insert(std::make_pair(path, p.release())).first; } else { i->second->acquire(); } |