summaryrefslogtreecommitdiff
path: root/registry
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-11-01 15:54:13 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-11-02 10:45:01 +0100
commit455e4011f7052c5d1fb4693a573e0998cf6badc8 (patch)
treece9b3b511a3b61b936af7a4970ab4bcbaf620628 /registry
parentcee129bf17bd604f96e3cfe62d3a55336e248ccd (diff)
improve constparam loplugin
lots of little fixes to make the logic less pessimistic Change-Id: If368822984250b11b98c56f5890177a1402e8660 Reviewed-on: https://gerrit.libreoffice.org/44168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'registry')
-rw-r--r--registry/source/keyimpl.cxx2
-rw-r--r--registry/source/keyimpl.hxx2
-rw-r--r--registry/source/reflwrit.cxx8
-rw-r--r--registry/source/regkey.cxx2
-rw-r--r--registry/source/regkey.hxx2
5 files changed, 8 insertions, 8 deletions
diff --git a/registry/source/keyimpl.cxx b/registry/source/keyimpl.cxx
index 68b6794f1c28..371290ca9b6b 100644
--- a/registry/source/keyimpl.cxx
+++ b/registry/source/keyimpl.cxx
@@ -356,7 +356,7 @@ RegError ORegKey::setValue(const OUString& valueName, RegValueType vType, RegVal
// setLongListValue
-RegError ORegKey::setLongListValue(const OUString& valueName, sal_Int32* pValueList, sal_uInt32 len)
+RegError ORegKey::setLongListValue(const OUString& valueName, sal_Int32 const * pValueList, sal_uInt32 len)
{
OStoreStream rValue;
sal_uInt8* pBuffer;
diff --git a/registry/source/keyimpl.hxx b/registry/source/keyimpl.hxx
index f8f90e86407a..27043d2cc223 100644
--- a/registry/source/keyimpl.hxx
+++ b/registry/source/keyimpl.hxx
@@ -65,7 +65,7 @@ public:
sal_uInt32 vSize);
RegError setLongListValue(const OUString& valueName,
- sal_Int32* pValueList,
+ sal_Int32 const * pValueList,
sal_uInt32 len);
RegError setStringListValue(const OUString& valueName,
diff --git a/registry/source/reflwrit.cxx b/registry/source/reflwrit.cxx
index fd57ebc2047a..45c5ae474a2c 100644
--- a/registry/source/reflwrit.cxx
+++ b/registry/source/reflwrit.cxx
@@ -1190,12 +1190,12 @@ sal_Bool TYPEREG_CALLTYPE typereg_writer_setMethodParameterData(
}
sal_Bool TYPEREG_CALLTYPE typereg_writer_setMethodExceptionTypeName(
- void * handle, sal_uInt16 methodIndex, sal_uInt16 exceptionIndex,
+ void const * handle, sal_uInt16 methodIndex, sal_uInt16 exceptionIndex,
rtl_uString const * typeName)
SAL_THROW_EXTERN_C()
{
try {
- static_cast< TypeWriter * >(handle)->m_methods[methodIndex].setExcName(
+ static_cast< TypeWriter const * >(handle)->m_methods[methodIndex].setExcName(
exceptionIndex, toByteString(typeName));
} catch (std::bad_alloc &) {
return false;
@@ -1268,11 +1268,11 @@ void TYPEREG_CALLTYPE typereg_writer_destroy(void * handle) SAL_THROW_EXTERN_C()
}
sal_Bool TYPEREG_CALLTYPE typereg_writer_setSuperTypeName(
- void * handle, sal_uInt16 index, rtl_uString const * typeName)
+ void const * handle, sal_uInt16 index, rtl_uString const * typeName)
SAL_THROW_EXTERN_C()
{
try {
- static_cast< TypeWriter * >(handle)->setSuperType(
+ static_cast< TypeWriter const * >(handle)->setSuperType(
index, toByteString(typeName));
} catch (std::bad_alloc &) {
return false;
diff --git a/registry/source/regkey.cxx b/registry/source/regkey.cxx
index bc97dffce11b..bf4f464d7b52 100644
--- a/registry/source/regkey.cxx
+++ b/registry/source/regkey.cxx
@@ -238,7 +238,7 @@ RegError REGISTRY_CALLTYPE setValue(RegKeyHandle hKey,
RegError REGISTRY_CALLTYPE setLongListValue(RegKeyHandle hKey,
rtl_uString* keyName,
- sal_Int32* pValueList,
+ sal_Int32 const * pValueList,
sal_uInt32 len)
{
ORegKey* pKey = static_cast< ORegKey* >(hKey);
diff --git a/registry/source/regkey.hxx b/registry/source/regkey.hxx
index e45bc50f1976..45c55cee93a7 100644
--- a/registry/source/regkey.hxx
+++ b/registry/source/regkey.hxx
@@ -41,7 +41,7 @@ RegError REGISTRY_CALLTYPE closeKey(RegKeyHandle);
RegError REGISTRY_CALLTYPE setValue(
RegKeyHandle, rtl_uString*, RegValueType, RegValue, sal_uInt32);
RegError REGISTRY_CALLTYPE setLongListValue(
- RegKeyHandle, rtl_uString*, sal_Int32*, sal_uInt32);
+ RegKeyHandle, rtl_uString*, sal_Int32 const *, sal_uInt32);
RegError REGISTRY_CALLTYPE setStringListValue(
RegKeyHandle, rtl_uString*, sal_Char**, sal_uInt32);
RegError REGISTRY_CALLTYPE setUnicodeListValue(