java: final fields that can be static

found by PMD

Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

20 files changed, 21 insertions, 21 deletions

diff --git a/qadevOOo/runner/graphical/ParameterHelper.java b/qadevOOo/runner/graphical/ParameterHelper.java
index 2c9e95217ed9..30d5aa89dd90 100644
--- a/qadevOOo/runner/graphical/ParameterHelper.java
+++ b/qadevOOo/runner/graphical/ParameterHelper.java
@@ -67,7 +67,7 @@ public class ParameterHelper
 
     private String m_sPrinterName = null;
 
-    private final int m_nResolutionInDPI = 180;
+    private static final int m_nResolutionInDPI = 180;
 
     private String m_sInputPath = null;
     private String m_sOutputPath = null;
diff --git a/qadevOOo/runner/lib/TestParameters.java b/qadevOOo/runner/lib/TestParameters.java
index abd1dc29097b..1ca6a5c5b638 100644
--- a/qadevOOo/runner/lib/TestParameters.java
+++ b/qadevOOo/runner/lib/TestParameters.java
@@ -51,7 +51,7 @@ public class TestParameters extends HashMap<String,Object> {
      * Debug information will always be written on standard out.<br>
      * default is true
      */
-    private final boolean DebugIsActive = false;
+    private static final boolean DebugIsActive = false;
 
     /**
      * Wrapper around "get()" with some debug output
diff --git a/qadevOOo/runner/util/ShapeDsc.java b/qadevOOo/runner/util/ShapeDsc.java
index 99fdaea84fc8..e47128172178 100644
--- a/qadevOOo/runner/util/ShapeDsc.java
+++ b/qadevOOo/runner/util/ShapeDsc.java
@@ -32,7 +32,7 @@ public class ShapeDsc extends InstDescr {
     private final int y;
     private final int height;
     private final int width;
-    private final String name = null;
+    private static final String name = null;
     private static final String ifcName = "com.sun.star.drawing.XShape";
     private final String service;
 
diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java
index a7fbc9d70ada..a11b868615c2 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java
@@ -49,7 +49,7 @@ public class _XAccessibleValue extends MultiMethodTest {
 
     private double minVal = 0;
     private double maxVal = 0;
-    private final double curVal = 0;
+    private static final double curVal = 0;
     private Object val = null;
     XAccessibleValue anotherFromGroup = null;
 
diff --git a/qadevOOo/tests/java/ifc/frame/_XLayoutManager.java b/qadevOOo/tests/java/ifc/frame/_XLayoutManager.java
index e250ce2ea4e0..ce2641498da8 100644
--- a/qadevOOo/tests/java/ifc/frame/_XLayoutManager.java
+++ b/qadevOOo/tests/java/ifc/frame/_XLayoutManager.java
@@ -32,7 +32,7 @@ public class _XLayoutManager extends MultiMethodTest {
     public XLayoutManager oObj = null;
 
     private XFrame xFrame = null;
-    private final String sElementName = "private:resource/menubar/myMenu";
+    private static final String sElementName = "private:resource/menubar/myMenu";
 
     @Override
     public void before() {
diff --git a/qadevOOo/tests/java/ifc/frame/_XUIControllerRegistration.java b/qadevOOo/tests/java/ifc/frame/_XUIControllerRegistration.java
index e2c236e4ac2e..e42b9be240e1 100644
--- a/qadevOOo/tests/java/ifc/frame/_XUIControllerRegistration.java
+++ b/qadevOOo/tests/java/ifc/frame/_XUIControllerRegistration.java
@@ -24,7 +24,7 @@ import lib.MultiMethodTest;
 public class _XUIControllerRegistration extends MultiMethodTest {
     public XUIControllerRegistration oObj = null;
     private String aRegisteredController = null;
-    private final String aController = ".uno:MySecondController";
+    private static final String aController = ".uno:MySecondController";
 
     @Override
     public void before() {
diff --git a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
index 3506d2a894d4..43724fd84f9c 100644
--- a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
+++ b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
@@ -50,7 +50,7 @@ public class _XSingleSelectQueryAnalyzer extends MultiMethodTest {
     // oObj filled by MultiMethodTest
     public XSingleSelectQueryAnalyzer oObj = null ;
 
-    private final String queryString = "SELECT * FROM \"biblio\"";
+    private static final String queryString = "SELECT * FROM \"biblio\"";
 
     private XSingleSelectQueryComposer xComposer = null;
 
diff --git a/qadevOOo/tests/java/ifc/sdbc/_XRow.java b/qadevOOo/tests/java/ifc/sdbc/_XRow.java
index dbbad4353a69..70a60b0cf34c 100644
--- a/qadevOOo/tests/java/ifc/sdbc/_XRow.java
+++ b/qadevOOo/tests/java/ifc/sdbc/_XRow.java
@@ -95,7 +95,7 @@ public class _XRow extends MultiMethodTest {
     // oObj filled by MultiMethodTest
     public XRow oObj = null ;
     private List<Object> data = null ;
-    private final boolean notNullRes = true;
+    private static final boolean notNullRes = true;
 
     /**
     * Retrieves object relation first.
diff --git a/qadevOOo/tests/java/ifc/ui/_XUIConfigurationManager.java b/qadevOOo/tests/java/ifc/ui/_XUIConfigurationManager.java
index 09716e50c738..0c57bc23b374 100644
--- a/qadevOOo/tests/java/ifc/ui/_XUIConfigurationManager.java
+++ b/qadevOOo/tests/java/ifc/ui/_XUIConfigurationManager.java
@@ -35,8 +35,8 @@ import lib.MultiMethodTest;
 public class _XUIConfigurationManager extends MultiMethodTest {
 
     public XUIConfigurationManager oObj;
-    private final String msResourceUrl = "private:resource/menubar/menubar";
-    private final String msMyResourceUrl = "private:resource/menubar/mymenubar";
+    private static final String msResourceUrl = "private:resource/menubar/menubar";
+    private static final String msMyResourceUrl = "private:resource/menubar/mymenubar";
     private XIndexContainer mxSettings = null;
     private XIndexAccess mxMenuBarSettings = null;
     private XMultiServiceFactory mxMSF = null;
diff --git a/qadevOOo/tests/java/ifc/ui/dialogs/_XFilePicker.java b/qadevOOo/tests/java/ifc/ui/dialogs/_XFilePicker.java
index d5fed39c900f..afc5ad8581eb 100644
--- a/qadevOOo/tests/java/ifc/ui/dialogs/_XFilePicker.java
+++ b/qadevOOo/tests/java/ifc/ui/dialogs/_XFilePicker.java
@@ -43,7 +43,7 @@ public class _XFilePicker extends MultiMethodTest {
 
     public XFilePicker oObj = null;
     private String dir = null ;
-    private final String fname = "space-metal.jpg" ;
+    private static final String fname = "space-metal.jpg" ;
 
     /**
     * Sets the current directory to the test document directory. <p>
diff --git a/qadevOOo/tests/java/ifc/util/_XReplaceable.java b/qadevOOo/tests/java/ifc/util/_XReplaceable.java
index c1634a7763ca..98c9e4fb1e03 100644
--- a/qadevOOo/tests/java/ifc/util/_XReplaceable.java
+++ b/qadevOOo/tests/java/ifc/util/_XReplaceable.java
@@ -45,7 +45,7 @@ public class _XReplaceable extends MultiMethodTest {
     public XReplaceable oObj = null;
     public XReplaceDescriptor Rdesc = null;
     private String mSearchString = "xTextDoc";
-    private final String mReplaceString = "** xTextDoc";
+    private static final String mReplaceString = "** xTextDoc";
     private boolean mDispose = false;
 
     /**
diff --git a/qadevOOo/tests/java/mod/_remotebridge/uno/various.java b/qadevOOo/tests/java/mod/_remotebridge/uno/various.java
index 438fcbba83cb..7c132745cd9d 100644
--- a/qadevOOo/tests/java/mod/_remotebridge/uno/various.java
+++ b/qadevOOo/tests/java/mod/_remotebridge/uno/various.java
@@ -66,7 +66,7 @@ public class various extends TestCase {
     * which is free.
     */
     protected static final int basePort = 50000;
-    private final int curPort = 50000;
+    private static final int curPort = 50000;
 
     private XAcceptor xAcctr;
     private XConnector xCntr;
diff --git a/qadevOOo/tests/java/mod/_remotebridge/various.java b/qadevOOo/tests/java/mod/_remotebridge/various.java
index cccbe77d7de5..0bd2b95e7107 100644
--- a/qadevOOo/tests/java/mod/_remotebridge/various.java
+++ b/qadevOOo/tests/java/mod/_remotebridge/various.java
@@ -67,7 +67,7 @@ public class various extends TestCase {
     * which is free.
     */
     protected static final int basePort = 50000;
-    private final int curPort = 50000;
+    private static final int curPort = 50000;
 
     private XAcceptor xAcctr;
     private XConnector xCntr;
diff --git a/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupItemObj.java b/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupItemObj.java
index 2467ee34b6a1..5a58ab6a6730 100644
--- a/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupItemObj.java
+++ b/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupItemObj.java
@@ -56,7 +56,7 @@ public class ScDataPilotFieldGroupItemObj extends TestCase
      * A field is filled some values. This integer determines the size of the
      * field in x and y direction.
      */
-    private final int mMaxFieldIndex = 6;
+    private static final int mMaxFieldIndex = 6;
 
     /**
      * Creates Spreadsheet document.
diff --git a/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupObj.java b/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupObj.java
index af23d1e24d15..148f81aa71ce 100644
--- a/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupObj.java
+++ b/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupObj.java
@@ -55,7 +55,7 @@ public class ScDataPilotFieldGroupObj extends TestCase
      * A field is filled some values. This integer determines the size of the
      * field in x and y direction.
      */
-    private final int mMaxFieldIndex = 6;
+    private static final int mMaxFieldIndex = 6;
 
     /**
      * Creates Spreadsheet document.
diff --git a/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupsObj.java b/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupsObj.java
index 5aa809eb50b1..da08d525ef62 100644
--- a/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupsObj.java
+++ b/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldGroupsObj.java
@@ -55,7 +55,7 @@ public class ScDataPilotFieldGroupsObj extends TestCase
      * A field is filled some values. This integer determines the size of the
      * field in x and y direction.
      */
-    private final int mMaxFieldIndex = 6;
+    private static final int mMaxFieldIndex = 6;
 
     /**
      * Creates Spreadsheet document.
diff --git a/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldObj.java b/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldObj.java
index 01d49050ef25..89164816c6c0 100644
--- a/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldObj.java
+++ b/qadevOOo/tests/java/mod/_sc/ScDataPilotFieldObj.java
@@ -69,7 +69,7 @@ public class ScDataPilotFieldObj extends TestCase {
      * A field is filled some values. This integer determines the size of the
      * field in x and y direction.
      */
-    private final int mMaxFieldIndex = 6;
+    private static final int mMaxFieldIndex = 6;
 
     /**
     * Creates Spreadsheet document.
diff --git a/qadevOOo/tests/java/mod/_sc/ScDataPilotItemObj.java b/qadevOOo/tests/java/mod/_sc/ScDataPilotItemObj.java
index 2c6e029fb729..1d29fede2287 100644
--- a/qadevOOo/tests/java/mod/_sc/ScDataPilotItemObj.java
+++ b/qadevOOo/tests/java/mod/_sc/ScDataPilotItemObj.java
@@ -70,7 +70,7 @@ public class ScDataPilotItemObj extends TestCase {
      * A field is filled some values. This integer determines the size of the
      * field in x and y direction.
      */
-    private final int mMaxFieldIndex = 6;
+    private static final int mMaxFieldIndex = 6;
 
     /**
     * Creates Spreadsheet document.
diff --git a/qadevOOo/tests/java/mod/_sc/ScDataPilotItemsObj.java b/qadevOOo/tests/java/mod/_sc/ScDataPilotItemsObj.java
index 9baca8760aaf..3c4708a60cdf 100644
--- a/qadevOOo/tests/java/mod/_sc/ScDataPilotItemsObj.java
+++ b/qadevOOo/tests/java/mod/_sc/ScDataPilotItemsObj.java
@@ -70,7 +70,7 @@ public class ScDataPilotItemsObj extends TestCase {
      * A field is filled some values. This integer determines the size of the
      * field in x and y direction.
      */
-    private final int mMaxFieldIndex = 6;
+    private static final int mMaxFieldIndex = 6;
 
     /**
     * Creates Spreadsheet document.
diff --git a/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotItemsEnumeration.java b/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotItemsEnumeration.java
index ffc09302a435..f190da8f9ea0 100644
--- a/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotItemsEnumeration.java
+++ b/qadevOOo/tests/java/mod/_sc/ScIndexEnumeration_DataPilotItemsEnumeration.java
@@ -72,7 +72,7 @@ public class ScIndexEnumeration_DataPilotItemsEnumeration
      * A field is filled some values. This integer determines the size of the
      * field in x and y direction.
      */
-    private final int mMaxFieldIndex = 6;
+    private static final int mMaxFieldIndex = 6;
 
     /**
     * Creates Spreadsheet document.