Find places where OUString and OString are passed by value.

It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361

1 files changed, 2 insertions, 2 deletions

diff --git a/pyuno/source/module/pyuno_module.cxx b/pyuno/source/module/pyuno_module.cxx
index 5513f0e051ce..47b57aa694c0 100644
--- a/pyuno/source/module/pyuno_module.cxx
+++ b/pyuno/source/module/pyuno_module.cxx
@@ -106,7 +106,7 @@ public:
     {
         PyDict_SetItem(used, key, Py_True);
     }
-    void setInitialised(OUString key, sal_Int32 pos = -1)
+    void setInitialised(const OUString& key, sal_Int32 pos = -1)
     {
         if (initialised[key])
         {
@@ -126,7 +126,7 @@ public:
         if ( pos >= 0 )
             ++nPosConsumed;
     }
-    bool isInitialised(OUString key)
+    bool isInitialised(const OUString& key)
     {
         return initialised[key];
     }