diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-08-20 11:15:17 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-08-20 13:59:25 +0200 |
| commit | 316b07d0af06948c69c1375c67c01903b8eeb134 (patch) | |
| tree | d51f01c2f443c82de5a078b90f189af787308ccf /package | |
| parent | ff6e8c73adef7c86db12287948025954a4fc7746 (diff) | |
loplugin:constvars in package..sc
Change-Id: Ibaa9ebd6440d9229ba313f4c130f5752d432b338
Reviewed-on: https://gerrit.libreoffice.org/77792
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'package')
| -rw-r--r-- | package/source/xstor/xstorage.cxx | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/package/source/xstor/xstorage.cxx b/package/source/xstor/xstorage.cxx index fb5ad128dd41..16ae4a9331e0 100644 --- a/package/source/xstor/xstorage.cxx +++ b/package/source/xstor/xstorage.cxx @@ -322,7 +322,7 @@ OStorage_Impl::~OStorage_Impl() m_pParent = nullptr; } - for (auto & pair : m_aChildrenMap) + for (const auto & pair : m_aChildrenMap) for (auto pElement : pair.second) delete pElement; m_aChildrenMap.clear(); @@ -654,7 +654,7 @@ void OStorage_Impl::CopyToStorage( const uno::Reference< embed::XStorage >& xDes if ( !m_xPackageFolder.is() ) throw embed::InvalidStorageException( THROW_WHERE ); - for ( auto& pair : m_aChildrenMap ) + for ( const auto& pair : m_aChildrenMap ) for (auto pElement : pair.second) { if ( !pElement->m_bIsRemoved ) @@ -1054,7 +1054,7 @@ void OStorage_Impl::Commit() // there should be no more deleted elements - for ( auto& pair : m_aChildrenMap ) + for ( const auto& pair : m_aChildrenMap ) for (auto pElement : pair.second) { // if it is a 'duplicate commit' inserted elements must be really inserted to package later @@ -1127,7 +1127,7 @@ void OStorage_Impl::Commit() } } - for ( auto& pair : m_aChildrenMap ) + for ( const auto& pair : m_aChildrenMap ) for (auto pElement : pair.second) { // now inserted elements can be inserted to the package @@ -1228,7 +1228,7 @@ void OStorage_Impl::Revert() std::unordered_map<OUString, std::vector<SotElement_Impl*>> oldMap; std::swap(oldMap, m_aChildrenMap); - for (auto & rPair : oldMap) + for (const auto & rPair : oldMap) for (auto pElement : rPair.second) { if ( pElement->m_bIsInserted ) @@ -1855,7 +1855,7 @@ void OStorage::InternalDispose( bool bNotifyImpl ) // deregister m_pData->m_pSubElDispListener and dispose all of them if ( !m_pData->m_aOpenSubComponentsVector.empty() ) { - for ( auto& pComp : m_pData->m_aOpenSubComponentsVector ) + for ( const auto& pComp : m_pData->m_aOpenSubComponentsVector ) { uno::Reference< lang::XComponent > xTmp = pComp; if ( xTmp.is() ) @@ -2399,7 +2399,7 @@ uno::Reference< embed::XStorage > SAL_CALL OStorage::openStorageElement( if ( nStorageMode & embed::ElementModes::TRUNCATE ) { - for (auto & rPair : pElement->m_xStorage->m_aChildrenMap) + for (const auto & rPair : pElement->m_xStorage->m_aChildrenMap) for (auto pElementToDel : rPair.second) m_pImpl->RemoveElement( /*aName*/rPair.first, pElementToDel ); } @@ -3633,7 +3633,7 @@ void SAL_CALL OStorage::revert() throw lang::DisposedException(THROW_WHERE); } - for (auto & rPair : m_pImpl->m_aChildrenMap) + for (const auto & rPair : m_pImpl->m_aChildrenMap) for (auto pElement : rPair.second) { bool bThrow = (pElement->m_xStorage |