diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2013-06-10 15:49:28 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2013-06-10 15:58:09 +0200 |
| commit | d257209a5443e27cefc8872151d776767605cbae (patch) | |
| tree | 5ddfd23658c0f32bb80c58da5c276391bee5cbde /openssl | |
| parent | 9734135dc8ea3458972b9408d1732d4a49843f14 (diff) | |
Revert "fix gold warning about hidden symbols"
This reverts commit 9ff0ee4905068cbc85acf85da1b3ef762b324ed7. Whatever the gold
warnings are exactly, this is apparently not the right fix.
The change to openssl/ExternalProject_openssl.mk caused crashes when LO's
libneon.so, statically linking in LO's libssl.a, started to export symbols like
SSLv23_client_method as global, competing with the same symbol from a system's
libssl.so. See the mail thread starting at
<http://lists.freedesktop.org/archives/libreoffice/2013-June/053119.html>
"strange crash in SSL code while opening some documents."
Whether the change to expat/StaticLibrary_expat.mk caused similar problems is
not clear to me, but it is probably best to revert both to be on the save side,
and see what exactly the gold warning was about and how to fix it the right way
if it ever shows up again.
Diffstat (limited to 'openssl')
| -rw-r--r-- | openssl/ExternalProject_openssl.mk | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/openssl/ExternalProject_openssl.mk b/openssl/ExternalProject_openssl.mk index 87397fe9715c..ed99fe5013c4 100644 --- a/openssl/ExternalProject_openssl.mk +++ b/openssl/ExternalProject_openssl.mk @@ -85,6 +85,9 @@ $(call gb_ExternalProject_get_state_target,openssl,build): $(if $(SYSBASE),-I$(SYSBASE)/usr/include -L$(SYSBASE)/usr/lib)))) \ $(if $(filter MACOSX,$(OS)),--prefix=/@.__________________________________________________OOO) \ && $(MAKE) build_libs \ + CC="$(CC) $(if $(filter-out WNT,$(OS)),\ + $(if $(filter TRUE,$(HAVE_GCC_VISIBILITY_FEATURE)),\ + -fvisibility=hidden))" \ ) endif # vim: set noet sw=4 ts=4: |