diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-04-23 16:07:32 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-04-27 14:07:56 +0200 |
| commit | c7c6f0af6c836ebe0968967a1e7c8320b0ac17d6 (patch) | |
| tree | 4bc5b2fa623b9765b88bbfe7de10a7590c87d5c8 /oox | |
| parent | 99482297c7dd497e41fad2e7193759043e305101 (diff) | |
loplugin:stringadd convert chained append to +
which can use the more efficient *StringConcat
Also fix a crash in stringview plugin which
started happening while I working on this.
Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'oox')
| -rw-r--r-- | oox/source/core/xmlfilterbase.cxx | 2 | ||||
| -rw-r--r-- | oox/source/dump/dumperbase.cxx | 2 | ||||
| -rw-r--r-- | oox/source/export/drawingml.cxx | 3 | ||||
| -rw-r--r-- | oox/source/export/vmlexport.cxx | 12 | ||||
| -rw-r--r-- | oox/source/ole/vbamodule.cxx | 3 |
5 files changed, 7 insertions, 15 deletions
diff --git a/oox/source/core/xmlfilterbase.cxx b/oox/source/core/xmlfilterbase.cxx index bb63873f5540..b46392d1a246 100644 --- a/oox/source/core/xmlfilterbase.cxx +++ b/oox/source/core/xmlfilterbase.cxx @@ -602,7 +602,7 @@ writeElement( const FSHelperPtr& pDoc, sal_Int32 nXmlElement, const Sequence< OU for( const OUString& rItem : aItems ) { - sRep.append( " " ).append( rItem ); + sRep.append( " " + rItem ); } writeElement( pDoc, nXmlElement, sRep.makeStringAndClear() ); diff --git a/oox/source/dump/dumperbase.cxx b/oox/source/dump/dumperbase.cxx index b73c24accef0..1638d51a6964 100644 --- a/oox/source/dump/dumperbase.cxx +++ b/oox/source/dump/dumperbase.cxx @@ -2409,7 +2409,7 @@ void XmlStreamObject::implDumpText( TextInputStream& rTextStrm ) matching end element on the same line in the next iteration. */ if( bStartElem ) { - aOldStartElem.append( aElem ).append( aText ); + aOldStartElem.append( aElem + aText ); } else { diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index c6c81a9bec3c..dfb81a27e713 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -4735,8 +4735,7 @@ OString DrawingML::WriteWdpPicture( const OUString& rFileId, const Sequence< sal OUString sFileName = "media/hdphoto" + OUString::number( mnWdpImageCounter++ ) + ".wdp"; Reference< XOutputStream > xOutStream = mpFB->openFragmentStream( OUStringBuffer() .appendAscii( GetComponentDir() ) - .append( "/" ) - .append( sFileName ) + .append( "/" + sFileName ) .makeStringAndClear(), "image/vnd.ms-photo" ); OUString sId; diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx index 36d35a7ed18b..0506041e67d5 100644 --- a/oox/source/export/vmlexport.cxx +++ b/oox/source/export/vmlexport.cxx @@ -1120,15 +1120,9 @@ void VMLExport::AddLineDimensions( const tools::Rectangle& rRectangle ) aBottom = OString::number( rRectangle.Bottom() ); } - m_pShapeAttrList->add( XML_from, - OStringBuffer( 20 ).append( aLeft ) - .append( "," ).append( aTop ) - .makeStringAndClear() ); - - m_pShapeAttrList->add( XML_to, - OStringBuffer( 20 ).append( aRight ) - .append( "," ).append( aBottom ) - .makeStringAndClear() ); + m_pShapeAttrList->add( XML_from, aLeft + "," + aTop ); + + m_pShapeAttrList->add( XML_to, aRight + "," + aBottom ); } void VMLExport::AddRectangleDimensions( OStringBuffer& rBuffer, const tools::Rectangle& rRectangle, bool rbAbsolutePos) diff --git a/oox/source/ole/vbamodule.cxx b/oox/source/ole/vbamodule.cxx index 47c676cdc086..ade0bd97aeae 100644 --- a/oox/source/ole/vbamodule.cxx +++ b/oox/source/ole/vbamodule.cxx @@ -301,8 +301,7 @@ void VbaModule::createModule( std::u16string_view rVBASourceCode, else { // add a subroutine named after the module itself - aSourceCode.append( "Sub " ). - append( maName.replace( ' ', '_' ) ).append( '\n' ); + aSourceCode.append( "Sub " + maName.replace( ' ', '_' ) + "\n" ); } // append passed VBA source code |