summaryrefslogtreecommitdiff
path: root/oox
diff options
context:
space:
mode:
authorJustin Luth <justin_luth@sil.org>2018-07-09 18:30:52 +0300
committerMiklos Vajna <vmiklos@collabora.co.uk>2018-07-19 13:43:32 +0200
commitd3ecf6070b439e902343a2a83bc9384382e41fee (patch)
treedfbca0b68f9739a6ef58608d0833f00b8a2760c6 /oox
parent5e5e49eba37c15b17a4d9788da91415abbca4eb1 (diff)
related tdf#106174 writerfilter: replace broken FindParentStyleSheet
FindParentStyleSheet didn't do anything right. An empty stylename was supposed to check currentEntry, but instead it just returned null. The passed stylename was completely ignored if there was a currentEntry. And on top of that, the stylename itself was returned, not its parent. Even worse, the currentEntry properties were ignored because in that case it DID return the parent. Even the comments were totally bogus. Amazing... GetPropertyFromStyleSheet() has the potential for LOTS of use in writerfilter. I'm surprised it has hardly been used. Perhaps the completely wrong results led people to ignore it rather than investigate why it didn't give the expected results. Change-Id: I89a6b02877ab7990aa4eb58e5e0b6a572f3d10e3 Reviewed-on: https://gerrit.libreoffice.org/57195 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit bc67bda7363df48f1983513a8e969b61738139f5) Reviewed-on: https://gerrit.libreoffice.org/57483
Diffstat (limited to 'oox')
0 files changed, 0 insertions, 0 deletions