diff options
author | Miklos Vajna <vmiklos@collabora.com> | 2024-04-23 08:29:07 +0200 |
---|---|---|
committer | Miklos Vajna <vmiklos@collabora.com> | 2024-04-23 09:48:01 +0200 |
commit | f9f2b7590bb7b3334d499b6884cc7f3e80843b8c (patch) | |
tree | d401a1a8e22cd970bdc530366e41c0f4f7fb5f66 /oox/source/drawingml/fillproperties.cxx | |
parent | fd2aaac24712550e4bbd349575192edb56bc94c9 (diff) |
tdf#159379 sw: fix crash on dropping multiple as-char imagesHEADmaster
Have an empty Writer document, set preferences so images created via
drag&drop are anchored as-char, drop 2 images from a file manager,
crash.
The root of the problem is that the first image gets dropped fine, but
the second one would be anchored to the currently selected graphic node,
since commit 651527b4efe9700c8c8dff58ce5aa86ad5681f16 (sw: fix
double-click opening frame dialog, not graphic dialog on images,
2022-04-26).
The new SwTextCursor::GetModelPositionForViewPoint() returning a graphic
node for a point inside the image looks correct, so fix the problem by
extending SwFEShell::Insert() to take the anchor position as the anchor
for the new image, in case a graphic node is selected.
The original use-case would use SwEditWin::ExecuteDrop(), but keep the
test simple and invoke the underlying SwFEShell::Insert() instead, that
also triggers the problem.
Change-Id: Ibba57aa28d0616ded16b4abb314f04974f1b8f9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166499
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'oox/source/drawingml/fillproperties.cxx')
0 files changed, 0 insertions, 0 deletions