diff options
| author | Michael Stahl <michael.stahl@allotropia.de> | 2021-08-12 13:04:54 +0200 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2022-05-25 09:27:15 +0200 |
| commit | 16ad0a66321530b185138af3a5b01b38c572e396 (patch) | |
| tree | 12b0706eb33dc21ac342ac52a49717f801541952 /m4 | |
| parent | a8a32dde08753e03af53e21e4cf5d1e7a3fcc869 (diff) | |
tdf#147250 configure: default to --with-system-nss on Linux
NSS is very ABI compatible and part of current LSB 5.0 and so it should
just work to use the one from the system, i'm not aware of a Linux that
doesn't ship it.
There used to be some feature patch in external/nss but this was removed
years ago, now it just contains build fixes.
Problems can occur if a mixture of system and bundled NSS libraries is
loaded, if first an old version .so is loaded and then newer version .so
depends on it but can't find some required symbol.
See for example:
https://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg287043.html
Another issue is that e.g. Fedora ships libnsspem.so in the nss-pem
package, which may cause trouble in ASAN builds, where the internal NSS
is built to call __asan_poison_memory_region but the system
libnss-pem.so doesn't call __asan_unpoison_memory_region so we get:
==2568944==ERROR: AddressSanitizer: use-after-poison on address 0x61d0019afab0
WRITE of size 192 at 0x61d0019afab0 thread T28 (utl::Moderator)
0 in __interceptor_memset.part.0 (instdir/program/soffice.bin+0x466460)
1 (/lib64/libnsspem.so+0x15f3d)
2 (/lib64/libnsspem.so+0x16185)
3 (/lib64/libnsspem.so+0x8a9b)
4 (/lib64/libnsspem.so+0xe13b)
5 in secmod_ModuleInit workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11
..
21 in curl_easy_perform workdir/UnpackedTarball/curl/lib/easy.c:715:10
Also, with system NSS, things like p11-kit integration become
responsibility of the OS.
Change-Id: I50caedd46914dd5d6905c5d32d44a599cd78119e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120388
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 0028266e34a683b1650410cee65dac502e304c9f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134293
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'm4')
| -rw-r--r-- | m4/libo_externals.m4 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/m4/libo_externals.m4 b/m4/libo_externals.m4 index f755358bb395..659b539dc539 100644 --- a/m4/libo_externals.m4 +++ b/m4/libo_externals.m4 @@ -10,7 +10,7 @@ AC_DEFUN([libo_CHECK_SYSTEM_MODULE], [ AC_ARG_WITH(system-$1, AS_HELP_STRING([--with-system-$1], [Use $1 from operating system instead of building and bundling it.]),, - [with_system_$1="$with_system_libs"]) + ifelse([$6],,[with_system_$1="$with_system_libs"],[[$6]])) AC_MSG_CHECKING([which $1 to use]) if test "$with_system_$1" = "yes"; then AC_MSG_RESULT([external]) |