clang-tidy modernize-pass-by-value in lotuswordpro

Change-Id: Ia20d653bdfedf49430f8ba46c8200c2b96734d81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136336
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

11 files changed, 27 insertions, 19 deletions

diff --git a/lotuswordpro/inc/xfilter/xfstylecont.hxx b/lotuswordpro/inc/xfilter/xfstylecont.hxx
index f2617eefa3c8..8277cd2a5494 100644
--- a/lotuswordpro/inc/xfilter/xfstylecont.hxx
+++ b/lotuswordpro/inc/xfilter/xfstylecont.hxx
@@ -86,7 +86,7 @@ class XFStyleContainer
 public:
     XFStyleContainer() {}
 
-    explicit XFStyleContainer(const OUString& strStyleNamePrefix);
+    explicit XFStyleContainer(OUString strStyleNamePrefix);
 
     XFStyleContainer(const XFStyleContainer& other) = delete;
 
diff --git a/lotuswordpro/inc/xfilter/xftextcontent.hxx b/lotuswordpro/inc/xfilter/xftextcontent.hxx
index dca2c69c2b99..226e66800df1 100644
--- a/lotuswordpro/inc/xfilter/xftextcontent.hxx
+++ b/lotuswordpro/inc/xfilter/xftextcontent.hxx
@@ -70,7 +70,7 @@ class XFTextContent : public XFContent
 public:
     XFTextContent() {}
 
-    explicit XFTextContent(const OUString& text);
+    explicit XFTextContent(OUString text);
 
     virtual ~XFTextContent() override;
 
diff --git a/lotuswordpro/source/filter/LotusWordProImportFilter.cxx b/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
index 296561bcc375..d85e8c700d92 100644
--- a/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
+++ b/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
@@ -41,6 +41,7 @@
 #include <cppuhelper/weak.hxx>
 
 #include <osl/file.hxx>
+#include <utility>
 #endif
 
 using namespace com::sun::star;
@@ -61,9 +62,9 @@ namespace
 class DebugDocumentHandler final : public cppu::WeakImplHelper< XDocumentHandler >
 {
 public:
-    DebugDocumentHandler(const uno::Reference< XDocumentHandler >& handler, const uno::Reference< XDocumentHandler >& debug)
-        : m_handler(handler)
-        , m_debug(debug)
+    DebugDocumentHandler(uno::Reference< XDocumentHandler > handler, uno::Reference< XDocumentHandler > debug)
+        : m_handler(std::move(handler))
+        , m_debug(std::move(debug))
     {
     }
 
diff --git a/lotuswordpro/source/filter/LotusWordProImportFilter.hxx b/lotuswordpro/source/filter/LotusWordProImportFilter.hxx
index e0843e04011e..7ba997897923 100644
--- a/lotuswordpro/source/filter/LotusWordProImportFilter.hxx
+++ b/lotuswordpro/source/filter/LotusWordProImportFilter.hxx
@@ -27,6 +27,7 @@
 #include <com/sun/star/lang/XInitialization.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
 #include <cppuhelper/implbase.hxx>
+#include <utility>
 
 /* This component will be instantiated for both import or export. Whether it calls
  * setSourceDocument or setTargetDocument determines which Impl function the filter
@@ -48,8 +49,8 @@ class LotusWordProImportFilter final : public cppu::WeakImplHelper
     bool importImpl( const css::uno::Sequence< css::beans::PropertyValue >& aDescriptor );
 
 public:
-    explicit LotusWordProImportFilter( const css::uno::Reference< css::uno::XComponentContext > &rxContext)
-        : mxContext( rxContext )
+    explicit LotusWordProImportFilter( css::uno::Reference< css::uno::XComponentContext > xContext)
+        : mxContext(std::move( xContext ))
     {
     }
 
diff --git a/lotuswordpro/source/filter/benname.cxx b/lotuswordpro/source/filter/benname.cxx
index d65799ce203c..5e5a3ddb1331 100644
--- a/lotuswordpro/source/filter/benname.cxx
+++ b/lotuswordpro/source/filter/benname.cxx
@@ -53,16 +53,18 @@
  *
  *
  ************************************************************************/
+#include <utility>
+
 #include "bento.hxx"
 
 namespace OpenStormBento
 {
 // changed to remove warning
 CBenNamedObject::CBenNamedObject(LtcBenContainer * pContainer,
-  BenObjectID ObjectID, CUtListElmt * pPrevObject, const OString& rName,
+  BenObjectID ObjectID, CUtListElmt * pPrevObject, OString aName,
   CUtListElmt * pPrevNamedObjectListElmt)
     : CBenObject(pContainer, ObjectID, pPrevObject)
-    , csName(rName)
+    , csName(std::move(aName))
     , cNameListElmt(pPrevNamedObjectListElmt)
 {
     cNameListElmt.SetNamedObject(this);
diff --git a/lotuswordpro/source/filter/bento.hxx b/lotuswordpro/source/filter/bento.hxx
index b506c525af4b..d2c1cb90d703 100644
--- a/lotuswordpro/source/filter/bento.hxx
+++ b/lotuswordpro/source/filter/bento.hxx
@@ -341,7 +341,7 @@ public: // Methods
 
 public: // Internal methods
     CBenNamedObject(LtcBenContainer * pContainer, BenObjectID ObjectID,
-    CUtListElmt * pPrevObject, const OString& rName,
+    CUtListElmt * pPrevObject, OString aName,
     CUtListElmt * pPrevNamedObjectListElmt);
 
     const OString& GetName() const { return csName; }
diff --git a/lotuswordpro/source/filter/lwpnumericfmt.hxx b/lotuswordpro/source/filter/lwpnumericfmt.hxx
index ef1af1da01ec..cc3b8f5d0ee2 100644
--- a/lotuswordpro/source/filter/lwpnumericfmt.hxx
+++ b/lotuswordpro/source/filter/lwpnumericfmt.hxx
@@ -68,6 +68,7 @@
 #include "lwppiece.hxx"
 
 //For converting to xml
+#include <utility>
 #include <xfilter/xfnumberstyle.hxx>
 
 class LwpObjectStream;
@@ -102,15 +103,15 @@ struct LwpCurrencyInfo
     OUString sSymbol;
     bool bPost;
     bool bShowSpace;
-    explicit LwpCurrencyInfo(const OUString& sSym)
-      : sSymbol(sSym), bPost(false), bShowSpace(false)
+    explicit LwpCurrencyInfo(OUString sSym)
+      : sSymbol(std::move(sSym)), bPost(false), bShowSpace(false)
     {
     }
     LwpCurrencyInfo() : bPost(false), bShowSpace(false)
     {
     }
-    LwpCurrencyInfo(const OUString& sSym, bool bPost_, bool bShowSpace_)
-        : sSymbol(sSym), bPost(bPost_), bShowSpace(bShowSpace_)
+    LwpCurrencyInfo(OUString sSym, bool bPost_, bool bShowSpace_)
+        : sSymbol(std::move(sSym)), bPost(bPost_), bShowSpace(bShowSpace_)
     {
     }
 };
diff --git a/lotuswordpro/source/filter/lwptblformula.cxx b/lotuswordpro/source/filter/lwptblformula.cxx
index bec6bcf7466b..bbd54622250e 100644
--- a/lotuswordpro/source/filter/lwptblformula.cxx
+++ b/lotuswordpro/source/filter/lwptblformula.cxx
@@ -67,6 +67,7 @@
 #include <rtl/ustrbuf.hxx>
 #include <sal/log.hxx>
 #include <memory>
+#include <utility>
 
 LwpFormulaArg::~LwpFormulaArg()
 {
@@ -356,7 +357,7 @@ OUString LwpFormulaConst::ToString(LwpTableLayout* /*pCellsMap*/)
     return OUString::number(m_dVal);
 }
 
-LwpFormulaText::LwpFormulaText( const OUString& aText) : m_aText(aText)
+LwpFormulaText::LwpFormulaText( OUString aText) : m_aText(std::move(aText))
 {
 }
 
diff --git a/lotuswordpro/source/filter/lwptblformula.hxx b/lotuswordpro/source/filter/lwptblformula.hxx
index ee90e1944079..c0ecb3c6f658 100644
--- a/lotuswordpro/source/filter/lwptblformula.hxx
+++ b/lotuswordpro/source/filter/lwptblformula.hxx
@@ -133,7 +133,7 @@ private:
 class LwpFormulaText:public LwpFormulaArg
 {
 public:
-    explicit LwpFormulaText( const OUString& aText);
+    explicit LwpFormulaText( OUString aText);
     virtual OUString ToString(LwpTableLayout* /*pCellsMap*/) override {return m_aText;}
 private:
     OUString m_aText;
diff --git a/lotuswordpro/source/filter/xfilter/xfstylecont.cxx b/lotuswordpro/source/filter/xfilter/xfstylecont.cxx
index c9bcfc3c8c97..75286db55327 100644
--- a/lotuswordpro/source/filter/xfilter/xfstylecont.cxx
+++ b/lotuswordpro/source/filter/xfilter/xfstylecont.cxx
@@ -57,6 +57,7 @@
  * @file
  * Font object to serial to xml filter.
  ************************************************************************/
+#include <utility>
 #include <xfilter/xfstylecont.hxx>
 #include <xfilter/ixfstyle.hxx>
 #include <xfilter/xffont.hxx>
@@ -65,8 +66,8 @@
 #include <xfilter/xffontfactory.hxx>
 #include <lwpglobalmgr.hxx>
 
-XFStyleContainer::XFStyleContainer(const OUString& strStyleNamePrefix)
-    :m_strStyleNamePrefix(strStyleNamePrefix)
+XFStyleContainer::XFStyleContainer(OUString strStyleNamePrefix)
+    :m_strStyleNamePrefix(std::move(strStyleNamePrefix))
 {
 }
 
diff --git a/lotuswordpro/source/filter/xfilter/xftextcontent.cxx b/lotuswordpro/source/filter/xfilter/xftextcontent.cxx
index 945b2411459b..79d10ee5b56f 100644
--- a/lotuswordpro/source/filter/xfilter/xftextcontent.cxx
+++ b/lotuswordpro/source/filter/xfilter/xftextcontent.cxx
@@ -54,11 +54,12 @@
  *
  ************************************************************************/
 
+#include <utility>
 #include <xfilter/xftextcontent.hxx>
 #include <xfilter/ixfattrlist.hxx>
 #include <xfilter/ixfstream.hxx>
 
-XFTextContent::XFTextContent(const OUString& text):m_strText(text)
+XFTextContent::XFTextContent(OUString text):m_strText(std::move(text))
 {
 }