diff options
| author | Noel Grandin <noel@peralex.com> | 2014-03-06 15:29:08 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-03-18 08:32:26 +0200 |
| commit | 86a32589e90ee983159fb5b2c6a594428ab7d422 (patch) | |
| tree | 6de946fe2b9b25614f0d197af95e9d3aadcd1bd9 /linguistic | |
| parent | bb17844099ba98a77c8e5d7a25c0c416a4b0641e (diff) | |
Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
Diffstat (limited to 'linguistic')
| -rw-r--r-- | linguistic/source/convdicxml.hxx | 4 | ||||
| -rw-r--r-- | linguistic/source/hyphdsp.cxx | 2 | ||||
| -rw-r--r-- | linguistic/source/hyphdsp.hxx | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/linguistic/source/convdicxml.hxx b/linguistic/source/convdicxml.hxx index a11a50e75982..de5fada1466e 100644 --- a/linguistic/source/convdicxml.hxx +++ b/linguistic/source/convdicxml.hxx @@ -76,14 +76,14 @@ class ConvDicXMLImport : public SvXMLImport // but the language and conversion type will // still be determined! - sal_Int16 nLanguage; // language of the dictionary + sal_Int16 nLanguage; // language of the dictionary sal_Int16 nConversionType; // conversion type the dictionary is used for sal_Bool bSuccess; public: //!! see comment for pDic member - ConvDicXMLImport( ConvDic *pConvDic, const OUString /*&rFileName*/ ) : + ConvDicXMLImport( ConvDic *pConvDic, const OUString& /*&rFileName*/ ) : SvXMLImport ( comphelper::getProcessComponentContext(), "com.sun.star.lingu2.ConvDicXMLImport", IMPORT_ALL ), pDic ( pConvDic ) { diff --git a/linguistic/source/hyphdsp.cxx b/linguistic/source/hyphdsp.cxx index f8770618eac9..3202c7857ea4 100644 --- a/linguistic/source/hyphdsp.cxx +++ b/linguistic/source/hyphdsp.cxx @@ -65,7 +65,7 @@ void HyphenatorDispatcher::ClearSvcList() Reference<XHyphenatedWord> HyphenatorDispatcher::buildHyphWord( - const OUString rOrigWord, + const OUString& rOrigWord, const Reference<XDictionaryEntry> &xEntry, sal_Int16 nLang, sal_Int16 nMaxLeading ) { diff --git a/linguistic/source/hyphdsp.hxx b/linguistic/source/hyphdsp.hxx index fdcfcbf0bc5a..4b6fdd6afec6 100644 --- a/linguistic/source/hyphdsp.hxx +++ b/linguistic/source/hyphdsp.hxx @@ -75,7 +75,7 @@ class HyphenatorDispatcher : com::sun::star::uno::Reference< ::com::sun::star::linguistic2::XHyphenatedWord> - buildHyphWord( const OUString rOrigWord, + buildHyphWord( const OUString& rOrigWord, const ::com::sun::star::uno::Reference< ::com::sun::star::linguistic2::XDictionaryEntry> &xEntry, sal_Int16 nLang, sal_Int16 nMaxLeading ); |