summaryrefslogtreecommitdiff
path: root/jvmfwk
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2015-11-24 10:09:57 +0000
committerCaolán McNamara <caolanm@redhat.com>2015-11-24 10:35:44 +0000
commit70b09d932225027d531c9a95317320174f8ad687 (patch)
treeec36c7d4927721c59d22830385517770e820d98b /jvmfwk
parentcbc5dc14d6bb795a9c2b54d624b10770a2a95a00 (diff)
cppcheck: noExplicitConstructor
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
Diffstat (limited to 'jvmfwk')
-rw-r--r--jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx4
-rw-r--r--jvmfwk/plugins/sunmajor/pluginlib/util.cxx6
-rw-r--r--jvmfwk/plugins/sunmajor/pluginlib/util.hxx4
-rw-r--r--jvmfwk/source/libxmlutil.hxx8
4 files changed, 11 insertions, 11 deletions
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx
index de65fac0091e..7bda1f920b50 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunversion.hxx
@@ -82,8 +82,8 @@ protected:
PreRelease m_preRelease;
public:
- SunVersion(const char * szVer);
- SunVersion(const OUString& usVer);
+ explicit SunVersion(const char * szVer);
+ explicit SunVersion(const OUString& usVer);
~SunVersion();
/**
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
index b9ec44367588..f16f96fdf098 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
@@ -222,7 +222,7 @@ rtl::Bootstrap * getBootstrap()
class FileHandleGuard: private boost::noncopyable
{
public:
- inline FileHandleGuard(oslFileHandle & rHandle):
+ explicit FileHandleGuard(oslFileHandle & rHandle):
m_rHandle(rHandle) {}
inline ~FileHandleGuard();
@@ -255,7 +255,7 @@ public:
RESULT_ERROR
};
- inline FileHandleReader(oslFileHandle & rHandle):
+ explicit FileHandleReader(oslFileHandle & rHandle):
m_aGuard(rHandle), m_nSize(0), m_nIndex(0), m_bLf(false) {}
Result readLine(OString * pLine);
@@ -339,7 +339,7 @@ class AsynchReader: public salhelper::Thread
void execute() override;
public:
- AsynchReader(oslFileHandle & rHandle);
+ explicit AsynchReader(oslFileHandle & rHandle);
/** only call this function after this thread has finished.
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.hxx b/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
index 456cfd754adc..74497337be90 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
@@ -65,7 +65,7 @@ bool makeDriveLetterSame(OUString * fileURL);
struct InfoFindSame
{
OUString sJava;
- InfoFindSame(const OUString& sJavaHome):sJava(sJavaHome){}
+ explicit InfoFindSame(const OUString& sJavaHome):sJava(sJavaHome){}
bool operator () (const rtl::Reference<VendorBase> & aVendorInfo)
{
@@ -76,7 +76,7 @@ struct InfoFindSame
struct SameOrSubDirJREMap
{
OUString s1;
- SameOrSubDirJREMap(const OUString& s):s1(s){
+ explicit SameOrSubDirJREMap(const OUString& s):s1(s){
}
bool operator () (const std::pair<const OUString, rtl::Reference<VendorBase> > & s2)
diff --git a/jvmfwk/source/libxmlutil.hxx b/jvmfwk/source/libxmlutil.hxx
index c9a8f66c59b7..4affff6c923e 100644
--- a/jvmfwk/source/libxmlutil.hxx
+++ b/jvmfwk/source/libxmlutil.hxx
@@ -49,7 +49,7 @@ class CXPathContextPtr
CXPathContextPtr & operator = (const CXPathContextPtr&) = delete;
public:
CXPathContextPtr();
- CXPathContextPtr(xmlXPathContextPtr aContext);
+ explicit CXPathContextPtr(xmlXPathContextPtr aContext);
CXPathContextPtr & operator = (xmlXPathContextPtr pObj);
~CXPathContextPtr();
xmlXPathContext* operator -> () { return _object;}
@@ -66,7 +66,7 @@ class CXmlDocPtr
public:
CXmlDocPtr & operator = (const CXmlDocPtr&);
CXmlDocPtr();
- CXmlDocPtr(xmlDoc* aDoc);
+ explicit CXmlDocPtr(xmlDoc* aDoc);
/** Takes ownership of xmlDoc
*/
CXmlDocPtr & operator = (xmlDoc* pObj);
@@ -84,8 +84,8 @@ class CXmlCharPtr
CXmlCharPtr & operator = (const CXmlCharPtr&) = delete;
public:
CXmlCharPtr();
- CXmlCharPtr(xmlChar* aDoc);
- CXmlCharPtr(const OUString &);
+ explicit CXmlCharPtr(xmlChar* aDoc);
+ explicit CXmlCharPtr(const OUString &);
~CXmlCharPtr();
CXmlCharPtr & operator = (xmlChar* pObj);
operator xmlChar* () const { return _object;}