summaryrefslogtreecommitdiff
path: root/jvmfwk
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2020-03-06 14:40:40 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2020-03-09 11:33:43 +0100
commitabe39f7781f59b96c5a8d3dd5b41c60fdf04ad84 (patch)
tree0f72d1968e5f25e3f280688a414398e3f4a7cce8 /jvmfwk
parentbdb1c72198f60fdd91460e26282134d43bc0e2df (diff)
improve loplugin:unusedfields
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'jvmfwk')
-rw-r--r--jvmfwk/inc/fwkbase.hxx1
-rw-r--r--jvmfwk/source/fwkbase.cxx6
2 files changed, 3 insertions, 4 deletions
diff --git a/jvmfwk/inc/fwkbase.hxx b/jvmfwk/inc/fwkbase.hxx
index a729f6ad52e4..6428083e20d0 100644
--- a/jvmfwk/inc/fwkbase.hxx
+++ b/jvmfwk/inc/fwkbase.hxx
@@ -33,7 +33,6 @@ struct VersionInfo;
class VendorSettings
{
- OUString m_xmlDocVendorSettingsFileUrl;
CXmlDocPtr m_xmlDocVendorSettings;
CXPathContextPtr m_xmlPathContextVendorSettings;
diff --git a/jvmfwk/source/fwkbase.cxx b/jvmfwk/source/fwkbase.cxx
index a064b93f80be..332d84ebb07b 100644
--- a/jvmfwk/source/fwkbase.cxx
+++ b/jvmfwk/source/fwkbase.cxx
@@ -82,11 +82,11 @@ OUString getParamFirstUrl(OUString const & name)
}//blind namespace
-VendorSettings::VendorSettings():
- m_xmlDocVendorSettingsFileUrl(BootParams::getVendorSettings())
+VendorSettings::VendorSettings()
{
+ OUString xmlDocVendorSettingsFileUrl(BootParams::getVendorSettings());
//Prepare the xml document and context
- OString sSettingsPath = getVendorSettingsPath(m_xmlDocVendorSettingsFileUrl);
+ OString sSettingsPath = getVendorSettingsPath(xmlDocVendorSettingsFileUrl);
if (sSettingsPath.isEmpty())
{
OString sMsg("[Java framework] A vendor settings file was not specified."