diff options
| author | Henry Castro <hcastro@collabora.com> | 2019-12-09 18:49:37 -0400 |
|---|---|---|
| committer | Henry Castro <hcastro@collabora.com> | 2020-05-21 00:32:53 +0200 |
| commit | 279eddb5062dbea9bb9461435ec0a56dbb25c131 (patch) | |
| tree | e59b8fef4874a5e19573006f28876d96d3caa548 /include | |
| parent | 13a65ac084d124fb22aee9f48797fa4f8588cd55 (diff) | |
lok: evaluate assertion if LOK Windows container is empty
It has defined a map container for every LOK windows assigned
a notifier to the client side. However the map container has elements
with VclPtr (reference counter) and it is a global data, so when global
data are disposing, the VclPtr will destroy the Window when the VCL
framework was destroyed that will lead to undefined behavior.
So this commit adds an assert inside DeInitVCL to ensure, if
someone forgot to Release the LOK Notifier.
Change-Id: Ib7f20751af2931f7b0ba3e3d526e734ffc33f171
Reviewed-on: https://gerrit.libreoffice.org/84792
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94504
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/vcl/window.hxx | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx index c0381b8c75c9..f090fef97203 100644 --- a/include/vcl/window.hxx +++ b/include/vcl/window.hxx @@ -1205,6 +1205,9 @@ public: /// Find an existing Window based on the LOKWindowId. static VclPtr<vcl::Window> FindLOKWindow(vcl::LOKWindowId nWindowId); + /// check if LOK Window container is empty + static bool IsLOKWindowsEmpty(); + /// Dumps itself and potentially its children to a property tree, to be written easily to JSON. virtual boost::property_tree::ptree DumpAsPropertyTree(); |