clang-tidy modernize-use-equals-default in svx

SfxPoolItem has a copy constructor and its copy assignment
operator is deleted. Derived classes have a implicit defined
copy constructor too, if all members are copy constructible.

This patch removes default-able copy constructors and destructors
on such items.

Also removing copy constructors of pool item members
SvxClipboardFormatItem_Impl and SvxColumnItem.

Change-Id: Ic0f39c992d1fd7b667cb56134fd7c953681a3131
Reviewed-on: https://gerrit.libreoffice.org/43143
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 0 insertions, 20 deletions

diff --git a/include/svx/algitem.hxx b/include/svx/algitem.hxx
index 00ab5145fec7..797b3be24c86 100644
--- a/include/svx/algitem.hxx
+++ b/include/svx/algitem.hxx
@@ -79,7 +79,6 @@ public:
     SvxMarginItem( sal_Int16 nLeft, sal_Int16 nTop /*= 0*/,
                    sal_Int16 nRight /*= 0*/, sal_Int16 nBottom /*= 0*/,
                    const sal_uInt16 nId  );
-    SvxMarginItem( const SvxMarginItem& );
 
     virtual bool GetPresentation( SfxItemPresentation ePres,
                                   MapUnit eCoreMetric,
diff --git a/include/svx/ofaitem.hxx b/include/svx/ofaitem.hxx
index 49df180d86a2..956588b6b5f8 100644
--- a/include/svx/ofaitem.hxx
+++ b/include/svx/ofaitem.hxx
@@ -32,7 +32,6 @@ private:
 
 public:
                              OfaPtrItem( sal_uInt16 nWhich, void *pPtr );
-                             OfaPtrItem( const OfaPtrItem& );
 
     virtual bool             operator==( const SfxPoolItem& ) const override;
     virtual SfxPoolItem*     Clone( SfxItemPool *pPool = nullptr ) const override;
@@ -51,9 +50,6 @@ public:
     OfaRefItem( sal_uInt16 _nWhich, const rtl::Reference<reference_type> &xRef )
         : SfxPoolItem( _nWhich ), mxRef( xRef )
     {}
-    OfaRefItem( const OfaRefItem& rItem )
-        : SfxPoolItem( rItem.Which() ), mxRef( rItem.mxRef )
-    {}
     virtual bool operator==( const SfxPoolItem& rItem ) const override
     {
         return mxRef == static_cast<OfaRefItem<reference_type> const &>(rItem).mxRef;
diff --git a/include/svx/optgrid.hxx b/include/svx/optgrid.hxx
index 9ca88ff34a10..bd59955cee05 100644
--- a/include/svx/optgrid.hxx
+++ b/include/svx/optgrid.hxx
@@ -79,7 +79,6 @@ class SVX_DLLPUBLIC SvxGridItem : public SvxOptionsGrid, public SfxPoolItem
 
 public:
     SvxGridItem( sal_uInt16 _nWhich) : SfxPoolItem(_nWhich){};
-    SvxGridItem( const SvxGridItem& pTestItem );
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool            operator==( const SfxPoolItem& ) const override;
diff --git a/include/svx/rulritem.hxx b/include/svx/rulritem.hxx
index d35e0f23731a..4ce3bedfcebb 100644
--- a/include/svx/rulritem.hxx
+++ b/include/svx/rulritem.hxx
@@ -48,7 +48,6 @@ private:
 public:
     static SfxPoolItem* CreateDefault();
     SvxLongLRSpaceItem(long lLeft, long lRight, sal_uInt16 nId);
-    SvxLongLRSpaceItem(const SvxLongLRSpaceItem &);
     SvxLongLRSpaceItem();
 
     long GetLeft() const { return mlLeft;}
@@ -81,7 +80,6 @@ private:
 public:
     static SfxPoolItem* CreateDefault();
     SvxLongULSpaceItem(long lUpper, long lLower, sal_uInt16 nId);
-    SvxLongULSpaceItem(const SvxLongULSpaceItem &);
     SvxLongULSpaceItem();
 
     long GetUpper() const { return mlLeft;}
@@ -112,7 +110,6 @@ private:
 public:
     static SfxPoolItem* CreateDefault();
     SvxPagePosSizeItem(const Point &rPos, long lWidth, long lHeight);
-    SvxPagePosSizeItem(const SvxPagePosSizeItem &);
     SvxPagePosSizeItem();
 
     const Point &GetPos() const { return aPos; }
@@ -131,8 +128,6 @@ struct SVX_DLLPUBLIC SvxColumnDescription
 
     SvxColumnDescription();
 
-    SvxColumnDescription(const SvxColumnDescription &rCopy);
-
     SvxColumnDescription(long start, long end, bool bVis);
 
     SvxColumnDescription(long start, long end,
@@ -184,10 +179,6 @@ public:
     // nLeft, nRight each the distance to the surrounding frame
     SvxColumnItem(sal_uInt16 nAct = 0);
     SvxColumnItem(sal_uInt16 nActCol, sal_uInt16 nLeft, sal_uInt16 nRight); // Table with borders
-    SvxColumnItem(const SvxColumnItem& aItem);
-    virtual ~SvxColumnItem() override;
-
-    SvxColumnItem &operator=(const SvxColumnItem &);
 
     SvxColumnDescription&       operator[](sal_uInt16 index);
     const SvxColumnDescription& operator[](sal_uInt16 index) const;
@@ -239,7 +230,6 @@ public:
     static SfxPoolItem* CreateDefault();
     SvxObjectItem(long nStartX, long nEndX,
                   long nStartY, long nEndY);
-    SvxObjectItem(const SvxObjectItem& rCopy);
 
     long GetStartX() const { return nStartX;}
     long GetEndX() const { return nEndX;}
diff --git a/include/svx/svxgrahicitem.hxx b/include/svx/svxgrahicitem.hxx
index a5f417feaa66..a4f5bcca2b1c 100644
--- a/include/svx/svxgrahicitem.hxx
+++ b/include/svx/svxgrahicitem.hxx
@@ -31,8 +31,6 @@ class SVX_DLLPUBLIC SvxGraphicItem: public SfxPoolItem
 
 public:
                             SvxGraphicItem( const Graphic& rGraphic);
-                            SvxGraphicItem( const SvxGraphicItem& );
-
 
     virtual bool            operator==( const SfxPoolItem& ) const override;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
diff --git a/include/svx/zoomslideritem.hxx b/include/svx/zoomslideritem.hxx
index 0bff42560dc6..d58f74b93881 100644
--- a/include/svx/zoomslideritem.hxx
+++ b/include/svx/zoomslideritem.hxx
@@ -35,8 +35,6 @@ public:
     static SfxPoolItem* CreateDefault();
 
     SvxZoomSliderItem( sal_uInt16 nCurrentZoom = 100, sal_uInt16 nMinZoom = 20, sal_uInt16 nMaxZoom = 600, sal_uInt16 nWhich = SID_ATTR_ZOOMSLIDER );
-    SvxZoomSliderItem( const SvxZoomSliderItem& );
-    virtual ~SvxZoomSliderItem() override;
 
     void AddSnappingPoint( sal_Int32 nNew );
     const css::uno::Sequence < sal_Int32 >& GetSnappingPoints() const { return maValues;}