Move (and rename) graphic stuff from svtools to vcl

This is preparing to change how GraphicManager works where it
won't base itself around GraphicObject anymore but Graphic. No
functional or cosmetic change was made to the classes, only
changes that were needed because of the move and rename.

The only thing that wasn't moved is the GraphicRenderer as it
is not needed in vcl for now (but makes sense to move it in the
future to keep graphic stuff together).

grfmgr was renamed to GraphicObject as the GraphicManager will be
changed a lot and most likely moved out, so the name grfmgr won't
make any sense anymore.

All the UNO implementations were renamed with a prefix Uno and
used the same name as the class name. This is made to be more
specific which are the Uno objects (for example graphic.cxx
contained the implementation of XGraphic, which is similar to
graph.cxx contains Graphic).

Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137
Reviewed-on: https://gerrit.libreoffice.org/51068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

16 files changed, 46 insertions, 45 deletions

diff --git a/include/drawinglayer/primitive2d/graphicprimitive2d.hxx b/include/drawinglayer/primitive2d/graphicprimitive2d.hxx
index 34b1fc315268..b3127145be19 100644
--- a/include/drawinglayer/primitive2d/graphicprimitive2d.hxx
+++ b/include/drawinglayer/primitive2d/graphicprimitive2d.hxx
@@ -24,7 +24,7 @@
 
 #include <drawinglayer/primitive2d/baseprimitive2d.hxx>
 #include <basegfx/matrix/b2dhommatrix.hxx>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 
 
 namespace drawinglayer
diff --git a/include/drawinglayer/primitive2d/graphicprimitivehelper2d.hxx b/include/drawinglayer/primitive2d/graphicprimitivehelper2d.hxx
index 541168184b88..8eb3c43918e1 100644
--- a/include/drawinglayer/primitive2d/graphicprimitivehelper2d.hxx
+++ b/include/drawinglayer/primitive2d/graphicprimitivehelper2d.hxx
@@ -21,7 +21,7 @@
 
 #include <drawinglayer/drawinglayerdllapi.h>
 #include <drawinglayer/primitive2d/baseprimitive2d.hxx>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 
 
 // predefines
diff --git a/include/editeng/bulletitem.hxx b/include/editeng/bulletitem.hxx
index ddcbb28ddf89..012138c3b7ca 100644
--- a/include/editeng/bulletitem.hxx
+++ b/include/editeng/bulletitem.hxx
@@ -22,7 +22,7 @@
 #include <memory>
 #include <editeng/editengdllapi.h>
 #include <svl/poolitem.hxx>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <vcl/font.hxx>
 
 
diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx
index 43d6f99a8e62..5ef2a56ac05c 100644
--- a/include/editeng/outliner.hxx
+++ b/include/editeng/outliner.hxx
@@ -37,7 +37,7 @@
 #include <editeng/editengdllapi.h>
 #include <com/sun/star/lang/Locale.hpp>
 
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 
 #include <LibreOfficeKit/LibreOfficeKitTypes.h>
 #include <com/sun/star/uno/Reference.h>
diff --git a/include/filter/msfilter/escherex.hxx b/include/filter/msfilter/escherex.hxx
index 82880496a948..d9f83294b5a7 100644
--- a/include/filter/msfilter/escherex.hxx
+++ b/include/filter/msfilter/escherex.hxx
@@ -33,7 +33,7 @@
 #include <rtl/string.hxx>
 #include <rtl/ustring.hxx>
 #include <sal/types.h>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <svx/svdtypes.hxx>
 #include <svx/msdffdef.hxx>
 #include <tools/gen.hxx>
diff --git a/include/svx/galctrl.hxx b/include/svx/galctrl.hxx
index 1ca339904fb8..953b53c18490 100644
--- a/include/svx/galctrl.hxx
+++ b/include/svx/galctrl.hxx
@@ -33,7 +33,7 @@
 #include <svtools/transfer.hxx>
 #include <svtools/valueset.hxx>
 #include <svtools/brwbox.hxx>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <svx/galmisc.hxx>
 #include <svx/svxdllapi.h>
 
diff --git a/include/svx/grfflt.hxx b/include/svx/grfflt.hxx
index b3896c0e1387..2600ee999c8c 100644
--- a/include/svx/grfflt.hxx
+++ b/include/svx/grfflt.hxx
@@ -20,7 +20,7 @@
 #ifndef INCLUDED_SVX_GRFFLT_HXX
 #define INCLUDED_SVX_GRFFLT_HXX
 
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <svx/svxdllapi.h>
 
 enum class SvxGraphicFilterResult {
diff --git a/include/svx/sdgmoitm.hxx b/include/svx/sdgmoitm.hxx
index 7e508e16cabd..e17149102821 100644
--- a/include/svx/sdgmoitm.hxx
+++ b/include/svx/sdgmoitm.hxx
@@ -20,7 +20,7 @@
 #ifndef INCLUDED_SVX_SDGMOITM_HXX
 #define INCLUDED_SVX_SDGMOITM_HXX
 
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <svl/eitem.hxx>
 #include <svx/svddef.hxx>
 #include <svx/svxdllapi.h>
diff --git a/include/svx/svdograf.hxx b/include/svx/svdograf.hxx
index abea8f1b222e..65b934847489 100644
--- a/include/svx/svdograf.hxx
+++ b/include/svx/svdograf.hxx
@@ -24,7 +24,7 @@
 #include <com/sun/star/graphic/XGraphic.hpp>
 #include <vcl/graph.hxx>
 #include <svx/svdorect.hxx>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <svx/svxdllapi.h>
 #include <o3tl/typed_flags_set.hxx>
 
diff --git a/include/svx/unoapi.hxx b/include/svx/unoapi.hxx
index 8000220b2940..9c019a5a83a2 100644
--- a/include/svx/unoapi.hxx
+++ b/include/svx/unoapi.hxx
@@ -23,7 +23,7 @@
 #include <com/sun/star/drawing/XShape.hpp>
 #include <com/sun/star/drawing/XDrawPage.hpp>
 #include <sal/types.h>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <svl/poolitem.hxx>
 #include <svx/svxdllapi.h>
 #include <tools/fldunit.hxx>
diff --git a/include/svx/xbitmap.hxx b/include/svx/xbitmap.hxx
index e062a0aebc5a..3f817cd4b0a5 100644
--- a/include/svx/xbitmap.hxx
+++ b/include/svx/xbitmap.hxx
@@ -23,7 +23,7 @@
 #include <memory>
 #include <tools/color.hxx>
 #include <vcl/bitmap.hxx>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <svx/xenum.hxx>
 #include <svx/svxdllapi.h>
 
diff --git a/include/svx/xbtmpit.hxx b/include/svx/xbtmpit.hxx
index 7c2e2fa2582c..2f8e5f1181ee 100644
--- a/include/svx/xbtmpit.hxx
+++ b/include/svx/xbtmpit.hxx
@@ -22,7 +22,7 @@
 
 #include <svx/svxdllapi.h>
 #include <svx/xit.hxx>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <array>
 
 class SdrModel;
diff --git a/include/svx/xmlgrhlp.hxx b/include/svx/xmlgrhlp.hxx
index 578b9a5f98fb..79d9123a58ef 100644
--- a/include/svx/xmlgrhlp.hxx
+++ b/include/svx/xmlgrhlp.hxx
@@ -22,7 +22,7 @@
 
 #include <cppuhelper/compbase.hxx>
 #include <osl/mutex.hxx>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <vector>
 #include <set>
 #include <utility>
diff --git a/include/svx/xtable.hxx b/include/svx/xtable.hxx
index 1012303e0586..e83155a0f5de 100644
--- a/include/svx/xtable.hxx
+++ b/include/svx/xtable.hxx
@@ -37,7 +37,7 @@
 #include <com/sun/star/embed/XStorage.hpp>
 #include <basegfx/polygon/b2dpolypolygon.hxx>
 #include <com/sun/star/container/XNameContainer.hpp>
-#include <svtools/grfmgr.hxx>
+#include <vcl/GraphicObject.hxx>
 #include <svx/XPropertyEntry.hxx>
 
 #include <limits>
diff --git a/include/svtools/grfmgr.hxx b/include/vcl/GraphicObject.hxx
index c2c70256ceaa..3025b48fee05 100644
--- a/include/svtools/grfmgr.hxx
+++ b/include/vcl/GraphicObject.hxx
@@ -17,12 +17,12 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SVTOOLS_GRFMGR_HXX
-#define INCLUDED_SVTOOLS_GRFMGR_HXX
+#ifndef INCLUDED_VCL_GRAPHICOBJECT_HXX
+#define INCLUDED_VCL_GRAPHICOBJECT_HXX
 
 #include <memory>
 #include <vcl/graph.hxx>
-#include <svtools/svtdllapi.h>
+#include <vcl/dllapi.h>
 #include <o3tl/typed_flags_set.hxx>
 
 #include <unordered_set>
@@ -79,7 +79,7 @@ class VirtualDevice;
 struct GrfSimpleCacheObj;
 struct ImplTileInfo;
 
-class SVT_DLLPUBLIC GraphicAttr
+class VCL_DLLPUBLIC GraphicAttr
 {
 private:
 
@@ -165,7 +165,7 @@ public:
                     }
 };
 
-class SVT_DLLPUBLIC GraphicObject
+class VCL_DLLPUBLIC GraphicObject
 {
     friend class GraphicManager;
     friend class SdrGrafObj;
@@ -197,10 +197,10 @@ private:
     bool                    mbIsInSwapIn    : 1;
     bool                    mbIsInSwapOut   : 1;
 
-    void                    SVT_DLLPRIVATE ImplAssignGraphicData();
-    static void             SVT_DLLPRIVATE ImplEnsureGraphicManager();
-    void                    SVT_DLLPRIVATE ImplAutoSwapIn();
-    bool                    SVT_DLLPRIVATE ImplGetCropParams(
+    void                    VCL_DLLPRIVATE ImplAssignGraphicData();
+    static void             VCL_DLLPRIVATE ImplEnsureGraphicManager();
+    void                    VCL_DLLPRIVATE ImplAutoSwapIn();
+    bool                    VCL_DLLPRIVATE ImplGetCropParams(
                                 OutputDevice const * pOut,
                                 Point& rPt,
                                 Size& rSz,
@@ -247,7 +247,7 @@ private:
 
         @return true, if everything was successfully rendered.
     */
-    bool SVT_DLLPRIVATE     ImplRenderTempTile(
+    bool VCL_DLLPRIVATE     ImplRenderTempTile(
                                 VirtualDevice& rVDev,
                                 int nNumTilesX,
                                 int nNumTilesY,
@@ -257,7 +257,7 @@ private:
                             );
 
     /// internally called by ImplRenderTempTile()
-    bool SVT_DLLPRIVATE     ImplRenderTileRecursive(
+    bool VCL_DLLPRIVATE     ImplRenderTileRecursive(
                                 VirtualDevice& rVDev,
                                 int nExponent,
                                 int nMSBFactor,
@@ -271,7 +271,7 @@ private:
                                 ImplTileInfo& rTileInfo
                             );
 
-    bool SVT_DLLPRIVATE     ImplDrawTiled(
+    bool VCL_DLLPRIVATE     ImplDrawTiled(
                                 OutputDevice* pOut,
                                 const tools::Rectangle& rArea,
                                 const Size& rSizePixel,
@@ -281,7 +281,7 @@ private:
                                 int nTileCacheSize1D
                             );
 
-    bool SVT_DLLPRIVATE     ImplDrawTiled(
+    bool VCL_DLLPRIVATE     ImplDrawTiled(
                                 OutputDevice& rOut,
                                 const Point& rPos,
                                 int nNumTilesX,
@@ -291,7 +291,7 @@ private:
                                 GraphicManagerDrawFlags nFlags
                             );
 
-    void SVT_DLLPRIVATE     ImplTransformBitmap(
+    void VCL_DLLPRIVATE     ImplTransformBitmap(
                                 BitmapEx&           rBmpEx,
                                 const GraphicAttr&  rAttr,
                                 const Size&         rCropLeftTop,
@@ -305,7 +305,7 @@ private:
 
     // Handle evtl. needed AfterDataChanges, needs to be called when new
     // graphic data is swapped in/added to the GraphicManager
-    void SVT_DLLPRIVATE     ImplAfterDataChange();
+    void VCL_DLLPRIVATE     ImplAfterDataChange();
 protected:
 
     SvStream*               GetSwapStream() const;
@@ -487,7 +487,7 @@ public:
     sal_uLong GetDataChangeTimeStamp() const { return mnDataChangeTimeStamp; }
 };
 
-class SVT_DLLPUBLIC GraphicManager
+class VCL_DLLPUBLIC GraphicManager
 {
     friend class GraphicObject;
     friend class GraphicDisplayCacheEntry;
@@ -501,7 +501,7 @@ private:
                         GraphicManager( const GraphicManager& ) = delete;
     GraphicManager&     operator=( const GraphicManager& ) = delete;
 
-    bool SVT_DLLPRIVATE ImplDraw(
+    bool VCL_DLLPRIVATE ImplDraw(
                             OutputDevice* pOut,
                             const Point& rPt,
                             const Size& rSz,
@@ -510,7 +510,7 @@ private:
                             bool& rCached
                         );
 
-    static bool SVT_DLLPRIVATE ImplCreateOutput(
+    static bool VCL_DLLPRIVATE ImplCreateOutput(
                             OutputDevice* pOut,
                             const Point& rPt,
                             const Size& rSz,
@@ -518,7 +518,7 @@ private:
                             const GraphicAttr& rAttr,
                             BitmapEx* pBmpEx = nullptr
                         );
-    static bool SVT_DLLPRIVATE ImplCreateOutput(
+    static bool VCL_DLLPRIVATE ImplCreateOutput(
                             OutputDevice* pOut,
                             const Point& rPt,
                             const Size& rSz,
@@ -528,23 +528,23 @@ private:
                             BitmapEx& rOutBmpEx
                         );
 
-    static void SVT_DLLPRIVATE ImplAdjust(
+    static void VCL_DLLPRIVATE ImplAdjust(
                             BitmapEx& rBmpEx,
                             const GraphicAttr& rAttr,
                             GraphicAdjustmentFlags nAdjustmentFlags
                         );
-    static void SVT_DLLPRIVATE ImplAdjust(
+    static void VCL_DLLPRIVATE ImplAdjust(
                             GDIMetaFile& rMtf,
                             const GraphicAttr& rAttr,
                             GraphicAdjustmentFlags nAdjustmentFlags
                         );
-    static void SVT_DLLPRIVATE ImplAdjust(
+    static void VCL_DLLPRIVATE ImplAdjust(
                             Animation& rAnimation,
                             const GraphicAttr& rAttr,
                             GraphicAdjustmentFlags nAdjustmentFlags
                         );
 
-    static void SVT_DLLPRIVATE ImplDraw(
+    static void VCL_DLLPRIVATE ImplDraw(
                             OutputDevice* pOut,
                             const Point& rPt,
                             const Size& rSz,
@@ -553,20 +553,20 @@ private:
                         );
 
                     // Only used by GraphicObject's Ctor's and Dtor's
-    void SVT_DLLPRIVATE ImplRegisterObj(
+    void VCL_DLLPRIVATE ImplRegisterObj(
                             const GraphicObject& rObj,
                             Graphic& rSubstitute,
                             const OString* pID,
                             const GraphicObject* pCopyObj
                         );
-    void SVT_DLLPRIVATE ImplUnregisterObj( const GraphicObject& rObj );
-    bool SVT_DLLPRIVATE ImplHasObjects() const { return !maObjList.empty(); }
+    void VCL_DLLPRIVATE ImplUnregisterObj( const GraphicObject& rObj );
+    bool VCL_DLLPRIVATE ImplHasObjects() const { return !maObjList.empty(); }
 
                     // Only used in swap case by GraphicObject
-    void SVT_DLLPRIVATE ImplGraphicObjectWasSwappedOut( const GraphicObject& rObj );
-    void SVT_DLLPRIVATE ImplGraphicObjectWasSwappedIn( const GraphicObject& rObj );
+    void VCL_DLLPRIVATE ImplGraphicObjectWasSwappedOut( const GraphicObject& rObj );
+    void VCL_DLLPRIVATE ImplGraphicObjectWasSwappedIn( const GraphicObject& rObj );
 
-    OString SVT_DLLPRIVATE ImplGetUniqueID( const GraphicObject& rObj ) const;
+    OString VCL_DLLPRIVATE ImplGetUniqueID( const GraphicObject& rObj ) const;
 
     // This method allows to check memory footprint for all currently swapped in GraphicObjects on this GraphicManager
     // which are based on Bitmaps. This is needed on 32Bit systems and only does something on those systems. The problem
@@ -575,7 +575,7 @@ private:
     // For 32Bit systems this leads to situations where graphics will be missing. This method will actively swap out
     // the longest swapped in graphics until a maximum memory boundary (derived from user settings in tools/options/memory)
     // is no longer exceeded
-    void SVT_DLLPRIVATE ImplCheckSizeOfSwappedInGraphics(const GraphicObject* pGraphicToIgnore);
+    void VCL_DLLPRIVATE ImplCheckSizeOfSwappedInGraphics(const GraphicObject* pGraphicToIgnore);
 public:
 
                         GraphicManager( sal_uLong nCacheSize, sal_uLong nMaxObjCacheSize );
@@ -605,6 +605,6 @@ public:
                         );
 };
 
-#endif // INCLUDED_SVTOOLS_GRFMGR_HXX
+#endif // INCLUDED_VCL_GRAPHICOBJECT_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/dllapi.h b/include/vcl/dllapi.h
index 0187fa04d115..b85e2ab87ce5 100644
--- a/include/vcl/dllapi.h
+++ b/include/vcl/dllapi.h
@@ -28,6 +28,7 @@
 #else
 #define VCL_DLLPUBLIC SAL_DLLPUBLIC_IMPORT
 #endif
+#define VCL_DLLPRIVATE SAL_DLLPRIVATE
 
 #if defined DLLIMPLEMENTATION_UITEST
 #define UITEST_DLLPUBLIC SAL_DLLPUBLIC_EXPORT