More -Werror,-Wunused-private-field

...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628

12 files changed, 1 insertions, 16 deletions

diff --git a/include/basic/modsizeexceeded.hxx b/include/basic/modsizeexceeded.hxx
index fea636fcb937..a94bcc39e8bd 100644
--- a/include/basic/modsizeexceeded.hxx
+++ b/include/basic/modsizeexceeded.hxx
@@ -43,7 +43,6 @@ class BASIC_DLLPUBLIC ModuleSizeExceeded : public ::cppu::WeakImplHelper1< ::com
 
     // member
     private:
-    OUString m_sMods;
     com::sun::star::uno::Any m_aRequest;
     com::sun::star::uno::Sequence< com::sun::star::uno::Reference< com::sun::star::task::XInteractionContinuation > > m_lContinuations;
     com::sun::star::uno::Reference< com::sun::star::task::XInteractionContinuation > m_xAbort;
diff --git a/include/helpcompiler/HelpSearch.hxx b/include/helpcompiler/HelpSearch.hxx
index b177430a28e0..a1ce783ef6ae 100644
--- a/include/helpcompiler/HelpSearch.hxx
+++ b/include/helpcompiler/HelpSearch.hxx
@@ -17,16 +17,14 @@
 
 class L10N_DLLPUBLIC HelpSearch{
 	private:
-                OUString d_lang;
                 OString d_indexDir;
 
 	public:
 
 	/**
-	 * @param lang Help files language.
 	 * @param indexDir The directory where the index files are stored.
 	 */
-        HelpSearch(OUString const &lang, OUString const &indexDir);
+        HelpSearch(OUString const &indexDir);
 
 	/**
 	 * Query the index for a certain query string.
diff --git a/include/oox/ppt/soundactioncontext.hxx b/include/oox/ppt/soundactioncontext.hxx
index 95d922bba455..7b72e03e038c 100644
--- a/include/oox/ppt/soundactioncontext.hxx
+++ b/include/oox/ppt/soundactioncontext.hxx
@@ -41,8 +41,6 @@ private:
     bool                              mbHasStartSound;
     bool                              mbLoopSound;
     bool                              mbStopSound;
-    OUString                   msEmbedded;
-    OUString                   msLink;
     OUString                   msSndName;
 };
 
diff --git a/include/svx/bmpmask.hxx b/include/svx/bmpmask.hxx
index 480e8e2fdf6b..395f495d1ff7 100644
--- a/include/svx/bmpmask.hxx
+++ b/include/svx/bmpmask.hxx
@@ -81,7 +81,6 @@ class SVX_DLLPUBLIC SvxBmpMask : public SfxDockingWindow
     friend class MaskData;
     friend class MaskSet;
 
-    Size                aLastSize;
     ToolBox             aTbxPipette;
     ColorWindow*        pCtlPipette;
     PushButton          aBtnExec;
diff --git a/include/svx/numvset.hxx b/include/svx/numvset.hxx
index eefdcb9c8ed7..ae5a402fd377 100644
--- a/include/svx/numvset.hxx
+++ b/include/svx/numvset.hxx
@@ -90,7 +90,6 @@ class SVX_DLLPUBLIC SvxNumValueSet : public ValueSet
 
 class SVX_DLLPUBLIC SvxBmpNumValueSet : public SvxNumValueSet
 {
-    OUString    sBullets;
     Timer       aFormatTimer;
     bool        bGrfNotFound;
 
diff --git a/include/svx/tbcontrl.hxx b/include/svx/tbcontrl.hxx
index 5b6a88fe782a..36426dac3236 100644
--- a/include/svx/tbcontrl.hxx
+++ b/include/svx/tbcontrl.hxx
@@ -185,7 +185,6 @@ private:
                                         m_xBoundItems[MAX_FAMILIES];
     SfxTemplateItem*                    pFamilyState[MAX_FAMILIES];
     sal_uInt16                          nActFamily; // Id in the ToolBox = Position - 1
-    OUString                            aCurSel;
     Impl*                               pImpl;
 
     SVX_DLLPRIVATE void Update();
diff --git a/include/toolkit/controls/unocontrols.hxx b/include/toolkit/controls/unocontrols.hxx
index 3f1e21e75ddd..60268c5b4ff1 100644
--- a/include/toolkit/controls/unocontrols.hxx
+++ b/include/toolkit/controls/unocontrols.hxx
@@ -363,7 +363,6 @@ class UnoImageControlControl : public UnoImageControlControl_Base
 {
 private:
     ActionListenerMultiplexer   maActionListeners;
-    OUString             maActionCommand;
 
 public:
 
diff --git a/include/vcl/edit.hxx b/include/vcl/edit.hxx
index 58a49db4733f..e61d31f56b72 100644
--- a/include/vcl/edit.hxx
+++ b/include/vcl/edit.hxx
@@ -76,7 +76,6 @@ private:
     OUString            maPlaceholderText;
     OUString            maSaveValue;
     OUString            maUndoText;
-    OUString            maRedoText;
     long                mnXOffset;
     Selection           maSelection;
     sal_uInt16          mnAlign;
diff --git a/include/xmloff/XMLTextMasterPageContext.hxx b/include/xmloff/XMLTextMasterPageContext.hxx
index 929873b2d9d0..b562f652b03e 100644
--- a/include/xmloff/XMLTextMasterPageContext.hxx
+++ b/include/xmloff/XMLTextMasterPageContext.hxx
@@ -32,7 +32,6 @@ namespace com { namespace sun { namespace star {
 class XMLOFF_DLLPUBLIC XMLTextMasterPageContext : public SvXMLStyleContext
 {
     const OUString sIsPhysical;
-    const OUString sPageStyleLayout;
     const OUString sFollowStyle;
     OUString       sFollow;
     OUString       sPageMasterName;
diff --git a/include/xmloff/xmlnume.hxx b/include/xmloff/xmlnume.hxx
index f98c7b92f11a..8418ef26fe70 100644
--- a/include/xmloff/xmlnume.hxx
+++ b/include/xmloff/xmlnume.hxx
@@ -40,8 +40,6 @@ class XMLTextListAutoStylePool;
 class SvxXMLNumRuleExport
 {
     SvXMLExport& rExport;
-    const OUString sCDATA;
-    const OUString sWS;
     const OUString sNumberingRules;
     const OUString sIsPhysical;
     const OUString sIsContinuousNumbering;
diff --git a/include/xmloff/xmlnumfi.hxx b/include/xmloff/xmlnumfi.hxx
index 201c4022cc28..e3426ac72dd7 100644
--- a/include/xmloff/xmlnumfi.hxx
+++ b/include/xmloff/xmlnumfi.hxx
@@ -128,7 +128,6 @@ class XMLOFF_DLLPUBLIC SvXMLNumFormatContext : public SvXMLStyleContext
     OUString       sFormatTitle;
 //  OUString       sMapName;
     OUString       sCalendar;
-    OUString       sFormatString;
     LanguageType   nFormatLang;
     com::sun::star::lang::Locale    aLocale;
     bool            bAutoOrder;
diff --git a/include/xmloff/xmlnumi.hxx b/include/xmloff/xmlnumi.hxx
index 304fadd5a71c..4e7bc1591d5c 100644
--- a/include/xmloff/xmlnumi.hxx
+++ b/include/xmloff/xmlnumi.hxx
@@ -34,7 +34,6 @@ class SvxXMLListStyleContext : public SvXMLStyleContext
 {
     const OUString       sIsPhysical;
     const OUString       sNumberingRules;
-    const OUString       sName;
     const OUString       sIsContinuousNumbering;
 
     ::com::sun::star::uno::Reference <