loplugin:constantparam

Change-Id: Ia58d8950b3b9e48bbe9f075b9fe1eed62d9abf0d
Reviewed-on: https://gerrit.libreoffice.org/53188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 13 insertions, 22 deletions

diff --git a/include/basegfx/polygon/b2dpolygoncutandtouch.hxx b/include/basegfx/polygon/b2dpolygoncutandtouch.hxx
index 61a5c5a7a7da..536f11a693b0 100644
--- a/include/basegfx/polygon/b2dpolygoncutandtouch.hxx
+++ b/include/basegfx/polygon/b2dpolygoncutandtouch.hxx
@@ -36,8 +36,7 @@ namespace basegfx
         // look for polypolygon-intersections and polypolygon-touches (point of poly A on an edge of poly B) in given tools::PolyPolygon and add
         // extra points there. Result will have no touches or intersections between contained polygons on an edge, only on points. For
         // convenience, the correction for self-intersections for each member polygon will be used, too.
-        // Changed: Self intersections are searched by default, but may be switched off by 2nd parameter.
-        BASEGFX_DLLPUBLIC B2DPolyPolygon addPointsAtCutsAndTouches(const B2DPolyPolygon& rCandidate, bool bSelfIntersections = true);
+        BASEGFX_DLLPUBLIC B2DPolyPolygon addPointsAtCutsAndTouches(const B2DPolyPolygon& rCandidate);
 
         // look for intersections of rCandidate with the edge from rStart to rEnd and add extra points there.
         // Points are only added in the range of the edge, not on the endless vector.
diff --git a/include/basegfx/polygon/b2dpolygontools.hxx b/include/basegfx/polygon/b2dpolygontools.hxx
index 8b5ee03c96e1..039000f053d1 100644
--- a/include/basegfx/polygon/b2dpolygontools.hxx
+++ b/include/basegfx/polygon/b2dpolygontools.hxx
@@ -448,8 +448,7 @@ namespace basegfx
 
         /// converters for css::drawing::PointSequence
         BASEGFX_DLLPUBLIC B2DPolygon UnoPointSequenceToB2DPolygon(
-            const css::drawing::PointSequence& rPointSequenceSource,
-            bool bCheckClosed = true);
+            const css::drawing::PointSequence& rPointSequenceSource);
         BASEGFX_DLLPUBLIC void B2DPolygonToUnoPointSequence(
             const B2DPolygon& rPolygon,
             css::drawing::PointSequence& rPointSequenceRetval);
@@ -459,8 +458,7 @@ namespace basegfx
          */
         B2DPolygon UnoPolygonBezierCoordsToB2DPolygon(
             const css::drawing::PointSequence& rPointSequenceSource,
-            const css::drawing::FlagSequence& rFlagSequenceSource,
-            bool bCheckClosed);
+            const css::drawing::FlagSequence& rFlagSequenceSource);
         void B2DPolygonToUnoPolygonBezierCoords(
             const B2DPolygon& rPolyPolygon,
             css::drawing::PointSequence& rPointSequenceRetval,
diff --git a/include/registry/reader.hxx b/include/registry/reader.hxx
index 54b6a12f9541..d25e719119ed 100644
--- a/include/registry/reader.hxx
+++ b/include/registry/reader.hxx
@@ -58,7 +58,7 @@ public:
      */
     Reader(void const * buffer, sal_uInt32 length)
     {
-        if (!typereg_reader_create(buffer, length, false/*copy*/, TYPEREG_VERSION_1, &m_handle))
+        if (!typereg_reader_create(buffer, length, &m_handle))
         {
             throw std::bad_alloc();
         }
diff --git a/include/registry/typereg_reader.hxx b/include/registry/typereg_reader.hxx
index 3d5a2cfd830d..f6aa5f59b61c 100644
--- a/include/registry/typereg_reader.hxx
+++ b/include/registry/typereg_reader.hxx
@@ -34,19 +34,14 @@
    reference count will be one.  Operations on a non-null handle are not
    multi-thread&ndash;safe.</p>
 
+   The type reader works directly on the given buffer, which must remain
+   available unmodified until the type reader is destroyed
+
    @param buffer the binary blob representing the type; must point to at least
    <code>length</code> bytes, and need only be byte-aligned
 
    @param length the size in bytes of the binary blob representing the type
 
-   @param copy if true, the type reader creates an internal copy of the given
-   buffer, and the given buffer is not accessed after this function returns; if
-   false, the type reader works directly on the given buffer, which must remain
-   available unmodified until the type reader is destroyed
-
-   @param maxVersion the maximum binary blob version the client is prepared to
-   handle; must not be negative
-
    @param result an out-parameter obtaining a handle on the type reader; must
    not be null; if the given binary blob is malformed, or of a version larger
    than <code>maxVersion</code>, null is returned
@@ -57,8 +52,8 @@
    @since UDK 3.2.0
  */
 REG_DLLPUBLIC bool typereg_reader_create(
-    void const * buffer, sal_uInt32 length, bool copy,
-    typereg_Version maxVersion, void ** result);
+    void const * buffer, sal_uInt32 length,
+    void ** result);
 
 /**
    Increments the reference count of a type reader.
diff --git a/include/svx/galmisc.hxx b/include/svx/galmisc.hxx
index 5605c8a093f0..0bdcbffa86d3 100644
--- a/include/svx/galmisc.hxx
+++ b/include/svx/galmisc.hxx
@@ -81,7 +81,7 @@ class FmFormModel;
 class ImageMap;
 class Gallery;
 
-GalleryGraphicImportRet  GalleryGraphicImport( const INetURLObject& rURL, Graphic& rGraphic, OUString& rFilterName, bool bShowProgress = false );
+GalleryGraphicImportRet  GalleryGraphicImport( const INetURLObject& rURL, Graphic& rGraphic, OUString& rFilterName );
 bool                GallerySvDrawImport( SvStream& rIStm, SdrModel& rModel );
 bool                CreateIMapGraphic( const FmFormModel& rModel, Graphic& rGraphic, ImageMap& rImageMap );
 SVX_DLLPUBLIC OUString
diff --git a/include/svx/passwd.hxx b/include/svx/passwd.hxx
index 227d1288f813..ef9bfca867fd 100644
--- a/include/svx/passwd.hxx
+++ b/include/svx/passwd.hxx
@@ -30,7 +30,6 @@ private:
     OUString m_aOldPasswdErrStr;
     OUString m_aRepeatPasswdErrStr;
     Link<SvxPasswordDialog*,bool> m_aCheckPasswordHdl;
-    bool m_bEmpty;
 
     std::unique_ptr<weld::Label> m_xOldFL;
     std::unique_ptr<weld::Label> m_xOldPasswdFT;
@@ -43,7 +42,7 @@ private:
     DECL_LINK(EditModifyHdl, weld::Entry&, void);
 
 public:
-    SvxPasswordDialog(weld::Window* pParent, bool bAllowEmptyPasswords, bool bDisableOldPassword);
+    SvxPasswordDialog(weld::Window* pParent, bool bDisableOldPassword);
     virtual ~SvxPasswordDialog() override;
 
     OUString        GetOldPassword() const { return m_xOldPasswdED->get_text(); }
diff --git a/include/tools/urlobj.hxx b/include/tools/urlobj.hxx
index 3624d2f89122..6abb875ff18f 100644
--- a/include/tools/urlobj.hxx
+++ b/include/tools/urlobj.hxx
@@ -866,11 +866,11 @@ public:
     static void appendUCS4Escape(OUStringBuffer & rTheText, sal_uInt32 nUCS4);
 
     static void appendUCS4(OUStringBuffer & rTheText, sal_uInt32 nUCS4,
-                           EscapeType eEscapeType, bool bOctets, Part ePart,
+                           EscapeType eEscapeType, Part ePart,
                            rtl_TextEncoding eCharset, bool bKeepVisibleEscapes);
 
     static sal_uInt32 getUTF32(sal_Unicode const *& rBegin,
-                               sal_Unicode const * pEnd, bool bOctets,
+                               sal_Unicode const * pEnd,
                                EncodeMechanism eMechanism,
                                rtl_TextEncoding eCharset,
                                EscapeType & rEscapeType);